Received-SPF: pass (google.com: domain of linux-kernel+bounces-45169-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4478a4b0-fd17-4d5f-b11c-ba4a867bf92b@amd.com>
Date: Tue, 30 Jan 2024 13:10:09 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] PCI: Disable D3cold on Asus B1400 PCI-NVMe bridge
Content-Language: en-US
To: Daniel Drake <drake@endlessos.org>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 bhelgaas@google.com, david.e.box@linux.intel.com,
 Jian-Hong Pan <jhp@endlessos.org>
References: <20240130183124.19985-1-drake@endlessos.org>
 <7a8f3595-3efc-428a-852a-d9edc8ebb01b@amd.com>
 <CAD8Lp45ycrY-hkKVZGEQdeYmODauaShgFp2tj=QtEXK_C2tcYA@mail.gmail.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <CAD8Lp45ycrY-hkKVZGEQdeYmODauaShgFp2tj=QtEXK_C2tcYA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WEpWbVB2M3JxQkNPc2RtU056M2RTV0VKV2l4NmRFcFRYVFQ0M1pzZEd2NCs4?=
 =?utf-8?B?d05malFvOEova3lNckFLQzhIY25RZU1ZeDVpMjRadVFVcUdtWDJMSUJYSkUv?=
 =?utf-8?B?S3hVdG1oZHRqSzlqK2w5RDFGei9ZcFhQMlg4KzI4OW5vWnJ4cGJObFZ2ekRv?=
 =?utf-8?B?dlFSalh4TE9jSHgwQVZhbmFiMnd0eTJKRmxITytNUzNMc1kyTVhLNUlRRkRk?=
 =?utf-8?B?NCtsNTJ3UGZxRmttWUIvUHRaVGVyaVlxTzNkdFVHTEs0cmpHWlR1aVlxb0RW?=
 =?utf-8?B?WFhWMVg2cVlnektTMXZNSE9uOE1uVnVMdEdHOS9WLzZyMzhVV3ZoN1paeHAz?=
 =?utf-8?B?NEI5UkZTRldNU2NrN0RoR2dvb01NWXN0ajVOcUxER25xWnZ3RnRvZ1orSEcw?=
 =?utf-8?B?NXlFT2h1K3pVOEt5WkdiQWVEUkpaL0x5Z2N5anhiazZaOGExaHJMd2o0dWVn?=
 =?utf-8?B?aWN2V2llem1ucGxiVndRQ1RkWGV5MVhGN09JUk9XbHhqdVkvd0h6V1pmSTIw?=
 =?utf-8?B?aE1pTzMxNi9PWW1lWDc4eGpxaUc0cjkxKzJUeUFPME1IZWxnNE02cHlPTHFD?=
 =?utf-8?B?OXlsNTNLTUdMN0E1cC8vQ0M0MUZldHBMNzBBR1dsNEUwbzlVeFpENnM0bExC?=
 =?utf-8?B?ZHVrbnZ4Zkdzb3UxcWRnSnhSaEZVUDVzbEx2dkNvd082T05vWVZuSGNlbVFL?=
 =?utf-8?B?dmcvbGlBUHhoREZ5TnFzSllDSmVzdHcxL0gzYnpLTklKa2tHamh3NytmSGpN?=
 =?utf-8?B?RGthT1QzaEpFdWcvRFp3aU83aHRPbXZWb012UDc1MkV5RWJYMmg1Tm5QRkRu?=
 =?utf-8?B?a0NQYndlZUVqMGhpY0VEZ2hZZlNDSmlpVlVpYnl2a2ZRZDdPcG5Ib3QrOXJ1?=
 =?utf-8?B?ckVjdEtpK3pNS0pCS1VYL1pna3A0cFZ4YUNzTHBBY2VWSjYwT0FmajZ3YnFP?=
 =?utf-8?B?RXBoTjhpd0xaZjY3ditqTUMweUhGWWM3eUlvWU1NK0FZYy9lOFBBa0RkOUFG?=
 =?utf-8?B?VGZEZ211b1FSWnluRFlxY0xKWXdwSU9RYjZIaFYxYXBGZThTSXVaSW51d0o5?=
 =?utf-8?B?c0M3ZlBWL2orT3lscEwvUVgxVThKdFZFSEpMTDdjdTdENnVMdS8rNFVsWUow?=
 =?utf-8?B?eE8wS2ZaenpSSmE4eE92c1psMmorQkl1czlKcEpwMCtzWEVkMzN5djFWUXkz?=
 =?utf-8?B?OHgxREpqcVNHcGdHTlBWa2pzTGprdm91VmhMRW5Ya2ZKRUFhQ3lSMy9ibWhv?=
 =?utf-8?B?dU50b0lnQ1BOL0NDd0l5YkNybngwSXVRaDBlWmhPRGlIZEVsWVZUSVdrNXQ5?=
 =?utf-8?B?Q0xmOUxGS3FQK0VSU2NwZWg2RG1FSXh0M0JuMWxhZTBSTC9OZCtPZ2ZJajdt?=
 =?utf-8?B?RGdtTXo0YWZFK2toL2FUWEtBb2xETFlIQlNkUnNYUjVLbFBwekZlbUxmbmNX?=
 =?utf-8?B?S1Q0MHZnQzBKU204cENZUEt5Uk00Tk9Id1B2UDFiOWJ5MlJiTHJFM2FWMkx5?=
 =?utf-8?B?T2ZmMXA3dWR4Rmx2QTZLQXljNlZqTkhMZ3JyWnBRVjNRbzdwbUdySEx1eC9C?=
 =?utf-8?B?TlpLcU1acDhiU2hWSVYrZFFkNGFORHBOQS9DMjBzbFFuQnducmF5czlST3B2?=
 =?utf-8?B?WDJpMVk4V0FkNFJUVFdDZHJKY1FTVXVKQjB5aXVEdUgvemNPTnN5OVhSREVZ?=
 =?utf-8?B?RUl0ZVdkZjdZU0V0SSs2Rm8ycXE0cFpzQXVNMldBRHJuOEEzRE04dGV5RlBy?=
 =?utf-8?B?eHBiRE9OZFg4V3pva0laUHRqdGdDS1BiTEhORVBqQURrNnhUKzBmUEx1amZn?=
 =?utf-8?B?R3hxT25Nc1p0WjZCOFpabnIrZDBIaDR1RS91MWlBcFFpVEZGZ0FvWlN6TUdD?=
 =?utf-8?B?YnBkOE02UEw0UU5zYWJuNlBTVWNqL29zcExZRkJBYnBaOUcyb0QzaG53cUZ1?=
 =?utf-8?B?OVdyaThYc2VUVG5ocWtQMkgzQ0p0YTNPbml2Q09uUU0vQ2lNU0lSSUlvYnll?=
 =?utf-8?B?aWh6NlFzazFGWkpQeG5UMVo2K21KV0VwanQyT0hpRVJKVThqQUszVHg4d3lR?=
 =?utf-8?B?ZHRpTXhQNUhIUGs0ZEtrbHNIRVBwYUF4TDRyTW4xSHJkSUg0S2tGS244OFI2?=
 =?utf-8?Q?8pEMd79LK7zGIx5ZD15TCWPrQ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1e84227-1c1b-4aea-a10b-08dc21c7152d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:10:11.8925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xohErMHQbTN284rUqFpD7GUWuOZdNjFwEXhcylpjfIMg76Dp9n/UUAONFSoJvu6fezsapjHIciB/pUYbht8Khw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5883

On 1/30/2024 13:00, Daniel Drake wrote:
> On Tue, Jan 30, 2024 at 2:47 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>> Has there already been a check done whether any newer firmware is
>> available from ASUS that doesn't suffer the deficiency described below?
> 
> The latest firmware does flip StorageD3Enable to 0, which has the side
> effect of never putting the NVMe device or the parent bridge into
> D3cold.
> However, we have shipped hundreds of these devices with the original
> production BIOS version to first time computer users, so it is not
> feasible to ask the end user to upgrade. And there is no
> Linux-compatible online firmware update for this product range. Hence
> a Linux-level workaround for this issue would be highly valuable.

Sure; it makes sense to me why to put a workaround in Linux with your 
above explanation.

Perhaps it make sense to limit the quirk to only the DMI version strings 
of the initial production firmware?

> 
>> Is this the only problem blocking s2idle from working effectively on
>> this platform?  If so, I would think you want to just do the revert in
>> the same series if it's decided this patch needs to spin again for any
>> reason.
> 
> Yes these could be combined into the same series, with agreement from
> the drivers/acpi/ maintainers for the S3 revert.
> 
> Thanks
> Daniel