Received-SPF: pass (google.com: domain of linux-kernel+bounces-45187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 30 Jan 2024 14:25:43 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: thinh.nguyen@synopsys.com, balbi@kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	mark.rutland@arm.com, mathias.nyman@intel.com, pku.leo@gmail.com,
	ran.wang_1@nxp.com, robh+dt@kernel.org,
	sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v4 2/3] dt-bindings: usb: dwc3: Add
 snps,host-vbus-glitches-quirk avoid vbus glitch
Message-ID: <ZblNN6SyuSKhconu@lizhi-Precision-Tower-5810>
References: <20240124152525.3910311-1-Frank.Li@nxp.com>
 <20240124152525.3910311-3-Frank.Li@nxp.com>
 <20240130-eligible-barrette-5b2258e150f5@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130-eligible-barrette-5b2258e150f5@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6T1q9lNhmjpYSSfIh+zIeaTc4RQXSsFw/kH09y+xqM2AkghioafhQ2lpi4Bf?=
 =?us-ascii?Q?6RFYaZzqV/VZg6qpVtasMAdCGAH0PGjDyWemiKTkGAM17yawU/OBHjn9jZdD?=
 =?us-ascii?Q?NbHfkeCmT8eOSC/0Ry1UYx2dcCFtGDGJj/MDq/62puFPFcEngzQsxzLGMnvy?=
 =?us-ascii?Q?z781ubyg61zE0t/DBfL9ZalyMGMYilfHDi1YiWNXWCq+VO74x9k+z1RKDRzm?=
 =?us-ascii?Q?jg0vHIfRJzdmEoXzzEnQx4pzrzA8plo1BK1Y9BBIoSNTz7OwFGYP3Bt+zMbY?=
 =?us-ascii?Q?PYVevZVZpomMuyqlWdNZAY4OpfB6i+H1PPt2HHq/1ggaJ5nxidT18JB/7saZ?=
 =?us-ascii?Q?lrJIjlYFAoLMdrSBrgffuHfDlSI+aYuLo6kfblGHrOr5EcIHjflqTy1Ugd4B?=
 =?us-ascii?Q?so1kR4Af9ZoPf5MGyarLUk/dnMabU/jqYOXxDQi6rbmTz7gGfHKUSkSfNMe6?=
 =?us-ascii?Q?ucaKbAlrsiRX4Hp+Vb62yUoRKpXTPxXLm9u+qTghro/0KahzoY7OTy0lnQM9?=
 =?us-ascii?Q?Apmf38r3nJV+ckg2RFAiNsgORiliIeEOquBX+fFRewH9YFrBcJk7x9YHotOP?=
 =?us-ascii?Q?MapezWggpk7Rp32by+5UxYESJi+eCUdax1tBzusb/5ZyHhORsHGlqlQDkTV/?=
 =?us-ascii?Q?JAJw8BdZGr2qGgfzyP8YmdBMozyG/m/6nooBCktLkOtNX/BH9FmOss+9ATc+?=
 =?us-ascii?Q?3q/cj0bWHsYFTknA9pID0r3LBMwpXymUv52mWBWw0JG7L75EnNhcHaxxhHDw?=
 =?us-ascii?Q?6mdwXdYQQrUk/4/C5YpFp0xjqwlmqMSeQ8NqGzRA7SEw291rQl6dOa/WPdn7?=
 =?us-ascii?Q?QP5tRI6ByJQvLZDX2FUKaWARKEjTHhA342y60gce4oqSyJ6QJl7KZHXqtL2j?=
 =?us-ascii?Q?+VBJB/w3K4iqWGKAcNk5uf/rAwm1gFKlZ47tTxg+kviMKf3KgoWE7+q97Msk?=
 =?us-ascii?Q?dGTQDkBi3tQqwiIbq9G5nGywT4xIW7TCwatvpckzVXf7rgbazkPwC5vo/TvO?=
 =?us-ascii?Q?N9SO2toH7wqM+toEsr11okHaokLOtLwlsSS+GxQZ5lMy++4tzwHh/akUzDd0?=
 =?us-ascii?Q?CH1lOfS0VwjOQpMYMoqgifmxvVWzGtrcaZWtx7JR4pg3wrkt1v8c7DTJWYcQ?=
 =?us-ascii?Q?S8O6imUUl5VOxCY71oGPeA5WjCSSa9oI2JECmvMptGyKspB8FDBnGL0IbXQl?=
 =?us-ascii?Q?lSH3bp9umP3fxaI1Zy3j/j42G80dcNBi6obFS9KZ7OsMCjZtlOKaxMDZbd89?=
 =?us-ascii?Q?uYQWvQtLL3vf2dJaUXuvgPLOb4JCpmpHVZcvp6W1T76hlFoNha9n9DBD1SeN?=
 =?us-ascii?Q?HhcU6WD56ZTnGigYQ53wDxaYSKwriu9oeIbpNyn169MKBAlqbAht1cP3RiGZ?=
 =?us-ascii?Q?Act5/9oCvAd6XsvnJR9U5HtfbeTvIIG9MJK0FfkHxnc0itZSLDal/tSlPZo/?=
 =?us-ascii?Q?hkJopEWRG73/pPUh1wYmiOM129ru0c1ztvIrio6AsCvM1hDetw+1xmMBYqzl?=
 =?us-ascii?Q?uv0SZtsCT8YQztWTD59JNgTwJwM02nGANeIWzLO0PkQi3DiIUG2mTDYRxu7L?=
 =?us-ascii?Q?mn5vXYTmqARcNE20jdhEQBx5UaBULanTF85Y8rje?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b32bbc3c-eee0-4fe9-a2a0-08dc21c945da
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:25:52.6194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s8wzYKLa94XosgJ44eeYS4YBNy18aJEhCSczZaEEbL8JqTAT0Z20p5bADOlIVWp5IYWCP6J1/EhlMRQIojJ5pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7487

On Tue, Jan 30, 2024 at 06:28:25PM +0000, Conor Dooley wrote:
> Hey,
> 
> This version seems to be the lastest (v4) for this binding, but went out
> prior to discussion actually finishing on the v1!! of this patch, even
> ignoring Rob's comment today.
> Please wait for conversations to resolve before sending new versions.
> I, at least, do not get paid for what I do here, so I often need well
> more than a day before I can get around to clearing my review queue.
> On Wed, Jan 24, 2024 at 10:25:24AM -0500, Frank Li wrote:
> 
> > From: Ran Wang <ran.wang_1@nxp.com>
> > 
> > When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS
> > (or its control signal) will turn on immediately on related Root Hub
> > ports. Then the VBUS will be de-asserted for a little while during xhci
> > reset (conducted by xhci driver) for a little while and back to normal.
> > 
> > This VBUS glitch might cause some USB devices emuration fail if kernel
> > boot with them connected. One SW workaround which can fix this is to
> > program all PORTSC[PP] to 0 to turn off VBUS immediately after setting
> > host mode in DWC3 driver(per signal measurement result, it will be too
> > late to do it in xhci-plat.c or xhci.c).
> > 
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > Reviewed-by: Peter Chen <peter.chen@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> 
> Where is your changelog?

Sorry forget add it this patch.

> 
> >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index 203a1eb66691f..8f5d250070c78 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -273,6 +273,13 @@ properties:
> >        with an external supply.
> >      type: boolean
> >  
> > +  snps,host-vbus-glitches-quirk:
> 
> I specifically recall saying no to adding "-quirk" here, but that
> might've been after this patch was sent.

Your comment is at v0 version. I told you there are v4. 

> 
> > +    description:
> > +      When set, power off all Root Hub ports immediately after
> > +      setting host mode to avoid vbus (negative) glitch happen in later
> > +      xhci reset. And the vbus will back to 5V automatically when reset done.
> > +    type: boolean
> 
> Rob commented today on the v1 conversation:
> https://lore.kernel.org/all/20240130181322.GA2079185-robh@kernel.org/
> 
> Please respond (there) to his comment.

Okay I will reply at v1 thread.

> 
> Thanks,
> Conor.
> 
> >    snps,is-utmi-l1-suspend:
> >      description:
> >        True when DWC3 asserts output signal utmi_l1_suspend_n, false when
> > -- 
> > 2.34.1
> >