Received-SPF: pass (google.com: domain of linux-kernel+bounces-45194-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Jan 2024 14:29:53 -0500
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Conor Dooley <conor@kernel.org>, ran.wang_1@nxp.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
	"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, mark.rutland@arm.com,
	pku.leo@gmail.com, sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add snps,host-vbus-glitches
 avoiding vbus glitch
Message-ID: <ZblOMQLhtD1Y8j5d@lizhi-Precision-Tower-5810>
References: <20240119213130.3147517-1-Frank.Li@nxp.com>
 <20240124-unclothed-dodgy-c78b1fffa752@spud>
 <ZbFNIvEaAJCxC2VB@lizhi-Precision-Tower-5810>
 <20240124-video-lumpiness-178c4e317f5a@spud>
 <20240130181322.GA2079185-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130181322.GA2079185-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9goPFkDikZcJMSuQUJl2bd/bjD+V/MkhD039jRcR0b3habGMJKwyKpAS+t94?=
 =?us-ascii?Q?ZxavVY2yqHbr+SaBmJ+IAihDVDxjRNuZqjsUBDcTfnO4L3fDQXJtpfLf9Wuu?=
 =?us-ascii?Q?8L75fO/HiCzkfSpQ8twcGiTVlFFVsPWOawpkSOmZQX8yk3SidccQR5KD8tk+?=
 =?us-ascii?Q?f/mVoPWKJzI8exl+hBziPwN88I7oPZB/sY1nWlEeMAXFTNGtaDdnoT5ntUCS?=
 =?us-ascii?Q?ZmWlrVDioDzSBAfS58FV1YQHGG69s2mZ4q2Fos4MjE4s0feZ97WqyNLlHONh?=
 =?us-ascii?Q?0b1ozDjQmwftNwUzMqICapWZKHkGXUfnCHxutE3BmEeiaWNSb0BrkoIDu+vE?=
 =?us-ascii?Q?ZCLeLOfX0nnbjZ6biJVGhkrIeY+J1IVQr64HmsVroU0hjNyDzp7u0AVukrie?=
 =?us-ascii?Q?yk3dr8ZU4sl1Dydi5K+9YwD/U00cw8ieKMizrOIoKb/qFlaH5yKYCjSftPgj?=
 =?us-ascii?Q?NJDKEOGpqJdlud4+P/dzGKG7RfOjLmKcmzv0ojZZGf5/myUFx2kvlDkKUjiM?=
 =?us-ascii?Q?QQ/GdZHVCbEtZJnTmd6Fcoo/FX0HmlGH6dPIblS7GK/xEtrRAY/0HQC8/i+R?=
 =?us-ascii?Q?m/nHLMyV0MxE0hV26EpWQtPQkeBIVTyd4BwCLJz8hwAPY/6xJ+0cPaLgHCEB?=
 =?us-ascii?Q?3sKYBpzJGZpgfxszocLILSwvIifk42ezwz2nYylHPniT+mDpJCCcST72FB8X?=
 =?us-ascii?Q?v5zWj7YM8uBEJTAvk2Lf65wZDAXN/Kx5EH74hYumWsW5RXgHgiD1e0kSUf0M?=
 =?us-ascii?Q?Qvd7SyL36ksrvSo4ZpQAQkFHgKubADYKKdN9p2BnKqN53wtbBZhIhtZf8d7x?=
 =?us-ascii?Q?nWP6RkhIsDAXFe5cbKxc5p0PP6XWg9cIVlThrHHQ1bXZq4hcMAO3632GWZgd?=
 =?us-ascii?Q?g86r4GpSESYfm/rkdFtTCVhr/QP88KON62uKzw8xzjkTlq3lnK+/oGTV/WZk?=
 =?us-ascii?Q?KCJh4FrVAgGv0hoWLiiIwIMRZk+c5wfCLGSeajB2mQ/2ugZ12UovlV4yU2Ul?=
 =?us-ascii?Q?3VJ30ET8ha5wtI912eRKUGkJyAxThN3I9IpVv9heojTiQp2Dc+3ZPzzlFUaX?=
 =?us-ascii?Q?svU++FEaJQf6PZ6KzXft3do6iki6LkKe/4d/uU/N84FGAFBM9VrUfc55gHZ1?=
 =?us-ascii?Q?W7rrWIyf4WEpJYf5rHpV4KMsvJwOh5J5ihVU5WjWaE09SbsHChhgkpQkh2A4?=
 =?us-ascii?Q?+gZW4qop9IJGdPg0uZM8Xp6ILwJ6hnc4+yyTK6nHjZGefcIZkME71o8QPY8X?=
 =?us-ascii?Q?Vgaxb0eLuap9q64i0n0ArF8U8e83p+VEkiN4MHs5r98/CJnfcWi6sKhXEex3?=
 =?us-ascii?Q?WZcdkuqmoKJxHTPrlqKK5HwUbvAqjy/GYWPzYftI+CZe7/HN/ih9GQ+ArBiy?=
 =?us-ascii?Q?S7H8/jTu96Nw/iHXYdcYOLCnzlFcfJwiF6OalBZu8MUul32eYSX/0JEudzTn?=
 =?us-ascii?Q?sgNlaQSCdU8wdF5gl+JvwWPLeQv78UeCa0BKvb8VcGxCH17EB3Mr7BrTaZD9?=
 =?us-ascii?Q?tMzAQ9wZLOyNrV8BGekmpqtyfyikWOoeYmmfisuRJYGXeK7bftIJ6P1p+XUV?=
 =?us-ascii?Q?WZM0TnG1KE8C3pCJLFUfQ4MM7UT+MIguZXrkMGue?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ec58fa8-4509-4231-b922-08dc21c9da65
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:30:01.8540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hBogE1ho6VpHFc9XiM78BDsvFuRwuI66k+qnfHxPrkyVVNiM+eoo+uNy2eTI93dZ/y9S+G+4BenSiEfT8Qv48g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8194

On Tue, Jan 30, 2024 at 12:13:22PM -0600, Rob Herring wrote:
> On Wed, Jan 24, 2024 at 05:59:00PM +0000, Conor Dooley wrote:
> > On Wed, Jan 24, 2024 at 12:47:14PM -0500, Frank Li wrote:
> > > On Wed, Jan 24, 2024 at 05:36:42PM +0000, Conor Dooley wrote:
> > > > On Fri, Jan 19, 2024 at 04:31:28PM -0500, Frank Li wrote:
> > > > > From: Ran Wang <ran.wang_1@nxp.com>
> > > > > 
> > > > > When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS
> > > > > (or its control signal) will turn on immediately on related Root Hub
> > > > > ports. Then the VBUS will be de-asserted for a little while during xhci
> > > > > reset (conducted by xhci driver) for a little while and back to normal.
> > > > > 
> > > > > This VBUS glitch might cause some USB devices emuration fail if kernel
> > > > > boot with them connected. One SW workaround which can fix this is to
> > > > > program all PORTSC[PP] to 0 to turn off VBUS immediately after setting
> > > > > host mode in DWC3 driver(per signal measurement result, it will be too
> > > > > late to do it in xhci-plat.c or xhci.c).
> > > > > 
> > > > > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > > > > Reviewed-by: Peter Chen <peter.chen@nxp.com>
> > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
> > > > >  1 file changed, 7 insertions(+)
> > > > > 
> > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > > > > index 203a1eb66691f..dbf272b76e0b5 100644
> > > > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > > > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > > > > @@ -273,6 +273,13 @@ properties:
> > > > >        with an external supply.
> > > > >      type: boolean
> > > > >  
> > > > > +  snps,host-vbus-glitches:
> > > > > +    description:
> > > > > +      When set, power off all Root Hub ports immediately after
> > > > > +      setting host mode to avoid vbus (negative) glitch happen in later
> > > > > +      xhci reset. And the vbus will back to 5V automatically when reset done.
> > 
> > nit: "will return to"
> > 
> > > > > +    type: boolean
> > > > 
> > > > Why do we want to have a property for this at all? The commit message
> > > > seems to describe a problem that's limited to specific configurations
> > > > and appears to be somethng the driver should do unconditionally.
> > > > 
> > > > Could you explain why this cannot be done unconditionally please?
> > > 
> > > It depends on board design, not all system vbus can be controller by root
> > > hub port. If it is always on, it will not trigger this issue.
> > 
> > Okay, that seems reasonable to have a property for. Can you add that
> > info to the commit message please?
> 
> But if vbus is always on, then applying the work-around would be a NOP, 
> right? So you could just apply this unconditionally.

Supposed yes. But I have not confidence to apply this unconditionaly.
There are too much difference SOC and dwc3 version. Not sure if it brokes
something. I think it should apply workround as less as possible.

Frank

> 
> Rob