Received-SPF: pass (google.com: domain of linux-kernel+bounces-45224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <42143388-4f2a-4b81-ac79-14851c6090e2@amd.com>
Date: Tue, 30 Jan 2024 13:54:11 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH Resend 7/8] tools/power x86_energy_perf_policy: rename
 some perf output strings for AMD processors
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 Borislav.Petkov@amd.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706592301.git.perry.yuan@amd.com>
 <5f70fe6c01a05dc355d6a0e47d32d5e24500ca82.1706592301.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <5f70fe6c01a05dc355d6a0e47d32d5e24500ca82.1706592301.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QlpVWHZyeFVvWGcyN3FSL21COWFiWXhxZUpJWk5VQXpjUTdHV3BXVVRoTWNZ?=
 =?utf-8?B?T0x3eDJsaFh1dm9Xdlp2MnltajI4SVpZS3VDNzVTYjBuaFhOYzRZK1lXMzNu?=
 =?utf-8?B?bmdsclA4Nkx1ajVmQWlkdEJoR0ZsWHArUGQ4NHFvSnNZcVZkYm5OTE9oRWV3?=
 =?utf-8?B?bTg5Z0JkdDlCemFJeStOZUhXc29vVCtuOStFRXMrd2VVVnVsYnhMTzZjRCtm?=
 =?utf-8?B?TkpSM3hETEVuNlVKSzVLSXp3RmFBZlBCaXoremlnV25YR2s2ZmxaWjhwdWRi?=
 =?utf-8?B?dHNlWjlvTU9DU3hkNnY4S0pQSHhkR083QXdUemVCelcvT0paVkxXT0pqRkFC?=
 =?utf-8?B?amVJbUtHT2s1M1Y4d013M0JFU2VoTERPS1dkamFNUU1Pd3E0WG42TVBhYnpt?=
 =?utf-8?B?SFNMRnJWY0xNR1dhUkZoTWJoQ08yQTFRRUZ5NGMrdC9uWnlHT2NFRGh2RG05?=
 =?utf-8?B?TjF2V2ViM1YxNEQrWkI4SXhKSUlLQjJmNkE0TzB5VXczcDlHTzhjbE9mZ21O?=
 =?utf-8?B?TjJsNkdlUUlXcUsxK2J4RnovOGNFZGxOV1g5OFR1WWVoUXRVSVhjWnZQRmt5?=
 =?utf-8?B?bjRVaUM5KzBvaFlub3RhYnRvdyttMlpmN1lsYXZoSVAwaWRTL2dMV3AxdEF1?=
 =?utf-8?B?dXU0MGdEdm9OemMrWjJydnNSMlVNdHVFNTFhOUpqRm1URlJ6NDFXUkExQVlI?=
 =?utf-8?B?dTJWVWNCN1R4NDZXY3BuVmJpd1Z1cERDalRRYzV2eGJoM2I2SlZ6U3lvRW5Z?=
 =?utf-8?B?K2VERFFlbWhROTJjbWtBc0s0bXV0ZWJBcFpvU1dJL01PTXdOM3loeHludFFJ?=
 =?utf-8?B?UmpyaFFSTkF4REdIWHFQQlE2MWNCQlZyYTRCRDZmdis5aDNWR0NLdldIemhU?=
 =?utf-8?B?M2hRbWFpQkZiZ0d0b3pzcWJ1RGswcDd3NFBXS0FXZ3pYTEwrNVVoRHdid1NS?=
 =?utf-8?B?VlhXTzc2M0lNc0lVS3JUK3FYc3NqOVFaMjl5a3lldlNqbTY1RzJ5R0ZlOXp0?=
 =?utf-8?B?VnRWWGFUUVJrRDVHNVE3NTFkZXg4aU5QUlNZQVdvT0V1c0RMc3BzUldQUDFW?=
 =?utf-8?B?V2ZaQ3BPOUtXTURRMmYwcXo4ak9GOTJTN1FxVXJOR2MzVzRzeTFqN25UYjVX?=
 =?utf-8?B?ZllGaTdPSEhjUmYxZnRmWlRLZzBvN3EwbzlSWWxaajBRQ3NFUER6OXNKYmZa?=
 =?utf-8?B?enhBTTN5Ky9DNDJnd255QjhaR2lnNEJBWi8yRFFzS1ZWUHZlTmVaTEVqajlv?=
 =?utf-8?B?VXg5TG90Tnl6aFZMYlpXYk9kN0pocUVHUHNRakhaU1hZVjdCWGhZT2t2Smhn?=
 =?utf-8?B?S1Z5UXF5WTZkT1R0T3B2TFBIWTFLUmVZUC95QjNPTXdGdmhYeWFRYVI2cHIz?=
 =?utf-8?B?c2NpRGJJU1ZlTnU1STJ4U0lJTUN4Y2sxSmpiRUF6YjJwUXgvM0JYNmFWU2k1?=
 =?utf-8?B?ZzRNTHV0V2szV1duYmZqR0hUTmxCRmQyZUx6YVRlZmpxZEJndldabG5jbjFE?=
 =?utf-8?B?NWs5bXZHNUtSeE1UTHFrd05tdEVMc01JV1RVNk1YZlo3NFcwTGNONndJdFhV?=
 =?utf-8?B?VHowalp5dUdyL1ZXcmFiQnlOZnJGV21mUjlnWUdjM1N0czBCQVdqRmVhNkhS?=
 =?utf-8?B?S01FbjZ1STRHbG00ZTd5ZC91ZGhqWTlZeUU2K1lKbTZzbXBHOTQvVkdBYVAx?=
 =?utf-8?B?TjVXd1FDdllFdlluVmRoZ3RDYk1jRlVNRnp0eS9YSFhrTGlSUUJsNHJuTll3?=
 =?utf-8?B?RUUvbVppTVpLWjM1T01HQkg4cmkzdTJBeFY5NjFkelR6Wml0MVlIbEM4bllm?=
 =?utf-8?B?WGxaUlpTQlFBN2hYemVyMmdraDhRS0s4VUhrRFc0ZDFlcXJiNVA3eVhUS0Vy?=
 =?utf-8?B?bHFHakV6a2c2dGtPRWhIekpxbnhjS2JhdHZoYlVCNVp2cVVNR2FJY09yOVVS?=
 =?utf-8?B?akcrYXF1ZDdHVkxZVHVHelZBL2k1T0NuNi80ZUpFZW41OE4vZi9KUldiMnBD?=
 =?utf-8?B?UkIyNHZtc1V6OVZFSks0SXN4ZnYyTk91SnRMWHFCQzdIbExRZXRsUVdxSTZT?=
 =?utf-8?B?d0sxdmtwcU9kWTRGZzVMcUNzcldGem1HWkNQTUIzWjIydzB5RDg1VzRIWlR4?=
 =?utf-8?Q?l6CYBGcw0Dlg4CjKIlQBi/R/P?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb84fb3-a7dd-4d35-fdbd-08dc21cd3bb8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:54:13.5977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: itMe5PQc2Nvk1y0Ua76gg4ITntWiNQdcctSymd9wD0iXVhf/eiiJfcjjx2bHGyqAxFQi8OIume3Vr5DG2ECKqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5086

On 1/29/2024 23:56, Perry Yuan wrote:
> rename some perf strings using same definition for AMD CPPC performance
> capabilities.

I'm not sure I get why these need to deviate.  The nomenclature is 
clearer for everyone this way isn't it?  So why not just make the same 
change for everyone (IE min->lowest, max->highest, des->desired)?

> 
> cpu0: [AMD HWP_REQ]: lowest 12 highest 166 desired 0 epp 128 window
> 0x131497d0 (80*10^7us) use_pkg 89
> 
> cpu1: [AMD HWP_REQ]: lowest 12 highest 166 desired 0 epp 128 window
> 0x131497d0 (80*10^7us) use_pkg 89
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   .../x86_energy_perf_policy.c                  | 23 ++++++++++++++-----
>   1 file changed, 17 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> index ada1aaabad8c..845cfedab06e 100644
> --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> @@ -864,10 +864,15 @@ void print_hwp_request(int cpu, struct msr_hwp_request *h, char *str)
>   
>   	if (str)
>   		printf("%s", str);
> +	if (genuine_intel)
> +		printf("HWP_REQ: min %d max %d des %d epp %d window 0x%x (%d*10^%dus) use_pkg %d\n",
> +			h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp,
> +			h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7, h->hwp_use_pkg);
> +	else if (authentic_amd)
> +		printf("[AMD HWP_REQ]: lowest %d highest %d desired %d epp %d window 0x%x (%d*10^%dus) use_pkg %d\n",
> +			h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp,
> +			h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7, h->hwp_use_pkg);
>   
> -	printf("HWP_REQ: min %d max %d des %d epp %d window 0x%x (%d*10^%dus) use_pkg %d\n",
> -		h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp,
> -		h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7, h->hwp_use_pkg);
>   }
>   void print_hwp_request_pkg(int pkg, struct msr_hwp_request *h, char *str)
>   {
> @@ -876,9 +881,15 @@ void print_hwp_request_pkg(int pkg, struct msr_hwp_request *h, char *str)
>   	if (str)
>   		printf("%s", str);
>   
> -	printf("HWP_REQ_PKG: min %d max %d des %d epp %d window 0x%x (%d*10^%dus)\n",
> -		h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp,
> -		h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7);
> +	if (genuine_intel) {
> +		printf("HWP_REQ_PKG: min %d max %d des %d epp %d window 0x%x (%d*10^%dus)\n",
> +			h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp,
> +			h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7);
> +	} else if (authentic_amd) {
> +		printf("AMD HWP_REQ_PKG: lowest %d highest %d desired %d epp %d window 0x%x (%d*10^%dus)\n",
> +			h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp,
> +			h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7);
> +	}
>   }
>   void read_hwp_request(int cpu, struct msr_hwp_request *hwp_req, unsigned int msr_offset)
>   {