Received-SPF: pass (google.com: domain of linux-kernel+bounces-45228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <9ed01851-f430-466b-a103-0ced8b4b4828@amd.com>
Date: Tue, 30 Jan 2024 13:54:56 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH Resend 6/8] tools/power x86_energy_perf_policy: remove the
 invalid feature options for AMD processors
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 Borislav.Petkov@amd.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706592301.git.perry.yuan@amd.com>
 <bc53456d6748a7fcb6a0c3ea3f136873fbf1d646.1706592301.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <bc53456d6748a7fcb6a0c3ea3f136873fbf1d646.1706592301.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YWo2MU5LNlZyQ2k4OVRkQklCSmpWL0QrTW1kS21Pc3k0WVdXYVd5akNUdy9r?=
 =?utf-8?B?ejZpajI4VVRwUG93ZGU3M0tmU05oQnloQ2xWTHlnRHJrd2sxdWR2QUd6NHpR?=
 =?utf-8?B?QzJ1REhTMXlNUkwvdktZVDNBRVg5cGZNNStHZlVhVzJBaWdKTkZMZkVraWNr?=
 =?utf-8?B?a3JkVC9WdkVsNFhwd2F5QVo3SVRYWVJZZk4yMitxZWxBczN5L0tCL3phYkFV?=
 =?utf-8?B?TEpjUldZVE9NNTBCVERnRkVpVnEvR3F1Z1NiRkpXU0pFRWdKd2E0UUREb1dP?=
 =?utf-8?B?bXNHa3lTRS9CcWw4RkUvQmZLZlQrRXVYdDlkUlFGaTFhR24veFplZENjUHIv?=
 =?utf-8?B?YUh5SnorK3FWYlZxcG5PVDNJWENvZVlnTm1jc01uL0djKzBxZzJjV3dlK0dJ?=
 =?utf-8?B?dlhBaWhZNVZLdktZQ1FOYzFaMU8wVVhHR3piY2pBTXEvVVU1b1h6NW1NRXNt?=
 =?utf-8?B?Yk1SY3VYdVcvK2lWbFhYV2w5SzA3QnFNUGFKV0cvL3p4OFNpVkNlaEtFTGN3?=
 =?utf-8?B?aElwMmNReS9oZ0hNSStjYmxSd2ZGcGVOK2hHZm1selRnMTFHeEs0emxMdURU?=
 =?utf-8?B?Lysraml0TXV2RXJ6dGllczNpZHhhbEZJL1VBcVdCZzZXNE9sbzFqR0cyVm5j?=
 =?utf-8?B?OHMrbUUvenN6d2o3VHFtSkd1ak1OVzUyQkdiSTlDM21jd2luSFhWc3NXT1E4?=
 =?utf-8?B?MmNGdm9lKzZmNzJDQ0FXU1BBQmErQ2VlMU4xdzNoTXB2ZUJUZE9ZMjBseFNU?=
 =?utf-8?B?eldvWmF2T3duQmdMREhCTHJUTkZuVUt0UjFXNDdMYUJ3NXpQRUdmRnBOeGpj?=
 =?utf-8?B?UkVFR013SHF3d1NWM1NTZW1pU0ZaZWtIOUFsTXhpeHNpQzBiejBXOXZuK3JT?=
 =?utf-8?B?SktZd3V6SWNkM1FVdEVHSkdVY3oxcllSUHlPSjQ1WG91VFh5eDU2L0ZSZmVm?=
 =?utf-8?B?RUlVMU1tSVZHaHhSMkZWUklDWXJPZ01yUTVpcDd3Q2NCQUpXcE8wMWVKSm9O?=
 =?utf-8?B?S2ZEZzlicU9FQzluMS9haHcyM1pXWkF5akVQM3B1Z3QzOWhoSlRmUk8xTGNs?=
 =?utf-8?B?VjNRQkxQTzEvMW9ybWJoQm9IVGVjRUpVOHRIK2huRWdDTW9Ta21WUmhlTTl4?=
 =?utf-8?B?Wlo5NmM5ckoxRnZXb210LzNqYW5laUxmNTJyd1BuakcrNXM2NFhiQTVZbG9D?=
 =?utf-8?B?UFlFcEM1djhrb2thMy9PTGxzU0V3ZDFjVnQzUTlmQ29Pemp4ZXIxelhDVmwy?=
 =?utf-8?B?QnFEYitKVWd1MnUwbkFaMldtSVYxV2dGWlF6MW1xRWd5NktGUXZFZDBQQVR3?=
 =?utf-8?B?N0FFVkFwaEtnckxEYjNzcTMrZkRMenFqamREc00yTGZ3ZG1UcGxONXRBWlBG?=
 =?utf-8?B?Tlp3TldyT1ZvVWVqZG1FQTJBd0Z2bWN5YUtNQnFaY3dlamxpK0w3SEhYTXpo?=
 =?utf-8?B?YkFBV3NkTmsyaVdyN240M1hFdU1yUllOVE9xUzRDOVg3OXZHbXRaalpCNlAx?=
 =?utf-8?B?V3ZQRWUyVkN0RXBUMm1BSzQ0cVdFTktCb1NyM3ZLeWQ3V2NsSEY0cDhSeWlN?=
 =?utf-8?B?VEFzRkh0OExOZWdxR2x1TDB6UUZNRUhzMm5IRnpTbU13S2dKbXh3MHpyOERZ?=
 =?utf-8?B?UUd5WTFaSnJtMU9EZGpUT0YxRVNVSWRQbzlPY2poN2taTi8wUzl1RHNMY0Zl?=
 =?utf-8?B?c2ppVTlURzZFTFBNa2dQKzZhTnRqd0dpajU3TVkrYTF0d3JRQ2UyL2doS21l?=
 =?utf-8?B?aFAvTS9lemdoMzRLMnhuQTIwMTdGV2dyTXpjUUhLRDZRbzNObjVTMGdqZjR6?=
 =?utf-8?B?NG5OeFc4Y3RLRTZ2ak9wZGgyRkNuVVVma3A5bjFGMnVkWG1XRFNFTUtwYXE2?=
 =?utf-8?B?VGtMakIzYVF0cy9xWDh2a1VXVmFlekpsMXo0bzdrVzNVQk9oWFhUekJTdU01?=
 =?utf-8?B?eVJiZkF2VnRTYTdWNGY2Y2RFaHlUdlpzMnp6VHcyUHMzNmRpaE9JTWtJSWxq?=
 =?utf-8?B?VGZ4ZzlzUjZ5ZDFKcUo0cDFLSnVRU0ZsQTRJK3FFYUxYcXhwTHhWZmlpdlJq?=
 =?utf-8?B?WE5ISStRelRQZnFuNmVhN3UvcDJDb2JVRXE0RDU4NC9JWW9PYit6U2pQOW5p?=
 =?utf-8?Q?FaNlddALg5R5zMxv2wtllT718?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 354a455a-546c-4aad-39ed-08dc21cd55ed
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:54:57.4953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mE8ndXM5hGY6yQ/27uEqup/QD1twIA6nAD+oStRuKwPoQoIOsqi2pP8DUjJ6FGSJsfGClXJtnSgkfLUStZNO2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7172

On 1/29/2024 23:56, Perry Yuan wrote:
> EPB feature is not supported by AMD CPU, remove the unsupported options
> to advoid confusion for the failure result when using the parameters.
> 
> Here is the new help output with  below command.
> $ sudo ./x86_energy_perf_policy -h
> 
> ./x86_energy_perf_policy [options] [scope][field value]
> scope: --cpu cpu-list [--hwp-use-pkg #] | --pkg pkg-list
> field: --all | --hwp-epp | --hwp-min | --hwp-max | --hwp-desired
> other: --hwp-enable | --turbo-enable (0 | 1) | --help | --force
> value: ( # | "normal" | "performance" | "balance-performance" |
> "balance-power"| "power")
> --hwp-window usec
> ./x86_energy_perf_policy: [-c cpu] [-v] (-r | policy-value )
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   .../x86_energy_perf_policy.c                      | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> index 7bc668d22728..ada1aaabad8c 100644
> --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> @@ -105,13 +105,18 @@ void usage(void)
>   {
>   	fprintf(stderr, "%s [options] [scope][field value]\n", progname);
>   	fprintf(stderr, "scope: --cpu cpu-list [--hwp-use-pkg #] | --pkg pkg-list\n");
> -	fprintf(stderr, "field: --all | --epb | --hwp-epp | --hwp-min | --hwp-max | --hwp-desired\n");
> +
> +	if (genuine_intel)
> +		fprintf(stderr, "field: --all | --epb | --hwp-epp | --hwp-min | --hwp-max | --hwp-desired\n");
> +	else if (authentic_amd)
> +		fprintf(stderr, "field: --all | --hwp-epp | --hwp-min | --hwp-max | --hwp-desired\n");
> +
>   	fprintf(stderr, "other: --hwp-enable | --turbo-enable (0 | 1) | --help | --force\n");
>   	fprintf(stderr,
>   		"value: ( # | \"normal\" | \"performance\" | \"balance-performance\" | \"balance-power\"| \"power\")\n");
>   	fprintf(stderr, "--hwp-window usec\n");
> -
> -	fprintf(stderr, "Specify only Energy Performance BIAS (legacy usage):\n");
> +	if (genuine_intel)
> +		fprintf(stderr, "Specify only Energy Performance BIAS (legacy usage):\n");
>   	fprintf(stderr, "%s: [-c cpu] [-v] (-r | policy-value )\n", progname);
>   
>   	exit(1);
> @@ -1309,7 +1314,7 @@ int update_cpu_msrs(int cpu)
>   	unsigned long long msr;
>   	int epb;
>   
> -	if (update_epb) {
> +	if (update_epb && genuine_intel) {
>   		epb = get_epb(cpu);
>   		set_epb(cpu, new_epb);
>   
> @@ -1318,7 +1323,7 @@ int update_cpu_msrs(int cpu)
>   				cpu, epb, (unsigned int) new_epb);
>   	}
>   
> -	if (update_turbo) {
> +	if (update_turbo && genuine_intel) {
>   		int turbo_is_present_and_disabled;
>   
>   		intel_get_msr(cpu, MSR_IA32_MISC_ENABLE, &msr);