Received-SPF: pass (google.com: domain of linux-kernel+bounces-45232-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d57d54d4-bbf6-4b54-ace9-61ecc8ce7c06@amd.com>
Date: Tue, 30 Jan 2024 13:56:37 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH Resend 4/8] tools/power x86_energy_perf_policy: rename
 get_cpuid_or_exit() with intel prefix
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 Borislav.Petkov@amd.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706592301.git.perry.yuan@amd.com>
 <3f9212ab790ebeaa36f7a3fedc4fc533f6c75559.1706592301.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <3f9212ab790ebeaa36f7a3fedc4fc533f6c75559.1706592301.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K1V4RGtjdFVxVkZBbW9zTldEYlJIQjdHYkZzVmErR1dEczl5b2paSUI2RmRj?=
 =?utf-8?B?SWJDMm5wZnB5OVlNb094cHRqRnRCRHRwZEhvSm9iUG0wRjA1QjhOaUVDMkpP?=
 =?utf-8?B?TWxzN1cxcnJQYVhOOUY0WlBnYkpVSDgvUStpczBuZjlFS3NZNG5ydjQ1V3cx?=
 =?utf-8?B?UEJ0SHV1TVBaeVdDSVkyNGF1YlA1K0c1MmF0S3dVUFFlSVBLeVhYSWl1ZkZo?=
 =?utf-8?B?TjVDRDJENDV3YnYxbEw0eXQ3NFNiYTZzQmZBK0VnSExJS0lNdHpFaFpPYjYz?=
 =?utf-8?B?QVFwYUpBYU9wR3BFZjZSNTBBU3p3Ylc0aUUweVA2aTVKbVYzdWhrWXdueVZG?=
 =?utf-8?B?STBzQ2hkVWdwb05yWUFXU1loVDZKd0lQdWpaa2lJeVJjd1VxNTJLNWp4OVhQ?=
 =?utf-8?B?TkduSFI2bWdvQnZ0M05IUVpKSFRPR0lhRG9uWXFwK2FkTjZnS0FjaTl3d3Ri?=
 =?utf-8?B?OE9saWxyYWhyNk1WUUl2SFB5ZkNzbVh3RlZhRzNwWGtjc3VweXVRU0pJWk93?=
 =?utf-8?B?bmc3TWNJK3piNU0rWGpXZkxCSUdMMkJJNUhwZ0t0dmQxeVBaSUk5UG85SVY4?=
 =?utf-8?B?UjZOVEM0RlZQaXYycFl1ZEt6Mi9ScWxoemJTbmNRSmxuR3lZYjF1Mm9wdmlz?=
 =?utf-8?B?QllSVlk4VW9PeE9jelU2eklEQ2lmNjZwZEVMTnJkTVBlS3RkdGpQREYwa2dS?=
 =?utf-8?B?cFh1UUhxZkQzZEFpbmNwbEJEUWJYdng2UGlicDFadWJ3YmllVXZBNGwxcDc0?=
 =?utf-8?B?WC9xcDlLdThpRkxCREFIbkdGZ1BKR2VEWW5VQWNVR2Q2ZEVXb1F2aVVDUEpp?=
 =?utf-8?B?OEpRbzFCclZ4M2FtSkNHM2VjM2RFd1M0cTZkak45NjJnUzdxSjBCcGhiSkhM?=
 =?utf-8?B?SlBkam5wZlh3ek5CRnlZMno2bEVaa0FXRXZwVHJkLzFNMXlvV2tERFdZQm1a?=
 =?utf-8?B?VmtRZlo2N21JYVZnK05iTzE3R1pOd08vdFlLZERUMS9IVHYrYmNtVTd1TENY?=
 =?utf-8?B?VzNwUU9kL09uL3ZSWTB6K1RnMlVRQlEwOEcreTVSUXdBWHBCbkh1Rm9LeFhr?=
 =?utf-8?B?Qmk3VHpZMGdoTFo5a3c3cUVpbHYyS200UGJVMXo4RDVTNUVWbVFvRFV1RU0v?=
 =?utf-8?B?Y3JsOGJYRkliazhHNHVqcTBjVm5uUE1mNDBaUEVMYy81TVYwOVQ0Q1lrekI3?=
 =?utf-8?B?T2tXc2tJS3pWMXhrZUM5ek90Zmp2cW1JRG53SkVkNjlaQWpqcGI0S1IvMHBY?=
 =?utf-8?B?YXVVYkx0Q0pDTENoa3dndlJvUVZGSDRKSS9QTWNzVHVzOXAxRG13SEZwaWFh?=
 =?utf-8?B?ZXB0d2ZyT1pkd1ZJbTZsN3JnVW9EbFVtVHljbXd4RG9ybTdZYy92Mk5YR2F2?=
 =?utf-8?B?TFhpV25qYTVRRVlWRVQxUkQ2RElGbnkvTzhVL3pFd2syR2JDZW5UTmVjVVlv?=
 =?utf-8?B?UjBKSXNFWjZPOVYxV1hjTXZobUg2QW8yeTIyY0pna2F0c0VVSThoYURHYVoz?=
 =?utf-8?B?NkJKdVFoOEFrNm9VcEc0K0NCby9JbU81UFV2M3BpL1hGQXkrcGU5S29hbWRH?=
 =?utf-8?B?ZGFreksxRDVLR0tGS2VaZml4bU5kQ0tGMGNXalM1R1JSS2FnSlp0RWFKTEdT?=
 =?utf-8?B?SnU3NGNMTFp6di9nYWprTG5CdHNWOTJaSUkvb2xVeDQrZDAwM0xZTDMrOEtM?=
 =?utf-8?B?ZXZqYXdLSlN1Z1paQUFOZktneU1XSjlZOHF1eU1oVkE2dmhpWFMybzJ0Z3Rn?=
 =?utf-8?B?TzkvUVNBRHhQNkpEbjBJdUJDeStWN0pwRGt1MU5pcVRpWHJkalNZdDhEcS85?=
 =?utf-8?B?RmQ1REd0WlVCRUJPb3JIdHY4R3c3VUVVWlpTRzZndUUwVFBsbVRCRzBLd1c3?=
 =?utf-8?B?dUhVbE03SVppNmdpL2pJeWZTZ3Q3VGFEMXJ1MzlNRkJFbGRNY3U4SDVhd1RE?=
 =?utf-8?B?dy91OWhkbnhtQWUyOUhuZTBWZ3hDdDgzazErb2F4NGVDZnljMkZySmNtZmNs?=
 =?utf-8?B?bkJHWnFCVnY3RzhXYUZCcG5mVG5xb3Z6YjlFVVRrbmNWeUJjK2xjdno1WXYz?=
 =?utf-8?B?VlVNSFB1MUp4SWF4UkkxcENPdkI2SjBmZEZuMm9xNU5mTVhIQ1lIdjBEMFAy?=
 =?utf-8?Q?YO2/Q1Z1gDWuyS/RyAG4XSKKL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bac3578a-fca3-4c2e-1ab3-08dc21cd91fc
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:56:38.2469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5Mw9BSKSBX98d/AuPp3LjeI2HBCxlrwlDmhyG4B2ZSUP9zqc7thaVEozSMBw1BehGKi3ENhfhdYnfClSPbr34A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8213

On 1/29/2024 23:56, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> Rename the get_cpuid_or_exit() function with intel string prefix, that
> will help to know the function are used on Intel processors.
> 
> No functional impact.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> Suggested-by: Fontenot Nathan <Nathan.Fontenot@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   .../x86_energy_perf_policy/x86_energy_perf_policy.c  | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> index 3f09c12f24fa..a08403ab219a 100644
> --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> @@ -1515,7 +1515,7 @@ void probe_dev_msr(void)
>   			err(-5, "no /dev/cpu/0/msr, Try \"# modprobe msr\" ");
>   }
>   
> -static void get_cpuid_or_exit(unsigned int leaf,
> +static void intel_get_cpuid_or_exit(unsigned int leaf,
>   			     unsigned int *eax, unsigned int *ebx,
>   			     unsigned int *ecx, unsigned int *edx)
>   {
> @@ -1552,7 +1552,7 @@ void early_cpuid(void)
>   		authentic_amd = 1;
>   
>   	if (genuine_intel) {
> -		get_cpuid_or_exit(1, &fms, &ebx, &ecx, &edx);
> +		intel_get_cpuid_or_exit(1, &fms, &ebx, &ecx, &edx);
>   		family = (fms >> 8) & 0xf;
>   		model = (fms >> 4) & 0xf;
>   		if (family == 6 || family == 0xf)
> @@ -1566,7 +1566,7 @@ void early_cpuid(void)
>   			bdx_highest_ratio = msr & 0xFF;
>   		}
>   
> -		get_cpuid_or_exit(0x6, &eax, &ebx, &ecx, &edx);
> +		intel_get_cpuid_or_exit(0x6, &eax, &ebx, &ecx, &edx);
>   		turbo_is_enabled = (eax >> 1) & 1;
>   		has_hwp = (eax >> 7) & 1;
>   		has_epb = (ecx >> 3) & 1;
> @@ -1591,7 +1591,7 @@ void parse_cpuid(void)
>   
>   	eax = ebx = ecx = edx = 0;
>   
> -	get_cpuid_or_exit(0, &max_level, &ebx, &ecx, &edx);
> +	intel_get_cpuid_or_exit(0, &max_level, &ebx, &ecx, &edx);
>   
>   	if (ebx == 0x756e6547 && edx == 0x49656e69 && ecx == 0x6c65746e)
>   		genuine_intel = 1;
> @@ -1602,7 +1602,7 @@ void parse_cpuid(void)
>   		fprintf(stderr, "CPUID(0): %.4s%.4s%.4s ",
>   			(char *)&ebx, (char *)&edx, (char *)&ecx);
>   
> -	get_cpuid_or_exit(1, &fms, &ebx, &ecx, &edx);
> +	intel_get_cpuid_or_exit(1, &fms, &ebx, &ecx, &edx);
>   	family = (fms >> 8) & 0xf;
>   	model = (fms >> 4) & 0xf;
>   	stepping = fms & 0xf;
> @@ -1632,7 +1632,7 @@ void parse_cpuid(void)
>   		errx(1, "CPUID: no MSR");
>   
>   	if (genuine_intel) {
> -		get_cpuid_or_exit(0x6, &eax, &ebx, &ecx, &edx);
> +		intel_get_cpuid_or_exit(0x6, &eax, &ebx, &ecx, &edx);
>   		/* turbo_is_enabled already set */
>   		/* has_hwp already set */
>   		has_hwp_notify = eax & (1 << 8);