Received-SPF: pass (google.com: domain of linux-kernel+bounces-45230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <052797eb-bc59-462f-a918-460913c302ec@amd.com>
Date: Tue, 30 Jan 2024 13:55:55 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH Resend 8/8] tools/power x86_energy_perf_policy: change
 intel msr functions to be static
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 Borislav.Petkov@amd.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706592301.git.perry.yuan@amd.com>
 <6905c6ca13c5cbb513f2bf6c2a937dd228e3fd57.1706592301.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <6905c6ca13c5cbb513f2bf6c2a937dd228e3fd57.1706592301.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cU9YenFzMERyZWlJZnUzSCtORnhUWTAydDFVdXc4aHJYTzhIbGJjL3A5TWFp?=
 =?utf-8?B?S012UGxtbGx3dEdrbU5YVkUxekF2RDdZV2ZPNkNQNUpma1ZtdWxBZnpaNEYr?=
 =?utf-8?B?RU1rTXFSWmFROWx2K2libS9DYTNOdzU1VG54WXRmaC9mL2tlV2JBU2s5NjNk?=
 =?utf-8?B?RWlQOWthc3VnSjRraG5HL0NlN0F4UUs3M1dueFMweWU3OXRqQjdaUS9DelNC?=
 =?utf-8?B?Q1cvdDNYNzlWMkJlNXhEa0krVmhEZ2ZoSW9CNUhMSk5FektjWTBNQUhWcFFj?=
 =?utf-8?B?aFVDb1ZBRGs0N1BXTS9uT29DK3VLWVFRa0tremZObkJUOWZrSnJqK1hCWUd6?=
 =?utf-8?B?czhFeUFVZGFFYlhESzlMOFRqYm94c2l3YTUyTHlIZEhTc0lmRWJVNUJONy93?=
 =?utf-8?B?Y29waVREK3YyUlB0Z3dncmVZNkNhVm5XdXVxNUFOUlBybi9BV1NQUStYQ3hj?=
 =?utf-8?B?NzZ0aklpbmUxbm9mdTZZeUh4S3hhTDE2N1ZVMk9YMmhHcGMwL21hUHk2SmV2?=
 =?utf-8?B?eTBUY0x1VlBvbm5CMDBONTgvR05DMnhPNmlhNENCQnFiQ09LaTFiZzB6RjR0?=
 =?utf-8?B?RExNTXZBQVV3d04zWWlpbDBKZFNKOG1UazJra0NUbi9UNXgxWEJoRHhUR0ZN?=
 =?utf-8?B?Vk1QWVhrWHJha0dDa3JpR2lqR3MrOFVyaGdWSVZJUStSbXBKZFJlSkNsS01w?=
 =?utf-8?B?U0l2dnR6SWtkNVl3ODJwYW1MV3E1azdSQkJNdXA3bzhrbVdQTzdMVG9tVExV?=
 =?utf-8?B?ZzlnQ3M2WWtqSWxkaXQ0c2lwYlZwYkFGdzVlM2owQmtSV1lzbzhCNHV4T3BG?=
 =?utf-8?B?MzBib05LeDlOUUlHVkJZem5DcXM3TFNkVFRxUU9vaW1IT0QrWWVRU3VHbEFT?=
 =?utf-8?B?clNlbmQ1TnhNSnl3QWhjaVFua0xDcUdhL0FoN3FXbFJIbzloYXBJRDArMDZJ?=
 =?utf-8?B?M0dwUndpSUE5aUNseVRwZk54OWNDc1ltTG03WCtuenRGcFBsTFg3RUJMZ1dC?=
 =?utf-8?B?ai8rVW5sb0x6WWtWNWs0VTNCOU9COXlpZFlSaU9BREkzUzNSaWJqeVpJOGEz?=
 =?utf-8?B?cUdvcWJmWW5taUV5amg1UEhSVWxYSXpOL29tM0xmVDM2L0hGU1FrOXNwYi9X?=
 =?utf-8?B?ekFWUWtJdmpjTDdtTVNFR1B4RkxZM1RRaVhBb29GMXdHWERkQ25GbmVTc0Ew?=
 =?utf-8?B?VWExUmhHd3BXRnl6UEIzcnlSYkJzU0N5azZzMXlycVp6RGtkMUdtRjduTEQ4?=
 =?utf-8?B?QWpjQXdzU1V2enY2VENnMUlLNzY4WnVLZ3NIeWQ3Z25pcU8vTC94UjJtOXBE?=
 =?utf-8?B?VFl4b0lRSTRDa1I4ZXdMNzY1VEpNTnJ4RWtaOURTd1plUVduREVKYWJoUGs2?=
 =?utf-8?B?ai9lbUgrS2xTN3lDeEFIQm80Tko2MDhtWmNoRDd2UWlZSnNhOWhFUit6UmxM?=
 =?utf-8?B?OHJVa05iYjJRQ0cra3NGYzFta3M2Y0k4ZlNnRk9NUmJHaXdIell2bVU4ckpU?=
 =?utf-8?B?TnJBMEVDdlVob3NpQWpwYU05bjJYWTY0RHpGNzBhUnU1NWRoZ3AvS3IxbXdp?=
 =?utf-8?B?Ry81VWVkZ0F3bDZBZEgzaUtrbUZxOEx5dEZUSVZmaGZxMzBucGFaeHhBQW9S?=
 =?utf-8?B?K01oL243bVVEOEp1TTE0RmhkRXZreUFISmhuSlhZU3EvZmY0VDFaaTVOZito?=
 =?utf-8?B?ZU9EOXhpVzNKK1RObENuK0hNbDNaQ3NrNzBvTVczdHYrL0NFNnJYbk1lOWtw?=
 =?utf-8?B?VXZWZDdGMTQxbTNVVWdWaWNLK2d1bkZ0ekNZUjM5dFNXL2Nwd3NGR2doamZQ?=
 =?utf-8?B?aDMwSnlHTGZnLzhYeVNYS1lhb3VMNjFUdFM4NkMydnl1d1JBbU1pdWNkTHg1?=
 =?utf-8?B?UkxObHgxTkJPc09sa0tmSXI4L2lTQ09ScVZjOVZnMlhoY0gzekR0U0Q3RVRS?=
 =?utf-8?B?Y3lMNktiWHQvVllMTzluMUlvSitjdENCSU45aXNqN055V0lhT0xsVnlLQVlN?=
 =?utf-8?B?bGk1ZEJjKzlROXpXd3hXcnRqQlMvUnRVM1ltbW5rQW9IaGNsT1huaXFaSDh0?=
 =?utf-8?B?TnBQUHlWNzFhOVIxZUFUL29FcFBra1I5NEZvSkRSaG94MXFaMmc4RkNHU1du?=
 =?utf-8?Q?6vALbqoJg7Bn4ujlkC7RMIbrM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3fdf6f8-4937-4fa2-dca9-08dc21cd78d6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:55:56.0460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xJA/Fnal6oACrk/zsr68MrufnDwZrerY23Bxrg6O+n3Nx8ztyLbiMrbV5qyIh0egvIDKq95PUqZ6kozdSgkc1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7709

On 1/29/2024 23:56, Perry Yuan wrote:
> change the intel_get_msr and intel_put_msr functions to be static.

Was this wrong from the beginning, or is it because of changes in your 
series?  You already have the "what" in the title.  I think the "why" 
should be described here.

> 
> No functional change intended.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   .../power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> index 845cfedab06e..a5f2f96fa383 100644
> --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> @@ -686,7 +686,7 @@ void err_on_hypervisor(void)
>   		    "not supported on this virtual machine");
>   }
>   
> -int intel_get_msr(int cpu, int offset, unsigned long long *msr)
> +static int intel_get_msr(int cpu, int offset, unsigned long long *msr)
>   {
>   	int retval;
>   	char pathname[32];
> @@ -710,7 +710,7 @@ int intel_get_msr(int cpu, int offset, unsigned long long *msr)
>   	return 0;
>   }
>   
> -int intel_put_msr(int cpu, int offset, unsigned long long new_msr)
> +static int intel_put_msr(int cpu, int offset, unsigned long long new_msr)
>   {
>   	char pathname[32];
>   	int retval;