Received-SPF: pass (google.com: domain of linux-kernel+bounces-45236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <916951f2-46d6-48a4-b29f-6a5084e1f176@amd.com>
Date: Tue, 30 Jan 2024 13:59:16 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] rust: prelude: add bit function
Content-Language: en-US
To: Christina Quast <contact@christina-quast.de>,
 Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>,
 Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng
 <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
 =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
 Benno Lossin <benno.lossin@proton.me>,
 Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240130-rust-bit-v1-1-ed2ed6389a58@christina-quast.de>
From: Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <20240130-rust-bit-v1-1-ed2ed6389a58@christina-quast.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c3lObDRRcmREU2RlaXkxN0x3TzdSWm9YT3kxSVRnZk5rV2ZKQmRZdjhJb1Vk?=
 =?utf-8?B?aS93RHZGQnVRUlhKSFp3Ym5NVEYwcFp0c1dURGxJMXFKUUovRDNPY0pQTXNH?=
 =?utf-8?B?ckgyWndKZHg2Rm9qeWc5MXJKWi8xcmwrUFhpdWcyUlY2cVpZdEJUTUVhUmNF?=
 =?utf-8?B?dVJoRXg3OVRkTmcySUhOT3ZUTFdDZ3BMSkZpS0piYlQwYWRKQStmZ09IZ0F5?=
 =?utf-8?B?Zm95UUYrbDJSSDFZbk8rQ3ZuY2pUdnZGd3Y0d0pXa2Q3enRNUXdxNm5HWjVV?=
 =?utf-8?B?Y1FFQzlhNzZPS3RGOC92NlNHVXo3cm5YUGdVbU9mdXlDc0o0ZDVGWll1VW9k?=
 =?utf-8?B?cmFvUzhNNWg5aXM5T3h3NlZmWlJvSlNxL3R0LzQwSXdRUGJFR0FFVDloY2lt?=
 =?utf-8?B?TDUxVXQ3S055WVRGTHd1UTZnTFJrMWhMVXFnR3kvYnY0eEsxWlRaVEo2bXFR?=
 =?utf-8?B?RlBZYjFtb0puRWJMeWlBaFcrNVdKajZjcXkxdDYvWUZwVkIyWTNjNFdtWGFI?=
 =?utf-8?B?bmZ2TXkyZkRFNncwSk5TMWtmRWEvL25yZHVKczJTd1JFa2RCRjFoTkJVcUs0?=
 =?utf-8?B?WDhCb2JLL3FvSG9aN2N0QndpY0hNK0hQZE5SMmpJcHlyVUx5Zlc5YUhwQXdK?=
 =?utf-8?B?ZTRpT3AvRUdNUDdEeVlISVdHbU82YzBzS3lVTWtKbzBYVnozTnYwT0pSTW1D?=
 =?utf-8?B?SVFmWUdiNEYrMExxMlVEUUhzL082VjdCOWtIWFUyaC9yU1hCejJLeklGdnlK?=
 =?utf-8?B?d0tSU1FscWlCNVowcEh1cnB0ZFdFV3FZcGNrMVhpM1NYM1ZDYVRDdS84enRS?=
 =?utf-8?B?QkJvdDFpMXpUdnFmNCtzbEVNNWlhWlJzemtSWTYwdEFSZG93cEdzVzJGYmhW?=
 =?utf-8?B?ZzVUc3owaVJZRnl4TkZNcVhiWmZNNHBMYW05eEdFUDBtd1NkckM5aGxBWGdD?=
 =?utf-8?B?RkNFenh5TmVNZjVQWVB0WEFsYmhUWTQ2OEFjcFlwY01aMUZzYUF0SEM4d1Jl?=
 =?utf-8?B?bzJBdFA2SElia0FwbHpnNC8wK215VjcwV2hQVkNDV3pJcGxEOTFnNlNmY3VK?=
 =?utf-8?B?ejdic0loWWRKdWE0dDkrYlJ5djZYRlRwL0ZUKzhqWkcrVEYxVDg2MTFrZVZO?=
 =?utf-8?B?R3c4SWJ0ZlJGSEtxNmw1RlF3ekw1RUZkT0pyQ3BTZmdkSXV4b0FwSDdKeXE0?=
 =?utf-8?B?WFZoOFZJNDRJb1RsS0g0blNhM3lYQmVzWm4rVmZDWm5zR3VmNlR6cGRFb3ow?=
 =?utf-8?B?bVFsMEtYdlNqR1BaWEh1YkJ4TlBhQWozZ2dMVHN4N0hzbVFyQ0duRW1iczJl?=
 =?utf-8?B?QlhoU3pKbTRSMjFOdTZCdnd1Vy8rNG9mQWhBek1zUzA0cjRjd1lwVUZOem5I?=
 =?utf-8?B?YXhxc0JJblQwT1pQdFZ1dFdaU1RNV1ZWUGFuUSt1WWhVc0pHWktoZ3FicUZl?=
 =?utf-8?B?R2svRDlrVnJJTTBnenQ4bDBLSGlVeENyVktFOTVoYmwxZGtybjFKekhCLzg3?=
 =?utf-8?B?MWMrQ1dUMGZjVEJnbkNWWTdrOC9jUkdTQnlzbFNJYmM5RnRvYThxNzJDdTAy?=
 =?utf-8?B?RFJ0Q1pwSTF0R0ozNnR5NTFLa3hnbTEraCtuRGw0bDJrejhXSFhyejlNVmZT?=
 =?utf-8?B?VVdvZnA5LzZvSFRCZkJpeEVBWktBTk1ad2xnNXEzYm1xRVVkeWluVVNiYzNk?=
 =?utf-8?B?VkVYU3dlYzMxU1dFLy9JN0huUVVKRENZTjh0cy8wQzZhRzdyZG9lZUFkYjll?=
 =?utf-8?B?UFR2K01LTkQyeE56MGNPaWFNZjhzQlFlTkQ4SU5tY09UMTczMHR5RlQrZ2NU?=
 =?utf-8?B?ZjdJYnJBcFRiNzlVc0l5dVNRQXRSWVZnNHpYMzNZK25PSHAzd3VQb3Q5aGlQ?=
 =?utf-8?B?RHFuTGlrTEJDb0Nkdjludkc5UytpcysvWnpnbTFkdFhKWksraXVOWnI3QUpX?=
 =?utf-8?B?RjBwdXF3MjBTbE5wT0MxRnFZL0Z2SzRZQktQK2pwVjkvOTR1cnVrbko2RUlj?=
 =?utf-8?B?cmVhTU5GcXBXNXp0SUVZVUw3TUJYb0pZRDdLQnRvVlBXUnF6U2JpdU1kM1RP?=
 =?utf-8?B?MldsSGhlaFZvZDZpc2hpaTZ2ZFlZN3BTYTNJNjRoWURQQW4zS1BnSkRzcE85?=
 =?utf-8?Q?yxCPvCOkzxylR5dOxyoGjhlCF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17b8c206-ff3b-42d0-854b-08dc21cdf208
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 19:59:19.3772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 31s4r+m3HyrX+7vgg6S58cQaZCW4fpg/ilvomx3ZG/TpIDsJ/4KJWkaKtrTykoISk1eXjwamiypWNS0uufOrqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4138

On 1/30/24 13:47, Christina Quast wrote:
> In order to create masks easily, the define BIT() is used in C code.
> This commit adds the same functionality to the rust kernel.
> 
> To use it, include the following into your rust file:
> use kernel::prelude::bit
> 
> Signed-off-by: Christina Quast <contact@christina-quast.de>

Reviewed-by: Carlos Bilbao <carlos.bilbao@amd.com>

> ---
> This patch is needed for further patches porting the rockchip phy
> driver to rust.
> ---
>   rust/kernel/prelude.rs | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
> index ae21600970b3..16e483de2f27 100644
> --- a/rust/kernel/prelude.rs
> +++ b/rust/kernel/prelude.rs
> @@ -38,3 +38,19 @@
>   pub use super::init::{InPlaceInit, Init, PinInit};
>   
>   pub use super::current;
> +
> +/// Returns a `u32` number that has only the `n`th bit set.
> +///
> +/// # Arguments
> +///
> +/// * `n` - A `u32` that specifies the bit position (zero-based index)
> +///
> +/// # Example
> +///
> +/// ```
> +/// let b = bit(2);
> +/// assert_eq!(b, 4);
> +#[inline]
> +pub const fn bit(n: u32) -> u32 {
> +    1 << n
> +}
> 
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240130-rust-bit-99dd6d3a0536
> 
> Best regards,