Received-SPF: pass (google.com: domain of linux-kernel+bounces-45244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e78d535c-172a-42d2-a946-d648f6b7259e@intel.com>
Date: Tue, 30 Jan 2024 21:07:37 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] KVM: x86: nSVM/nVMX: Fix handling triple fault on RSM
 instruction
To: Yunhong Jiang <yunhong.jiang@linux.intel.com>
CC: <seanjc@google.com>, <pbonzini@redhat.com>, <mlevitsk@redhat.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <dedekind1@gmail.com>,
	<yuan.yao@intel.com>, Zheyu Ma <zheyuma97@gmail.com>
References: <20240123001555.4168188-1-michal.wilczynski@intel.com>
 <20240125005710.GA8443@yjiang5-mobl.amr.corp.intel.com>
Content-Language: en-US
From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <20240125005710.GA8443@yjiang5-mobl.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1hGNEJOczIwd212dDJnVzdyOVU2SG5WNkVGR0p3d1FUTUV3Z3ZGUTYxMHRl?=
 =?utf-8?B?ZGxuZzY3YzQ0SUdvaElTcE1DM0lmbFljRHcxYzU1U2RRYzdLUzBMMmFsWkpo?=
 =?utf-8?B?RldsYlp4cVJJd25CcFE1ZXNrajM5bTRlRE5HUlhFRFNBVFNoOUFhNktBcG9s?=
 =?utf-8?B?VlVabW9sL2xzcnhaNkJiWk4xZ1k4SHBOaGtiY1owQmdleFVPN3ZxeXovOVlt?=
 =?utf-8?B?a2xGTENZQ3VXRXhHZUlIMEtNZnJGSktYVGZ1bTlTRFp4dFR6cWh0ZytBSGEw?=
 =?utf-8?B?T05ieU50NVlxNlJWRUs5OXlwbER4TjRKcVhyR1JYTGdIVXUzUWRvMitXUCtp?=
 =?utf-8?B?ZXpsSlB0TFNpdys3dCtFZFZFYitXZjRpUS9vM3FiUG5TTkl5ajh4cFBOT3dY?=
 =?utf-8?B?ZXQ5VzVZZTk2dUNHMGxnSTFuVTd4R1EwT2tnK0lvcUVIM1RGcDMvdEtFZURN?=
 =?utf-8?B?MWpxbExxbTlNeE1IRVZFOTNYU1hOdVJDeEtzT1NYWXVJRXdTYzB5Wm5RL3o3?=
 =?utf-8?B?OU5LWWlXUHlUaGs3d1NNNm0rR3Mra2owSGFsaEppbkxRUXVGNmJrMnljM0xa?=
 =?utf-8?B?enJ1OXNla3dIai9pUms5d0RFM2VkdWxDcTdCWTlrdjh3bWVoUDErT0RYRkhs?=
 =?utf-8?B?cVpBdmpGZWZPTGwwcUc4SGpkZUJuZUJUajVYNXk3UVVLMXZYTGIxd2pMK1BK?=
 =?utf-8?B?cXhIT0g1UUtxeEhzSmZYOGJYRUMrOHRHTUJDSEUzRkRKR1FNRkhEU2x0MzRl?=
 =?utf-8?B?YWwyZ3crOVhmTU5lUTZWaTkxM1BZV094WDR3WDFQOE9QaTBKQ3BBS0JiSFNX?=
 =?utf-8?B?RjB3MjR6R1NTaEo3ZXdwU21sTDRGdjVOejgxdGRqK0JwYVdvUS9YR3pJNU5J?=
 =?utf-8?B?Q2VIQ2NFUFpjVU81bHZtTGc0RFpXTXlzWWhld0RZbXVFM0cyUmVaOFBlZE1s?=
 =?utf-8?B?R2xmRVFPQzE2SFZaS2Q2UFA3RUR2aGRNb1Y1eTNld0ZhM2xIYklublJzU1lS?=
 =?utf-8?B?S0F5cHZnRG5rWnpYem9aSHo4cDdJNDkrcThuUDdWMWg2UFhqNXF1R1EzTDdQ?=
 =?utf-8?B?N0lVZEowL09zQVZDOW5QQlRZcFZ2Y2FORFYzc20vOCtWLzVmWEswMGk5NHJq?=
 =?utf-8?B?dEtmMDBMVEsrQkc0WHpIY2o2VVlsRmRoNFkzVzg4OFVrWnQ5eE55N2U4ZFc1?=
 =?utf-8?B?LyttYUszMS9IL0toTHc1VXBNdnY1OStvdkFCdHdORDd5bkdMNStGSjh3OGI0?=
 =?utf-8?B?ZVpjcW8vU0g2cC9Id0g4UU81cHROeEtqdjd2R1hMR000ZWFQc3BQNHhubkps?=
 =?utf-8?B?cUZER013TWxpMXBTTFZudEd6TjBHVHNUY2lJTVc0VjNSVTB5SG1XNCtuckxu?=
 =?utf-8?B?YUovcjhFbmxyVUpJUFdzZk1GMEtRdUVyaE5MZ29zQVZQTHp2dkh3dDlrWjB6?=
 =?utf-8?B?T1ZTa2Z1R29VcWF4S0xBUk1hUklIUUp0Z0Jkc0xMU2ZGWHZKTVRNRXVhWC84?=
 =?utf-8?B?YXJUVVRrK3Axd3h3d3M1Q2cvbWpMdWwwbEFURWxUL1Q5Wi9BM2hkKzVEM3h3?=
 =?utf-8?B?eXVUQWZ6OXAwUjlqRmR1UC9XTlNFWERuSW1JWFJSbStQZ0F6eWZHRVM5bUNh?=
 =?utf-8?B?UjlPRko0SS85eGlWdlpUcUVsZEwrKyszU3pkVU45dDZISWVjeWw3MmVjTEox?=
 =?utf-8?B?SUdTUkNPREVMMU4wY2wydnZtSmxiWFZiSzhaSEQ1VEdObjNFaU82Z0IrcE5n?=
 =?utf-8?B?YkdMWlJWellQdWZGU0VheVdzak9GQmo2cnpuQ0RHMndjNmk3bTZaZnZCUDJw?=
 =?utf-8?B?UjdYWmlvSGtvU2JUVTVCYzNYSVVvZmlzbWhxR1JVd1crZ3VxMGsrb253TC9z?=
 =?utf-8?B?M0lBVGx5VzVHOGJXb1ZNWGtIWjZZcUdSN3NnRFRkOTNZUUE1UU1vWVBLSlZV?=
 =?utf-8?B?aGRxbUxuMFBOVm5NS0IrYVUrNUk5WHYwR3RJRGZlTVpOVlkweElJQ1lVRDcy?=
 =?utf-8?B?c3RuWjkwRWxMMTFsZE1tbkVZQ0swQkxqZ0Vvb09kQXhhcnQ4amdaYkRXd2Nn?=
 =?utf-8?B?ckRDOEZMY3NQT2xXeFRmZjkvd1o1Q2pRazBXL0d2YzZyNmZ1d0t5bEFuenEy?=
 =?utf-8?B?NGJOQjhINFNJVHlSWS9mMlBscy9rWDFuQzkvMitWT0tISVRTM0Yvb29Ockhp?=
 =?utf-8?B?SkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee8e3a7-f01b-4f48-09a7-08dc21cf1f3e
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 20:07:44.8433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mVZxGgN/UEAEQzzZ/jm6FLeWZkdpRR+5+nNEPu7WmMbeAh7msiyzpJUqpK5G9/pcZO4DU3TcWT8TEDLk8ngiGR47lJLNcmm0TFC5xJD9x0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4985
X-OriginatorOrg: intel.com


On 1/25/2024 1:57 AM, Yunhong Jiang wrote:
> On Tue, Jan 23, 2024 at 02:15:55AM +0200, Michal Wilczynski wrote:
>> To resolve this, introduce a new emulator flag indicating the need for
>> HW VM-Enter to complete emulating RSM. Based on this flag, a decision can
>> be made in vendor-specific triple fault handlers about whether
>> nested_pending_run needs to be cleared.
> Would it be ok to move the followed emulator_leave_smm() code into
> vmx_leave_smm, before setting nested_run_pending bit? It avoids changing
> the generic emulator code.
> 
> #ifdef CONFIG_X86_64
>         if (guest_cpuid_has(vcpu, X86_FEATURE_LM))
>                 return rsm_load_state_64(ctxt, &smram.smram64);
>         else
> #endif
>                 return rsm_load_state_32(ctxt, &smram.smram32);
> 
> --jyh
> 

Moving rsm_load_state_* to the vendor structs would be architecturally
incorrect as vendor callbacks should only do vendor specific stuff, and
recovering state from SMRAM is VMX/SVM independent, and should be kept
that way.

nested_pending_run is unfortunately buried in vendor-specific structs so
it's zeroeing has to be done in vendor specific callbacks.

The way I structured this fix is hopefully in line with the discussion
under v1 of this patch, where Sean gave some background on the code and
proposed ways to fix.

Thanks for your input !
Michał