Received-SPF: pass (google.com: domain of linux-kernel+bounces-45267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 30 Jan 2024 15:30:30 -0500
From: Frank Li <Frank.li@nxp.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: mani@kernel.org, allenbh@gmail.com, bhelgaas@google.com,
	dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us,
	kishon@kernel.org, kw@linux.com, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, lpieralisi@kernel.org,
	ntb@lists.linux.dev
Subject: Re: [PATCH v4 1/1] PCI: endpoint: pci-epf-vntb: Fix transfer failure
 for fixed size BARs
Message-ID: <ZblcZnfUD7ZcEI8z@lizhi-Precision-Tower-5810>
References: <20240108151015.2030469-1-Frank.Li@nxp.com>
 <ZbJ/P5ldcrSs16q8@lizhi-Precision-Tower-5810>
 <ZblRXOabZWzRRWoT@x1-carbon>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZblRXOabZWzRRWoT@x1-carbon>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MGa+lxQGuVU3cWVj4E/iflPFxO1jq4XWMsjszdBb/mPSCZ8CgT0RKIbEjueR?=
 =?us-ascii?Q?VXGLnvY5O0ONTrxBkfYdlb1IanDD/mOEwRg09EWXODCxoWO+1ZBV59nTfvt3?=
 =?us-ascii?Q?UAN6ULsvJhunRV1hnYjdeJRkOXye2Pl2lS1m2eahFfyYkXkKo7VOZTbklh9O?=
 =?us-ascii?Q?WEkJUVLaUqK4qc3UtXqTXmuUZJeaDyyZU7fIGQGt8RiFL4eb2oAL4kjqE7mk?=
 =?us-ascii?Q?d2g8vATlb1gBXKm7pn6ux2gI4gJAGqNLrvY6pqSh7DA2kSBUV4WujC1ILW9o?=
 =?us-ascii?Q?SPZMZq1bQZ6gPPq8t6Icg5yR0U0soiUMH1KOe3GqTdawgxMxzAzqsQ/5XhXP?=
 =?us-ascii?Q?bZNom/2UdbNHAp0TlZl7lcMYcxkhRGBKYKKDbV0taC958Sc8WqZbatD84CRN?=
 =?us-ascii?Q?m3n8URM3Mqm44vniWoeuHK5rLJM5FOyiVBx9LF+GgB/LzTdlPpDYRcOzBP9X?=
 =?us-ascii?Q?zTecJJaVY+4UcOFnlg+xNILAIJT6wr6xqOS0SPxkiIpcMRO92HXnYd3dxxIo?=
 =?us-ascii?Q?Evv0tNKgpBc7lQjEiGsIBrW+YVcJhc4IAtaQnP0Z7YKrPV7KKbm6I9b65xgr?=
 =?us-ascii?Q?QVACRMviOBQQAAJri8vFpnpCbofGGhygY499+MNMOBwSWWPMA+w5LJ56AI6q?=
 =?us-ascii?Q?OUtK4SmrWdewVdAOmxfFUAbKHk3c2CL5bvH4bVpeMFMX+0FZ7wNVOVvbSnfW?=
 =?us-ascii?Q?xQVUC36ERQAhuEuJfgS25pqnV/6i/wW+wmjFE6AaUTqvFc4w59lQJP9vFOsD?=
 =?us-ascii?Q?fnKmS77WgBAWaLZXMVekBA6QH2o68CyGmC2yB4JQJ2gkUHs5kbJ+EIYf4isI?=
 =?us-ascii?Q?q3BzEA6ceFocJYtXWNZ1ltMNIqVwozfArkRsGQWYxksgsuYeSjqeZMPLfsmX?=
 =?us-ascii?Q?0/e9pVl5DdS8hzJKIArKYaG264YO/P75WnI5GmZyGFuSjKE8WAN4iE0CHip3?=
 =?us-ascii?Q?ZzpoatFWuzYDh6TbTKaujsHiCGXd0V9MCtuKYYQ+/hV1UJAg13YtyAxhr8zj?=
 =?us-ascii?Q?6F/M2+I0V0g+i9IHmnW7sIAowt/uTBccXXxVhjPf6cR6uEksfr62SFOyICeD?=
 =?us-ascii?Q?iuFShXUz/2f9r6L9ucU6SGkTitWy8RhiLydb9561fy3XrYZAJU/PQkK0DqPq?=
 =?us-ascii?Q?/a5lMgqwu/2Ril5Gb5dBVdHzjSD02U01BNBwAQYabt07Rzy7qjnG2Gveobwa?=
 =?us-ascii?Q?c/u3smcmWxkWSx8cjNMAX598CGxmSsFIKy9cLd+lZtLFNPpOoD4nShz35mn+?=
 =?us-ascii?Q?nyjZQ5m9z95jC5s8Joje3C7cqd+SYZLklzjkrdMFYldwSNKTIZ2f4nwr+L/E?=
 =?us-ascii?Q?FZPaOq/COim/EOE803oHDFGnM3Or7rK31483iHqY/C6ZvtV47EtCiM1izHiu?=
 =?us-ascii?Q?H9oFZiwkwYERM5ZMjsilAsr1D3FY05NTdH95njyGeiO5jPLc+z1uInTAwko4?=
 =?us-ascii?Q?9xOIzGq6zHo3un03Z/qYTCNeVs6Q6bv1fqH6uEDDoFEajZJxNZkhL1NAPTV/?=
 =?us-ascii?Q?tjcOTkzKltNBJGNs1J3oyFxiZsxaMPb384ovwwH16zP5+SXKOKoZ5BR+WoT9?=
 =?us-ascii?Q?ZJuJKRR/GDX4KUSMxqzDJuPFw64WKepFu4Uh9JE0?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff5b604d-726b-41ef-c1af-08dc21d2515e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 20:30:37.5332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pW2TJHbPzb9RZ9/32p+uPFHAO9nPo2xhe717GOXzj4Fao/g9OKkPLrhMsOYyzze4QxYPPsTChmYHYK5rn7VeBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7661

On Tue, Jan 30, 2024 at 08:43:24PM +0100, Niklas Cassel wrote:
> On Thu, Jan 25, 2024 at 10:33:19AM -0500, Frank Li wrote:
> > On Mon, Jan 08, 2024 at 10:10:15AM -0500, Frank Li wrote:
> > > For the inbound MEM/IO TLPs, iATU on the endpoint expects the target
> > > address to be aligned to the size of the BAR. For configurable BARs, there
> > > is no issue because both host and endpoint will know the exact size of the
> > > BAR region. But for fixed size BARs available in some controllers, if the
> > > BAR size advertised by the endpoint is not same as of the actual BAR size
> > > used in the controller, then the MEM/IO TLPs generated by the host will not
> > > be translated properly by the endpoint iATU.
> > > 
> > > So if the fixed size BARs are available in endpoint controllers, always use
> > > the actual BAR size.
> > > 
> > > This only fixes doorbell (DB) BAR. A similar fix is needed for memory map
> > > windows(MW) BARs.
> > > 
> > > Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> > > Cc: stable@vger.kernel.org
> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > 
> > @lpieralisi:
> > 
> > 	Could you please pick this fix patch?
> 
> 
> Hello Frank, Lorenzo, Mani,
> 
> 
> Frank, sorry for not seeing this patch earlier.
> 
> Could you please see if this series fixes your issue:
> https://lore.kernel.org/linux-pci/20240130193214.713739-1-cassel@kernel.org/T/#t
> 
> I think it is nicer since:
> 1) It doesn't add copy pasted code from pci-epf-test.c to pci-epf-vntb.c.
> 2) I would expect it to handle both the doorbell BAR and the MW BARs.

Agree! Thanks

Frank
> 
> 
> Kind regards,
> Niklas