Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1251998rdb; Tue, 30 Jan 2024 12:31:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqf25Q55Qx/YZRn6gqvlpIZ0PrbwwvzkvQc3ID97XPPlQp+WAO++fR2Hv4mODhbAUlZDws X-Received: by 2002:a62:e211:0:b0:6d9:a865:7fb7 with SMTP id a17-20020a62e211000000b006d9a8657fb7mr5914991pfi.13.1706646666264; Tue, 30 Jan 2024 12:31:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706646666; cv=pass; d=google.com; s=arc-20160816; b=kXOomA9upGtwQO7IWUNNTFg/9PMpa80qdc4VbVnXwmdqG7E+nky+YCi4mAReI/Eh+D Ihsu+7ocF/SK5viwI4vERSHVYQ5Ngbm/QLza0xaB/d5xVwys8iXhHz+5EC9L3dgL0Ik1 FuOAom7cAOUSKDjlnzXXly2hywvZ3Pyb3d4DvVhKBED0MY9cwCxzsN4c/o7ZquczzVWs IRCXEwTHBnrFXC4ZjUlHc6TeJzDOC6ueGUt7k1igfpwdiF361Pn95UG4rYbByUy6Up9v kgSKjW42p7AjJm1rYq2iMGytY2lfQDdF44rWoiTlg1jHWtIxKNYhSkSXnXbdqK37/JMf oJqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=2Yn31EQKZK4X8hy4N4sV8rz+0Q5rsjJX9s+Ku6X3WQU=; fh=lSAMF+MCeuhvq2OY4wR2SBy7r8PMx+Xk5A6mZhnmV64=; b=zvAm88J6XGxMdAeuOzxE0zoqblLNxwZzfDnBl8lfKC2LLCTzbXEdfsVha7RxKHo35z S5AqNBLPOARBGjAEMySXmCwhpCXfmXUu5Vd47CDXNVewJ4BfLpo0Pf8QJM3IpSzASePs s4Y/IFbrk/vXc0K1vo/H1qAzE33hZpHIhEhZgpvxBUvDbJpTdAAJawfac7BjMOjQ9jzy 2pmV5ekCdR8HbHbNKerteV4urRikQNHN7SxsK3F/VR/EVI3wS81pGHKe0XjhRLbhnTze 6+brQp/msF2TUBZbH+mAL/HjcAKb2RmVQnmwWH5RtpR7E2u631OZlU4Df0ld6FXzmwa2 +jnA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Q+fMadDJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-45268-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45268-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f14-20020a056a0022ce00b006de378fb498si2992110pfj.249.2024.01.30.12.31.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 12:31:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45268-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Q+fMadDJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-45268-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45268-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E2D1428B793 for ; Tue, 30 Jan 2024 20:31:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B47BD1DDD6; Tue, 30 Jan 2024 20:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Q+fMadDJ" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D909B79DD4; Tue, 30 Jan 2024 20:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706646661; cv=none; b=CpsRxbxnibiyl2nN1akrCAghgaNz2Rr+l2sHcOCitSjbgmkLK5c4NMsDvs976mAEqjgZzYt35TeP+aWHo9vTDg58aAz42MrneOkQ7Yo5F+hktwKIeytEUeS3bXwDUhVj+MdefPvmtoK9IKJZ8Imd1lPJarADIZj/vcsA5Dx3sXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706646661; c=relaxed/simple; bh=2/KBwsPO3whpyFBvrCj3xnlg42ijgGLiSwxQ8/wfXis=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MwOaMrs4mBf64d2h3BhAJqvmzHmBMcfdJA7QB8nrlH4Ab0tsVCeKZCI1xCWYGYAwVYvV7o1PZmUh9DRR84zzv5q6dj+3HGuj9h44VJAnkZqqbiTVL/U1b7nm+Z2nqpbs+TMtnvGJZ3yfHvjofok5m7wPvRs7/fy254FqGo2hiw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Q+fMadDJ; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706646660; x=1738182660; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2/KBwsPO3whpyFBvrCj3xnlg42ijgGLiSwxQ8/wfXis=; b=Q+fMadDJe8YwP3xy0vXz7mMKZnRZK+2qvMJQnVR7NYvZ+FoT12z4wksz uXakEQ+Ijco4foHOK9xahKmGOJVB4GZ5u5p8sJ3BgevL3uE7TfsDgTR6i 5zH284/xPTwVRNRrZrAuSkKPSWpcpMpCQRDvHkP/p+mOmQfWtuZBY5PCk TBDzqcKc6sfu0i6OKTOVbmc7xKo9ftiXYwOUFFmOVsDVp5EM/XdQrFW1R bJL4Zf7PkL2a1TTJAIMRl7OhQTgbP9tm8+0xymUzQ+ZxezKNLeoH+ZyPl 3lh11iyz+9lV7uRlyzFGqcgYM0GHZ1BTY2Qh2lAJ4keOq3xy8VB77iado A==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="10493952" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="10493952" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 12:30:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="907617882" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="907617882" Received: from anjishnu-mobl1.amr.corp.intel.com (HELO [10.212.150.19]) ([10.212.150.19]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 12:30:56 -0800 Message-ID: <388be136-f91c-403a-99e1-7a10c5bf9691@intel.com> Date: Tue, 30 Jan 2024 12:30:56 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dmaengine: idxd: Change wmb() to smp_wmb() when copying completion record to user space Content-Language: en-US To: Boqun Feng , Mark Rutland Cc: Fenghua Yu , Vinod Koul , Dave Jiang , dmaengine@vger.kernel.org, linux-kernel , Nikhil Rao , Tony Zhu , Mathieu Desnoyers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org References: <20240130025806.2027284-1-fenghua.yu@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/30/24 11:53, Boqun Feng wrote: >>> Fixes: b022f59725f0 ("dmaengine: idxd: add idxd_copy_cr() to copy user completion record during page fault handling") >>> Suggested-by: Nikhil Rao >>> Tested-by: Tony Zhu > Since it has a "Fixes" tag and a "Tested-by" tag, I'd assume there has > been a test w/ and w/o this patch showing it can resolve a real issue > *constantly*? If so, I think x86 might be broken somewhere. > > [Cc x86 maintainers] Fenghua, could you perhaps explain how this problem affects end users? What symptom was observed that made it obvious something was broken and what changes with this patch?