Received-SPF: pass (google.com: domain of linux-kernel+bounces-45320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240115144538.12018-1-max@enpas.org> <20240115144538.12018-8-max@enpas.org>
 <CAEc3jaBU3M0Zce2pdFvdBSG50a7Ky=GY4gLO3dkYdDrkYtiO0Q@mail.gmail.com> <e107b202-5843-41a7-b61e-68dd92128176@enpas.org>
In-Reply-To: <e107b202-5843-41a7-b61e-68dd92128176@enpas.org>
From: Roderick Colenbrander <thunderbird2k@gmail.com>
Date: Tue, 30 Jan 2024 13:07:20 -0800
Message-ID: <CAEc3jaCifoWW3ZXHvySSfgwhVm1AffYe=z7HRP9RjmYyu53w7Q@mail.gmail.com>
Subject: Re: [PATCH v1 7/7] HID: playstation: DS4: Add VID/PID for SZ-MYPOWER controllers
To: Max Staudt <max@enpas.org>
Cc: Roderick Colenbrander <roderick.colenbrander@sony.com>, Jiri Kosina <jikos@kernel.org>, 
	Benjamin Tissoires <benjamin.tissoires@redhat.com>, linux-input@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 27, 2024 at 3:16=E2=80=AFAM Max Staudt <max@enpas.org> wrote:
>
> On 1/25/24 10:03, Roderick Colenbrander wrote:
> > I'm not familiar with this device, but if it indeed works. Then I'm
> > okay with it.
>
> Thanks!
>
>
> I've just tried this patch on real hardware again, and there's a tradeoff=
 here - it improves the situation for one 7545:0104 controller, and worsens=
 it for another.
>
> Up to you, and if you don't want to think about it, then let's shelve thi=
s patch :)
>
>
>
> Details follow, if you're curious.
>
>
> I have two controllers with VID/PID 7545:0104, and they're both very quir=
ky multi-emulation devices. One is shaped like a PS4 controller, the other =
like a hybrid between a PS4 and a Switch controller. Since these controller=
s exhibit all of the USB related quirks in this series, I've kept them as r=
eproducers. Other controllers that passed through my hands only had a subse=
t of the quirks.
>
> Up until now, both controllers worked with hid-sony as PS3 controllers. W=
ith this patch, the PS4 controller gains LED support and fine-grained contr=
ol of the weak rumble motor. The "Switch (?) controller" on the other hand =
errors out, becomes 0079:181c, and loses the Home key and the accelerometer=
 This is a user facing change, and the question is how much we really care=
 about these controllers.
>
>
>
> More details, if you're still reading:
>
>
> Both are "multi-purpose" controllers, appearing as PS4/PS3/Switch/other c=
ontrollers in sequence. They advertise themselves as one USB device, and if=
 there is no driver sending whatever init sequence they expect, they discon=
nect and try emulating a different controller.
>
> The PS4 controller has rumble and an RGB LED, and this patch series impro=
ves its functionality. It cannot emulate a Switch controller.
>
> The Switch (?) controller has no rumble and four multicolour player LEDs,=
 but it adds Switch compatibility including accelerometer and gyro.
>
>
> For the PS4 mode, which is the first that they try, and which would unify=
 most functions, they use 7545:0104 instead of cloning a DS4 VID/PID. So I =
took a guess and found that it works fine with hid-playstation if I add the=
 VID/PID and the init quirks in patches 2/3/4. Well, to be precise, I've on=
ly made the DS4 shaped one work in PS4 mode, the Switch controller isn't ha=
ppy and errors out, see below.
>
>
> On the PS4 controller, this makes the RGB LED work, rumble works, but the=
 gyro and touchpad don't send HID updates. The touchpad can click though, s=
o maybe the controller I have has a hardware defect.
>
> The Switch (?) controller is where things get weird. It disconnects, even=
 though it is initialised by hid-playstation, and transitions into a generi=
c controller with VID/PID 0079:181c. This mode is *not* on the list of emul=
ations it usually tries. It's as if the "unfinished" PS4 initialisation tra=
nsitions it into a hidden fifth emulation mode. In this mode, the home key =
does not send any HID event, and there are no accelerometer updates that hi=
d-sony would receive in PS3 mode.
>
>
> So, with this patch, the PS4 controller works better on Linux, while the =
Switch controller works worse. Both were seen as PS3 controllers up until n=
ow. I see no way to discern them at driver probe time.
>
> Any preference on what to do...?
>
>
>
> Max
>

Hmpf, euhm euhm I'm not entirely sure what makes sense. From the
sounds of it are somewhat broken devices (buggy firmwares on them) or
perhaps one of your controllers (the one with not working touch) is
perhaps broken.

Some of the patches like handling report id 0x1 (minimal) won't hurt,
the LED fixes won't either. It makes it easier to add more devices. I
wonder if we have fully have enough data.

Need to think a bit...

Roderick