Received-SPF: pass (google.com: domain of linux-kernel+bounces-45339-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Marc Zyngier <maz@kernel.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Sebastian Ene <sebastianene@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Will Deacon <will@kernel.org>,
	James Morse <james.morse@arm.com>
Cc: kvmarm@lists.linux.dev,
	kernel-team@android.com,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] KVM: arm64: Fix circular locking dependency
Date: Tue, 30 Jan 2024 21:40:43 +0000
Message-Id: <170665083753.694736.5736115942255110234.b4-ty@kernel.org>
In-Reply-To: <20240124091027.1477174-2-sebastianene@google.com>
References: <20240124091027.1477174-2-sebastianene@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Wed, 24 Jan 2024 09:10:28 +0000, Sebastian Ene wrote:
> The rule inside kvm enforces that the vcpu->mutex is taken *inside*
> kvm->lock. The rule is violated by the pkvm_create_hyp_vm() which acquires
> the kvm->lock while already holding the vcpu->mutex lock from
> kvm_vcpu_ioctl(). Avoid the circular locking dependency altogether by
> protecting the hyp vm handle with the config_lock, much like we already
> do for other forms of VM-scoped data.

Applied to fixes, thanks!

[1/1] KVM: arm64: Fix circular locking dependency
      commit: 10c02aad111df02088d1a81792a709f6a7eca6cc

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.