Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1311243rdb; Tue, 30 Jan 2024 14:51:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOlz5OAYKzBl1kkT7hngpoKg0X3A1BlHYnUpHhR2Nfn4U1eICpCxLHPaM5QoCAMS+WhT/K X-Received: by 2002:a2e:9082:0:b0:2cf:3238:ebe0 with SMTP id l2-20020a2e9082000000b002cf3238ebe0mr6628531ljg.53.1706655090044; Tue, 30 Jan 2024 14:51:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706655090; cv=pass; d=google.com; s=arc-20160816; b=AEOUx4kE9cAhGrJj+SdRsl3sHN7tUCDJFtc+4AYoGIeVA8Nl3Rydp3DXhKHIGspY14 oavB9rfut5YMf3vhEArSs/tKy5QRtHKciT//tCofmAwmVLWaSmfCo0aHTUxEpHHEppGW rqb+1mI0S+r8tOot9NZLsCwbKGHZLVZzux0BXkAzU+GdU0ZAlyPy0F5RGBQgFqa0qMyY Fjq8skChaMwUFsSXDzBWNhelyobRwFU9VhqDmnZSe/ix4s1dwkr2pTJiyOk97avz1Ge9 FBUYFXZRLykyi9b4HSXRRVH4EzxUJ7YckB79KOvOdVWKD4Rh4abFX8dUvgBgQFVUBHbh wtug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Apxqc7WdngmvLhf6HhOlXgsapLM2Jf+G/YfD0JkToxc=; fh=hnC41mfTaEq2I0OXjSEe2ttFk6e9aakTq9Z1GQy0Gn0=; b=p7VN3HfoCkVCoc8OH/QvEyXxomt5MV20qwFWNQMuZZmX3XocMQyvFXjrfMBFZ62G4p Z1xsgXoWmKBT5xLDIYGCtu8G+WDPFTwvdT9B70veKnycCAuglW4zfjbSAKH90pTpToyW 1K5t0lGIxPf2IxQohfSiPdKCCBYgl7HR4mr53IPkC1iF/UgMnFQIRuQfALOmaUaqort6 J/uToUggvSyv9ab1ZKsgMZ1GFnZBMLAnvIB3SXSIji56Xxdx6c20Q7e+/Xog54IeQsbn Uh86x3rhEpvB7brra6TLK/kYXXiyEkxRTtMN3iE/x8Qe4RIxouW9LT0gabBEV/iMO8ux rLtA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ns9OFMOM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-45430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45430-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id eh3-20020a0564020f8300b0055f0014e1b2si2327441edb.387.2024.01.30.14.51.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 14:51:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ns9OFMOM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-45430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45430-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5EBFF1F23317 for ; Tue, 30 Jan 2024 22:51:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 245E57EEFF; Tue, 30 Jan 2024 22:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ns9OFMOM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 454FC7EEE3; Tue, 30 Jan 2024 22:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706655066; cv=none; b=dNotqgnFc+m6RcUv0/41feeHr+C99fIl5ehGTQCm7Jt1zHAjAPGvsgCihEUmaTdFi/DqFG70/OlhRmX6HpXkEIcP7PLVlZQIfkNr5VWnJaSzhikuV4RRU4BZ9jyazvENdP9umoa5A39kBIxvCPeIx0LAhAJcewClhFcsw+RSlP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706655066; c=relaxed/simple; bh=bIrBrbX48HIWDuxq8XoOFI3Dqwa8CFXd3p8UGpUs+hQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WDJMMH8YC1a2u5uC6wQu9vO31Te3UDXDRaDgkZtVE3yUq83SipY2LhlVxx23S2Pzivg/TOm51dRXEdIxFjqn3AcCG9bnBOkEQKwcDDM+abDk8kH+OWXl20XMlhFz8q9UDau3jyIgxHBFvi0Wq1FphUnJYROKt4Q/o23ExPwDsvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ns9OFMOM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BB1DC433C7; Tue, 30 Jan 2024 22:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706655065; bh=bIrBrbX48HIWDuxq8XoOFI3Dqwa8CFXd3p8UGpUs+hQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ns9OFMOMvY4m35RdXyZZwO5clfUmNSQQD/3O7Gn7YKHhGxm9ANHX2Fy4MKhPosx+d DCdL+z/O5vcvwWiKWOd0IZSVU4T2Zv80+lfnEDuIXeOfGGu1DS0Hq0GSIHd/mq5Yyx d4CXaYcheXxYhOKHRQOlzt4mT0C3ZAgLl1yK7oF407NxGoufqRfX4pUXlXDc+bLhhm j6WLCH82X4Nxw13/73+o+bYO7ViW249SAckIGkF0YH9FKdqgNeKqcuKVPUx2cit0Ji 6WLz8Tdz6sOxVVIi6l2D58JGDVvKK3/1nm2Mx5Bq/ldj5Wnbno/pBlt+88atebJZC/ 53FOgkz6Eno6w== Date: Tue, 30 Jan 2024 17:51:04 -0500 From: Sasha Levin To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, duanqiangwen , jiawenwu@trustnetic.com, mengyuanlou@net-swift.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, andrew@lunn.ch, bhelgaas@google.com, maciej.fijalkowski@intel.com, horms@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac failed when running Message-ID: References: <20240116194225.250921-1-sashal@kernel.org> <20240116194225.250921-50-sashal@kernel.org> <20240116173955.57ba27f3@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240116173955.57ba27f3@kernel.org> On Tue, Jan 16, 2024 at 05:39:55PM -0800, Jakub Kicinski wrote: >On Tue, 16 Jan 2024 14:39:16 -0500 Sasha Levin wrote: >> in some bonding mode, service need to change mac when >> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE >> priv_flag to support it. > >Not really a fix, more of a feature ennoblement. >Let's drop it, we don't know what it may uncover. > >We should probably start complaining when people use >the word "fix" for non-fixes :( I'll drop it :) -- Thanks, Sasha