Received-SPF: pass (google.com: domain of linux-kernel+bounces-45547-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 30 Jan 2024 16:47:06 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Mina Almasry <almasrymina@google.com>, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Jason Gunthorpe <jgg@nvidia.com>, Christian
 =?UTF-8?B?S8O2bmln?= <christian.koenig@amd.com>, Shakeel Butt
 <shakeelb@google.com>, Yunsheng Lin <linyunsheng@huawei.com>, Willem de
 Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next v6 1/2] net: introduce abstraction for network
 memory
Message-ID: <20240130164706.6eb6a9b3@kernel.org>
In-Reply-To: <0c767128a7ceee72c3cfb4c17498ef3b6fd87a56.camel@redhat.com>
References: <20240123221749.793069-1-almasrymina@google.com>
	<20240123221749.793069-2-almasrymina@google.com>
	<0c767128a7ceee72c3cfb4c17498ef3b6fd87a56.camel@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 30 Jan 2024 10:59:53 +0100 Paolo Abeni wrote:
> > + * netmem_ref - a nonexistent type marking a reference to generic network  
> 
> Minor nit: here you need to prepend 'struct' to avoid a kdoc warning:
> 
> include/net/netmem.h:20: warning: cannot understand function prototype: 'typedef unsigned long __bitwise netmem_ref; '
> 
> Should be:
> 
> * struct netmem_ref - a nonexistent type marking a reference to generic network

s/struct/typedef/

 /**
  * typedef netmem_ref - ....
  */

Somewhat surprisingly kdoc understands the typedef keyword just fine :)