Received-SPF: pass (google.com: domain of linux-kernel+bounces-45614-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <13703200-af1a-4776-98b2-b9a7261de2e6@quicinc.com>
Date: Wed, 31 Jan 2024 07:22:54 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v9] bus: mhi: host: Add tracing support
Content-Language: en-US
To: Manivannan Sadhasivam <mani@kernel.org>,
        Steven Rostedt
	<rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>, <linux-kernel@vger.kernel.org>,
        <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>, <quic_vbadigan@quicinc.com>,
        <quic_ramkri@quicinc.com>, <quic_nitegupt@quicinc.com>,
        <quic_skananth@quicinc.com>, <quic_parass@quicinc.com>
References: <20240105-ftrace_support-v9-1-a2dca64cc6ea@quicinc.com>
 <20240130081152.GH32821@thinkpad>
 <20240130092252.32801387@gandalf.local.home> <20240130182654.GD4218@thinkpad>
From: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
In-Reply-To: <20240130182654.GD4218@thinkpad>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/30/2024 11:56 PM, Manivannan Sadhasivam wrote:
> On Tue, Jan 30, 2024 at 09:22:52AM -0500, Steven Rostedt wrote:
>> On Tue, 30 Jan 2024 13:41:52 +0530
>> Manivannan Sadhasivam <mani@kernel.org> wrote:
>>
>>> So same trace will get printed for both mhi_channel_command_start() and
>>> mhi_channel_command_end()?
>>
>> The trace output will also include the tracepoint name. That is, it will
>> have the same content but will be preceded with:
>>
>>    mhi_channel_command_start: ...
>>    mhi_channel_command_end: ...
>>
> 
> Yes, but the message will be the same:
> 
> mhi_channel_command_start: chan%d: Updating state to:
> mhi_channel_command_end: chan%d: Updating state to:
> 
> Either only one of the trace should be present or the second one should print,
> "mhi_channel_command_end: chan%d: Updated state to:"
> 
> - Mani
>
I will try to pass a string to updated for mhi_channel_command_end &
updating for mhi_channel_command_start in my next patch.

- Krishna Chaitanya.