Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1391091rdb; Tue, 30 Jan 2024 18:09:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGmWv2yJNQTaw8KUwo0Bs0dCcHXlW/4uTN2coYYWYRr12DT6SagjFjOwi4vFL9JRBPCVJ8 X-Received: by 2002:a05:6830:1e63:b0:6e1:14e8:9f4e with SMTP id m3-20020a0568301e6300b006e114e89f4emr149743otr.33.1706666940781; Tue, 30 Jan 2024 18:09:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706666940; cv=pass; d=google.com; s=arc-20160816; b=yJeY/27dhljVAp6OVGo8QFJgxiq9KYJ1oRkwtu94GqbOOR+IWXkFVqjwnon/XvtWSF 0Y8rqMUisNXNbr/bOe0TfC7LDCBAfnjqi7/3ayVXeHsFYHUHVg1zZLCS0uk13upHPdzp Tr/zKN5620MphpcnlNNE4fvk7prx+nptsC76AQbB5gO4uuTJuLJmVwEgI/E6FOSVVBKo tmIJGBVuTyWFni03XQ3Rfh/PW0MkIAzcpSd3s1WPLFl0NhHXkOc3iFEyIoJ8J/utaU0x vbIhdsnTxz+wACUiYnx0bhoJkKykqjLYKjEym1jxzfPX5kSYhbUf/B+qoKalvLJhhQf+ Jrbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gPuSSn5nJbJgblYiPPUHg0W2Nt30JVW9wMwUiWk4yAw=; fh=XejchshmVmZtsNv5fHqVsehDWWfdwnn9NWZxpJcZxrc=; b=la6yX9mQkFyAMpEGoaANqr4cK0Jre5DHmrLdNs9t3XjBAeFxLJN6wJxT8KSfIZpxtp ScaenyhPlTfTSSDU4TOUxApDoCGWVc+fh8X1zXwvZAanX+np4g3+fapYslxzdcSFIjeS d+nS2B8ipGgyKlHufM8wRSIeEx/T1IlYPW0CvzAnwuk1EwaASaw+5wDYVdlQJvQe14ZZ MBaq5uZYbQTAs32bF89D+0vhFRY8UMURswfhrZ5XCQX4Ox7fEoXvwBtA3efgJcvam8mS yjiv2kMWcI+zdCVOIYnbKw53BIY+i2WCkqXx161SjosQFmEzDBlAtuBwm2fal6dBVjV1 50zw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cjp1OFPL; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-45623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45623-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org X-Forwarded-Encrypted: i=1; AJvYcCV0XwA9kJUwNIm44yYz6eRNE36sQ0QFKgqR13UcTQXg0rYB0v4SKTU9lfLBnKs/SbwC3hsRBVgL5Rp+VDMW5emKVjC6LvHnfvJYWEIvQw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id s188-20020a635ec5000000b005d8bc1d9b70si6208242pgb.24.2024.01.30.18.09.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 18:09:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cjp1OFPL; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-45623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45623-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BA21CB23D6B for ; Wed, 31 Jan 2024 02:08:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C89735695; Wed, 31 Jan 2024 02:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Cjp1OFPL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97705223; Wed, 31 Jan 2024 02:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706666917; cv=none; b=ijfzzVjT6jYgkH34d8UX6TT1iKlht/yyf1p175VjOC6ys0jbVZkNaiuohi4UoFsWIk+QtpKcGEY/dXJV7TX9VcgqnHd+rAfMSidnvy1S8LV14GAS8+Z1e6p07d3tNQ8Pi0xsWRUytXY+G96VHtjgMNN3jKrl6FeJxeuoLdgRe+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706666917; c=relaxed/simple; bh=IBH1x5SGT6nGLDE7TxOtnN0YvnQkEver8imdueRKTDE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JSbVoDWdP0zoJoynYtiWJwRbI3KjACyPaBTtKbgIsFOnRTaSbkIMAj6/n18r+sK2SiIGgVQCNmEPshULW/vvRrCzw2/u5W12JFqWiUF9nH0qTqbRYR829Lpp2U3b55A4feH6/ScbfUXPUjtuHd7lv9uLE9NUvjo4dbTp3LPVQDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Cjp1OFPL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85027C433F1; Wed, 31 Jan 2024 02:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706666916; bh=IBH1x5SGT6nGLDE7TxOtnN0YvnQkEver8imdueRKTDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cjp1OFPLc8a4EwCy4DTj45NxNuKb9gGIovN6fjagz0WBs9Q2oNt4wrBMB2wclD00Z p0/VDOa22DaYJ4worUHIaKNidJXQoBv/Wc+0N5RxM+/4Z6MpypJG8WdJ/jUL5pMgQp Gduct+iEoXTiI9szqnyCcweZ0tachHDVKilhKvHU= Date: Tue, 30 Jan 2024 18:08:36 -0800 From: Greg Kroah-Hartman To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@aculab.com, arnd@arndb.de, Jonathan Corbet , Alexander Viro , Jan Kara , Michael Ellerman , Nathan Lynch , Thomas Zimmermann , Maik Broemme , Steve French , Julien Panis , Jiri Slaby , Thomas Huth , Andrew Waterman , Albert Ou , Palmer Dabbelt , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v4 3/3] eventpoll: Add epoll ioctl for epoll_params Message-ID: <2024013001-prison-strum-899d@gregkh> References: <20240131014738.469858-1-jdamato@fastly.com> <20240131014738.469858-4-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240131014738.469858-4-jdamato@fastly.com> On Wed, Jan 31, 2024 at 01:47:33AM +0000, Joe Damato wrote: > +struct epoll_params { > + __aligned_u64 busy_poll_usecs; > + __u16 busy_poll_budget; > + > + /* pad the struct to a multiple of 64bits for alignment on all arches */ > + __u8 __pad[6]; You HAVE to check this padding to be sure it is all 0, otherwise it can never be used in the future for anything. thanks, greg k-h