Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1400099rdb; Tue, 30 Jan 2024 18:33:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbExykY7xxT24jroeIle07PZx3g4P1y4td55Hjl7adu/3VOB8sOKhGIEUVs5DO96BrhJ/t X-Received: by 2002:a17:906:e9b:b0:a36:741e:a5 with SMTP id p27-20020a1709060e9b00b00a36741e00a5mr143128ejf.70.1706668428005; Tue, 30 Jan 2024 18:33:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706668427; cv=pass; d=google.com; s=arc-20160816; b=cak//dXoMkPjq8vtaN552vljGNl1bxtRp4jIP/PwLvskrI1YIkXJGNDAxd2vVymHvJ zR9KDmtNniA0n52NB/Kr8wSpDSUIIUuttRaGSsn2JLhfj99G9dLK598ZzWgvu5XxRfcp 1syC/t9GMUmzSicKcf0TKVlvkiCOO5raD+j3vK6+8w7kKSWCepR5VSzBEgUgAfX0KZM3 /9mNdWQ7dRZirhGAAIOzj2ANqc3soTFO5IrzutH4lv1fQcrHPmdIOSNixWlHJmRTuGZI inzaORpHWAEcsvh329Iygt3psTq5BzPDE9JoSEWKXyJk12Qyr7alUvXz07Krk5xvdOsf YGLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nWdIOn0IEFGSWfeD78wagVa+SS7vgtQYY178q8QxHJk=; fh=Y0nswyfWVh/Nmb/aof5OlOIDIqHQx1FdY8KFjhEmvfc=; b=x92ws7/xLpJWxep2BJ5iUM0qfJGs/tu2I50FBoASTfYWJ/Ly6prGrJB/siULGiw29h 0CqAyjEIyGVajZAHVzxIu152IUluOdwvE01ISRb/wGb8QUIfYgv9j9xmxnjvgyq+7ooB hOa0rlEMsXy2EArBGNnXvTTg4urW0gJULZLFtJ52oSwPyIBs9ImXVo49WsD9VDuzTdf6 1zCSqOAJCkUv6QB4kXppVSsV6n75g+cPfihjNyiKl5mg4dW4oVVqAi9QkjIXEAEzxyP4 sPa7m7RtYZJIPwgLJh7ndohUuNOV3bx05LZEY/5ihEsP6wgEb6LnBFsPw4dk3H3uK0VJ e9iQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G498xFUh; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-45680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45680-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org X-Forwarded-Encrypted: i=1; AJvYcCU/mN5zMHd2FC8vMGOxfM/DJq88Qacu5y61pa3lFYMQ7uhWlubYSR6+DciQ1CyWO/NKetDXH/5qW9pEntpqlpKzqL+8dMQtF43fw5ivGA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id mj22-20020a170906af9600b00a367e12d0c2si7900ejb.603.2024.01.30.18.33.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 18:33:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G498xFUh; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-45680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45680-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A44AC1F284BA for ; Wed, 31 Jan 2024 02:32:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 19C72E576; Wed, 31 Jan 2024 02:32:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="G498xFUh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22EB0611E; Wed, 31 Jan 2024 02:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706668319; cv=none; b=QDXCR0/QLS30S6LnTSmJFKSsvGhuV3GYMvXM4oBNIH5358DuCihFztml21Z00ku+KeYuk9XL5Dhqh1d5UvI1vNhvmgeEWwR2w9a3QtPFanQ53S4qNqRyhU/rlI4Ptp/D3VUOoeAfYxeHEIEyKC2cTWRdxYuc2056S8prQqR9eWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706668319; c=relaxed/simple; bh=djoFTXuxmksb/FdNwJVAeN6Af9a5fltCn/3BeXgcsxI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c5BthIHpkmx1waXuo7iBVHZqrW5eiiND3k5qmCt5N5I/UZtW7yojRXqB+si0Xp+yhjMNr4x1QZlG/Pdv3q7YlIEjVptKQnje28+2lUKHez2XleGsWEYj439WewojECMtNQHTtpY2gZZjHuhC9RyrO2EDXSQ3hF8RtPKlGfTFKvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=G498xFUh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64AD7C433F1; Wed, 31 Jan 2024 02:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706668318; bh=djoFTXuxmksb/FdNwJVAeN6Af9a5fltCn/3BeXgcsxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G498xFUh+N8EeVWIa6bF34OWQdzTtoP+Y4iTIG/ugVxJ5uRGI9Tmy3N9VJSM0Eb03 5Yi+to2iuPepzWGviH7Iqk4RuWLmZly0mVQaWVZOlJdGGPewlO3dlIcgBEL/humtWU hFGp7QORHSFyEwPOnZWL3Ul1ps3uXD/izeJQlAa8= Date: Tue, 30 Jan 2024 18:31:58 -0800 From: Greg Kroah-Hartman To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@aculab.com, arnd@arndb.de, Jonathan Corbet , Alexander Viro , Jan Kara , Michael Ellerman , Nathan Lynch , Thomas Zimmermann , Maik Broemme , Steve French , Julien Panis , Jiri Slaby , Thomas Huth , Andrew Waterman , Albert Ou , Palmer Dabbelt , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v4 3/3] eventpoll: Add epoll ioctl for epoll_params Message-ID: <2024013045-manifesto-each-cbdc@gregkh> References: <20240131014738.469858-1-jdamato@fastly.com> <20240131014738.469858-4-jdamato@fastly.com> <2024013001-prison-strum-899d@gregkh> <20240131022756.GA4837@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240131022756.GA4837@fastly.com> On Tue, Jan 30, 2024 at 06:27:57PM -0800, Joe Damato wrote: > On Tue, Jan 30, 2024 at 06:08:36PM -0800, Greg Kroah-Hartman wrote: > > On Wed, Jan 31, 2024 at 01:47:33AM +0000, Joe Damato wrote: > > > +struct epoll_params { > > > + __aligned_u64 busy_poll_usecs; > > > + __u16 busy_poll_budget; > > > + > > > + /* pad the struct to a multiple of 64bits for alignment on all arches */ > > > + __u8 __pad[6]; > > > > You HAVE to check this padding to be sure it is all 0, otherwise it can > > never be used in the future for anything. > > Is there some preferred mechanism for this in the kernel that I should be > using or is this as simple as adding a for loop to check each u8 == 0 ? It's as simple as a loop :)