Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1401834rdb; Tue, 30 Jan 2024 18:39:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYR7EEsAZv+KNtsCi/Qdb1TVs0vjjVqiqeFixLJb+OfXwinsbnn80PI1JtxOQOqXh7aVJq X-Received: by 2002:a17:903:25d6:b0:1d7:39f5:b2d4 with SMTP id jc22-20020a17090325d600b001d739f5b2d4mr372095plb.39.1706668755212; Tue, 30 Jan 2024 18:39:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706668755; cv=pass; d=google.com; s=arc-20160816; b=CbGfxcSxCvwmkymJJB8i8iVmT+b1EQ+N/TXFT2K3F/8huBmvlIVMRnze7TctuUOpIQ mkMgOPa2Dx+7lnl4Cz8la0iGRWJMoq/DNqbnAYwXR4DuxOMsjG7Fif6EVBvm7XJz63Ja 9+8rChwjli7akOCtp/A5/EzvY0PLbJK4eVQLArrNcpcGIIurw1IgfUQ7uECQ4iv1OT9j Ca+PfSNHYrJpd7OT0nzmAv2Xbe3eWYLK8YuPRX6uuuC1/OSBMQxb5RN/piekiehf0sNx Ta+FDvZArY5OpZ14NsQchSoKGCHfLAm3gi7GiL8Mza0UClDB/l7myfEIcmz45c+pbXET Aibg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=/9tYRSBMIMnMvvSOVD7MfaVSkjTIM8AED9anbvp81e0=; fh=WfjQ5kXgVHtf/OdbbLGJ3EDnhIhQ+ftR6n7dGIVKTNs=; b=bY6D3QnlXSOVIICx8K0Ey3sH5gFxKQLIJuvXvgLaxujuwBUQrMPEWHmXgW9eN+xsWU 4Ce67eVfCG7Ctw1QspWAx69Dd0DqWh+aAb+as2sT9bo+3NwdC+VEARLT3T7a4vyNaXnE oKsK7gfyX433z++eovPY+hZSxOJTrAc0IKjLVJgZjRAue58wrqpotT1dApwuIlLZEpnT N8yBykO8yR4OURYAKKU9Ut4jZDuBJLk7kzElNKVqtBX79QAJdgukMgoCjKTO1K5l8qxB pVI47WLuh230oX+Q99HP/bZZkJPLTBZEfdob5r02zESi72XMsNDN0TSPMHeOwvfRF1YO 5ymw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HLurfqV3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-45678-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45678-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXejHoPxzbjAvL3TU/j8L852ckgblltnBPzoYCu9WyPl9oAveBmkREPtKOwOhoxYc9ANfx2da8LxgY7/bpMtpRzeZ6cADMu9NwAegNqUg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h10-20020a170902f54a00b001d4cea91cedsi8633841plf.285.2024.01.30.18.39.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 18:39:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45678-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HLurfqV3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-45678-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45678-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4A6A428D382 for ; Wed, 31 Jan 2024 02:29:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53D697470; Wed, 31 Jan 2024 02:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HLurfqV3" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E21A566B; Wed, 31 Jan 2024 02:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706668160; cv=none; b=IjL156YLHjoonktwONE0asgCrBKA4J1dU5gq03Ml4Gq4ovUAtB9i5T4jRU1z2DK75phL75SXWBHU+J1spHk+5QycSk9KOI65IKW3utT8yHK3bwS0Yc8pZob//tFv1/nhFcbRGCh9a3RAwb5YpBDyLhlP5M5TU332G/lTv310KfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706668160; c=relaxed/simple; bh=910yomUN6JMNLUnTqhPO0ELsf6H1TuwMgNISeOv85TQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TbhrWNTkLcRFgcGXGUuNLvMOibuUev9ZWjhug+GBSRUSo9Li6guKjbuVMgx4Rt8UU7z0vlDxJAogIyNm2OG1DcbxD5q0W7oGrR1VAzVZmyPC42Iw0h/DlImRrAXhs4WhQKCqH0R6S+9oyA9dN3wen3q1MrUPHuEcBliwAoE5Ls4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HLurfqV3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F628C433C7; Wed, 31 Jan 2024 02:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706668159; bh=910yomUN6JMNLUnTqhPO0ELsf6H1TuwMgNISeOv85TQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HLurfqV3AipRAOjQ/059RQFQH/vQgAGmjPNBiIMB7Na59959hxOqppqrYqm4ZS/BA JtD09BAIkJs4QpDrzx4DW5v3MK93BKgRaS4aXNlr4FMNB3GTWpNVgOU1zFITj48lO7 rQClZxN4fYz1zvTVZ3Uc9DpkGHOx6f8jytvpv+CZtptKylgVx7G6pf82VtpF7O9sgE YlhsZLE4v+nPowLxAl0tmRPsvfmPk9KJRSyWusy8KqFOfR5vkvpfzV0qoqTscqbA0J CuqObP3HXjyDDDuTDsX95oSkhtU3v7uRQD9G/39+0srswqjQzIgcBr1Lmny/zD0LOl eO73fcf+Ypg8A== Date: Tue, 30 Jan 2024 18:29:14 -0800 From: Jakub Kicinski To: Shradha Gupta Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Paolo Abeni , Wojciech Drewek , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shradhagupta@microsoft.com, stable@vger.kernel.org Subject: Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed Message-ID: <20240130182914.25df5128@kernel.org> In-Reply-To: <1706599135-12651-1-git-send-email-shradhagupta@linux.microsoft.com> References: <1706599135-12651-1-git-send-email-shradhagupta@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Jan 2024 23:18:55 -0800 Shradha Gupta wrote: > If hv_netvsc driver is removed and reloaded, the NET_DEVICE_REGISTER > handler cannot perform VF register successfully as the register call > is received before netvsc_probe is finished. This is because we > register register_netdevice_notifier() very early(even before > vmbus_driver_register()). > To fix this, we try to register each such matching VF( if it is visible > as a netdevice) at the end of netvsc_probe. > > Cc: stable@vger.kernel.org > Fixes: 85520856466e ("hv_netvsc: Fix race of register_netdevice_notifier and VF register") > Suggested-by: Dexuan Cui > Signed-off-by: Shradha Gupta Does not seem to apply to net/main, please respin