Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1402071rdb; Tue, 30 Jan 2024 18:40:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQNtudZ1atSFvoSQKZLtXmDgaeKlff5hdfiohrvtOUc7flNPZlbKk8tC+dDg6i2q3+sfcS X-Received: by 2002:a9d:6555:0:b0:6e1:3c55:642e with SMTP id q21-20020a9d6555000000b006e13c55642emr270147otl.17.1706668809625; Tue, 30 Jan 2024 18:40:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706668809; cv=pass; d=google.com; s=arc-20160816; b=KZP8THE7zfA43RiJOsM6VPfMevejBnaiBybeKuAI0ADO2+Y/7pWfgGkW81XSSF6rux FjWN0nKWybmVecH5QsPzqUhT88dt35o8GIUlGzL+d0h3zm6trQUk7/lmLGsYbMTYl+oU ebzopMuag/98lCEWC8II8RhxqfiKeG7iBfC5Wb6H8QxJhT03u3x7tLY4nSE5MzenWR57 EGnL0gxNsjazPO0nwYSh4A3uEf7jSDx7mHNiD3OJfKNwfQPUg+Y2PwoxG+dfy/WCrC9Z tlToiCkqGEPEnFo4fTfv0ENonRsIfL4Jnoxn76kQybIwGjzKsryk/YD+D7UKLay58RrJ 1UDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=9rFuCfrepBWXS1XxHQhjTqPjsgtcav0dkeDXr+bSzRE=; fh=qqZlAM5KMkmyZUbwQnNOm6RzlX8RG8xJgxyxmj0rnCs=; b=R4U6+xkIPeoaiMoMtFSmHUzWmTN4JRx66ektrA+3fbs9T6J86DgG5X45BabdUoy4hd DG4uQSoAsvepqQ+BWZX+h6ba3esycuiqUr06PJ5gN88EJ6bEef5ym/zGjM+9dLSll4cy kSbfbkZSUmSRFxtAwkgw19OjEqiL0eOdjzZuv95AGLkvT6TpMm0poPFwwh6xTFLxcdnn PlQLD8ZGUthJSg5zicEbKaNMmNmfk+QLUt77q86LgWakAN9NwJfTCH5Isu29CDgdElVG Pp9W54cYsK5TIkwto8kMlXU9QI2q2d/ybN+CuuXk5zll0el1aTs2w/6ib1IV52ieysRE qZ9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fastly.com header.s=google header.b=D45KeAKf; arc=pass (i=1 spf=pass spfdomain=fastly.com dkim=pass dkdomain=fastly.com dmarc=pass fromdomain=fastly.com); spf=pass (google.com: domain of linux-kernel+bounces-45676-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45676-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fastly.com X-Forwarded-Encrypted: i=1; AJvYcCVOJMdRHZfGQq3AwArye3bIZzaOI0+MiyGBgRi5l3vJ0UeStAYbUCwBVVXNJAkiDF5Iq822BJaHyXi8MXkX68hPkR5MzZok0O2MMkUzcw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g6-20020a636b06000000b005d9135f4514si2104479pgc.450.2024.01.30.18.40.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 18:40:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45676-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@fastly.com header.s=google header.b=D45KeAKf; arc=pass (i=1 spf=pass spfdomain=fastly.com dkim=pass dkdomain=fastly.com dmarc=pass fromdomain=fastly.com); spf=pass (google.com: domain of linux-kernel+bounces-45676-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45676-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fastly.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1119328C174 for ; Wed, 31 Jan 2024 02:28:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC8FB107B2; Wed, 31 Jan 2024 02:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="D45KeAKf" Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9161079B for ; Wed, 31 Jan 2024 02:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706668084; cv=none; b=Q0jpBbOMCk0LOcWWmuCZPdDK82KhE83aNH+9tqBZK5wPtGD38jfP+5ZG832nPrmEGVDkgUTgdiCaAawzjH4BcuCG7v5hUJLF1WD5FyqpZ0CBje7e4z5mFkRcLRfa7/xj4ktY6osPAxQClBR2e2+82Yf+EnAPH0xeHvibN8E10tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706668084; c=relaxed/simple; bh=vL9ewJGQjbVzXzeBAWLNtgJlQ6U/GTAb08cdclhSXDM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rpk1n9doEj4xovzPYmp+nzKSEuc9wUlSKKqdmFUUfk9thsXDyfZ/hzPVvDZKn9XbhW1NkZ4eDRjxlvVBoEaDdudI4nLOlwwSuvKX3ducQMJIywVAk8B/tpHGOIe5kXuoTe3ZCOZac1IWcIQML1Y0mOMsrMyF8z9DC0ma1KDdPiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=D45KeAKf; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5ce6b5e3c4eso2677344a12.2 for ; Tue, 30 Jan 2024 18:28:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1706668082; x=1707272882; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9rFuCfrepBWXS1XxHQhjTqPjsgtcav0dkeDXr+bSzRE=; b=D45KeAKfrJ98hS6d6uV3k+WVmM4ZVpQNftMQ8UcepF49jvwH1RWcNkrkF70O4dYahv tiHKD1xXz15tDg/a3/hFJHqZg6fupSdF77ozGdAgg7jyw+4CnnaIwAwhnoKFcJD5lV8s 9WYG8Z19Df/P+wgLRJ9f7W9xn5w9GX8A3/UvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706668082; x=1707272882; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9rFuCfrepBWXS1XxHQhjTqPjsgtcav0dkeDXr+bSzRE=; b=oG+eVeq+UFOFawt/bMw8OdjUEfurtWpuwb1uix2qzmK3Lj6dQD3ExKcA9HWa1CY5bs ZaLPJKvgSOPmHbuall/scrZk31uvVP4heyiJnWkt8kWRzZiZkf7YbqpJVv2MtdgToYTH BwnEp+DUwE6bYh4qtA1chkz28x5YlE+vHz/voW6wdYSx/Atzv6KeWHSKq9xFmDmiN90d hIjzbEms0bzZvw6uJ/EO3abDzxTV2tPcysbUIdEtfTR8+gOSfiV0oIG9OVWcDJpDi1sK V7FZP+K6W1RjEZnbb2Xi216VcSwhly4apn8KygfCRLA33wF8OOeaxh1+XlQrfviiw3vB 3oCw== X-Gm-Message-State: AOJu0YzEGwDrd3Vapa5fT8ksGJr+pqLr2V2pZg5qWdku6RJXZyNpck+D 6/ojwjE5MmHOixz/YQSWIsuBmLegy0L9MS5OU+8YjacPoZQhVFesb4fmrDy/C8Y= X-Received: by 2002:a05:6a21:9206:b0:19c:7e70:d32d with SMTP id tl6-20020a056a21920600b0019c7e70d32dmr376162pzb.0.1706668081759; Tue, 30 Jan 2024 18:28:01 -0800 (PST) Received: from fastly.com (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id h10-20020a056a00218a00b006dde3053cdasm8574075pfi.133.2024.01.30.18.27.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jan 2024 18:28:01 -0800 (PST) Date: Tue, 30 Jan 2024 18:27:57 -0800 From: Joe Damato To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@aculab.com, arnd@arndb.de, Jonathan Corbet , Alexander Viro , Jan Kara , Michael Ellerman , Nathan Lynch , Thomas Zimmermann , Maik Broemme , Steve French , Julien Panis , Jiri Slaby , Thomas Huth , Andrew Waterman , Albert Ou , Palmer Dabbelt , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v4 3/3] eventpoll: Add epoll ioctl for epoll_params Message-ID: <20240131022756.GA4837@fastly.com> References: <20240131014738.469858-1-jdamato@fastly.com> <20240131014738.469858-4-jdamato@fastly.com> <2024013001-prison-strum-899d@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024013001-prison-strum-899d@gregkh> User-Agent: Mutt/1.5.24 (2015-08-30) On Tue, Jan 30, 2024 at 06:08:36PM -0800, Greg Kroah-Hartman wrote: > On Wed, Jan 31, 2024 at 01:47:33AM +0000, Joe Damato wrote: > > +struct epoll_params { > > + __aligned_u64 busy_poll_usecs; > > + __u16 busy_poll_budget; > > + > > + /* pad the struct to a multiple of 64bits for alignment on all arches */ > > + __u8 __pad[6]; > > You HAVE to check this padding to be sure it is all 0, otherwise it can > never be used in the future for anything. Is there some preferred mechanism for this in the kernel that I should be using or is this as simple as adding a for loop to check each u8 == 0 ? Thanks.