Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757339AbXLSB6W (ORCPT ); Tue, 18 Dec 2007 20:58:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753125AbXLSB6O (ORCPT ); Tue, 18 Dec 2007 20:58:14 -0500 Received: from gateway-1237.mvista.com ([63.81.120.158]:61262 "EHLO gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616AbXLSB6N (ORCPT ); Tue, 18 Dec 2007 20:58:13 -0500 Subject: Re: [PATCH 1/3] ps3: vuart: fix error path locking From: Daniel Walker To: Andrew Morton Cc: Geoff Levand , matthias.kaehlcke@gmail.com, linux-kernel@vger.kernel.org, linux@bohmer.net, linuxppc-dev@ozlabs.org, mingo@elte.hu, kjwinchester@gmail.com In-Reply-To: <20071218171050.5bf220fa.akpm@linux-foundation.org> References: <20071213003028.676998182@mvista.com> <4760922C.2060908@am.sony.com> <20071218171050.5bf220fa.akpm@linux-foundation.org> Content-Type: text/plain Date: Tue, 18 Dec 2007 17:54:48 -0800 Message-Id: <1198029288.2716.25.camel@imap.mvista.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 14 On Tue, 2007-12-18 at 17:10 -0800, Andrew Morton wrote: > is correct. Although not exactly a thing of beauty. This isn't the worst I've seen ;( .. Do you think the ending should fall through instead of having two returns? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/