Received-SPF: pass (google.com: domain of linux-kernel+bounces-45705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0c9d7bab-1da7-4ac5-891a-62e28db8d60a@nvidia.com>
Date: Wed, 31 Jan 2024 08:45:58 +0530
User-Agent: Mozilla Thunderbird
From: Vidya Sagar <vidyas@nvidia.com>
Subject: Re: [PATCH V4] PCI/MSI: Fix MSI hwirq truncation
To: bhelgaas@google.com, rdunlap@infradead.org,
 ilpo.jarvinen@linux.intel.com, tglx@linutronix.de
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 treding@nvidia.com, jonathanh@nvidia.com, sdonthineni@nvidia.com,
 kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20240111052814.713016-1-vidyas@nvidia.com>
 <20240115135649.708536-1-vidyas@nvidia.com>
 <23c5fac1-ebf1-4e5d-9691-7b87060b0df3@nvidia.com>
Content-Language: en-US
In-Reply-To: <23c5fac1-ebf1-4e5d-9691-7b87060b0df3@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R2JMRVF2R2pNejd1RVdnMndmSjNaR3NDVkNpY2ppUm5FMkdtSWozU3hReU9z?=
 =?utf-8?B?OG5LcHVjc3RxakpTZTdNU3Y0dXRvWk9ab21ycEUzUUZvbjk2bmZKd2t6Qi8v?=
 =?utf-8?B?NS9WdnlWWlI0SmthQU1Ea2lMMm1BMnBXekFaVUhHU1BpM3NnblJxY0l3c3o5?=
 =?utf-8?B?Y0V5ZVUwWnZHcUFZbFhBd1luN0NuQk9EWmVNZmdOSWFGTWtVeVNQazlRWFR1?=
 =?utf-8?B?NDBpRUQzd3JMS255NzA2SFA0Q1EzNGJhTmdZcVZGaFg4bVdRbTVsTmU4dmQx?=
 =?utf-8?B?ZVVWb0Z2T2krem1uVEMvUy9aYUs5TnVUZitrMnQ5WWpEbkJkb3RBaXdTQmhY?=
 =?utf-8?B?R0lJVExaakQ3aDgwZjFJSmw2NTFEUWh6UmxGcFBkcjgxT1NreTRzMDYxd3RI?=
 =?utf-8?B?K2xIMlI0cFYxbytUVG85SStPeEhtcVRSWU5hdDJYUk4xOEZ5MkJGRVJkWERx?=
 =?utf-8?B?OSs5RU9EV2Zvejd4WHFPWjJRY2F0ZkR0bDlDc3pDdC90ak5uLzlBUGpxeldF?=
 =?utf-8?B?dXUwemQ2ODN5Uy96L3BJZkRvRUV5cEpBZFRxbm1nSUdTYnkwTGttZU9PeE1J?=
 =?utf-8?B?SXhGUmFKcGkvZkd0SUFNZ0VoZWpKamFIWVplcy9IVUY1a0tqK1dqZGlqK2FX?=
 =?utf-8?B?NEUvNVNSVVlaRHc4R1pIZ2Z1TFU3UGt0SnhyTHR2VFJLTnlLekJYcTRKclE3?=
 =?utf-8?B?WURXS1dFWXQvczg0YThxV2hMYWxsb3lyVko2bDd4ZjM0Q1J5NDdqVjJQZVFj?=
 =?utf-8?B?WTg4ek9rNVQ2M1QyVXE1Qlh1ZTNlQ3E5UGdxVUI3K3dVdCtKeGwzWVBhZ3ZG?=
 =?utf-8?B?YStaUEI1Z25xSDZoSGNsV0QvZXhmcXNwc1U3dHFvT0dwL01ESkMxYTVtNE5n?=
 =?utf-8?B?b2FENXYvY2tnNHM1cWtKYlNUajFsMWZhUkZGOW9SdGovSFdtZ3BWdk1LUWRj?=
 =?utf-8?B?VHk1ZU1SUmhEMzh5RUp3RjBRZk1NTjBsTlhtWWE5NS9CZWNuNUJVM0VJQkxT?=
 =?utf-8?B?WDVjRTdMM2s5ZGNxdHdHa3ZjeTUwQ2w4MTEzVGtzRmQxbUNiVXBSRE8xREFM?=
 =?utf-8?B?RUlEZ2FQVWxBVWlNMVpBRWlpSDNIMm1oMitsMUNZblRvUENLeHNXaktrU2tC?=
 =?utf-8?B?YWxNM093OEhDM1VDZTg4R0U4LzFJN1FWeit5N1d5R0hwdzh6ODIzb3hEVlFx?=
 =?utf-8?B?WmFoRkcwa2daaVovWXJGMzgvMU5aZTc4MGxOYnhNRUNGZS9wT0hQaTdGS0l3?=
 =?utf-8?B?aWRUTDFRVitEVjZldDFjMzA0VmlZMDVIZDMrcVBCS0ZkRjJGUlBOYVRtZ0tI?=
 =?utf-8?B?cGZqMENQOEFLNFRTd3V3TEtuemROb1JmYlFweHo1bFczTmJ1MDFpN284RUMw?=
 =?utf-8?B?MFB1c2pBOEF5NnlhRDI3Z1dVZlFqcEdxS1RSSFI1eldsU244SmhUWU5US20r?=
 =?utf-8?B?WVhCYlB3SFNCcHJXUkxsSEVEQWZaaytVMmdKdkgyRUZXVjN5Q0pFMWR6TUxu?=
 =?utf-8?B?c3hUcXlpVUh0bk92eEpWdHQ0VzQrcnE3TEpmTVVGQ3I1ODM3amN5R09sOExT?=
 =?utf-8?B?VFNKcHpYdVMzeDdBbEVyY1QwcVFCbWtBNWcvV05yU25JcDgwUmFYaENnKzJX?=
 =?utf-8?B?Z1poMThqMG45M0FTZjlJNzFvczYrOU1tRjZRcVdjdmxJM3hLVjU4bzZMbFZG?=
 =?utf-8?B?SHJxOHZFcWhaMzI5Ri8xY2NyRklpRXNlY2RValJidE80M2wwRitodG9UcFdh?=
 =?utf-8?B?UWVaOWQ2aUhMVGxCWEE5dk9IL09qR2FmRE1IWjM0aitwMFhldDVWMENVK0Iv?=
 =?utf-8?B?MnNuL01ObllLM0V1Zm1yNkpuRXptenlpUzZOKzEwZ2cwYmVJSkVrcmlvOTRk?=
 =?utf-8?B?b05YbVQxTGpJdkNNLzhuMzdrbGl6VVcxMjZRbFVBRk1tSDBTRjhjZW42eFc2?=
 =?utf-8?B?Q3R6NFNETlpmczRXelAyalVOQzZlT2oxVzFTQXcxZFdCbUFlSnN6SkhXNHBv?=
 =?utf-8?B?NHB3aUczclVqNlY5MnNLNGx1Rk1UVGZkSE9xa0l4Nk0rZ3RYNWNCK3IwbEo2?=
 =?utf-8?B?Z3ZUWVBCNjhYUGhxOHFPRnVXOTZsWEgwb212czdDZTB1ZkpYLzkxUGQzVHUz?=
 =?utf-8?Q?vf+HNdY90KlcJM5ITdfAGRZcD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea0f5ee2-8f42-46f1-b34e-08dc220af7b8
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 03:16:08.4409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a/rqEIeqJBWirAIokzQRqN8xI8iVcioXib+s2X/E+Yr/Ivj/aNoybf7HzQPaAGQcmWXFOfzDuZPpt3JmuRAH0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6087

Hi Thomas,
Sorry to bother you.
Would you mind giving an Ack to this patch?

Thanks,
Vidya Sagar

On 1/23/2024 9:31 PM, Vidya Sagar wrote:
> Hi Thomas,
> Does this patch look fine to you?
> If yes, would you mind giving an Ack?
> 
> Thanks,
> Vidya Sagar
> 
> On 1/15/2024 7:26 PM, Vidya Sagar wrote:
>> While calculating the hwirq number for an MSI interrupt, the higher
>> bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
>> number gets truncated because of the shifted value casting to return
>> type of pci_domain_nr() which is 'int'. This for example is resulting
>> in same hwirq number for devices 0019:00:00.0 and 0039:00:00.0.
>>
>> So, cast the PCI domain number to 'irq_hw_number_t' before left shifting
>> it to calculate hwirq number. Please note that this fixes the issue only
>> on 64-bit systems and doesn't change the behavior in 32-bit systems i.e.
>> the 32-bit systems continue to have the issue. Since the issue surfaces
>> only if there are too many PCIe controllers in the system which usually
>> is the case in modern server systems and they don't tend to run 32-bit
>> kernels.
>>
>> Fixes: 3878eaefb89a ("PCI/MSI: Enhance core to support hierarchy 
>> irqdomain")
>> Tested-by: Shanker Donthineni <sdonthineni@nvidia.com>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> V4:
>> * Added extra information in the change log about the impact of this 
>> patch
>>    in a 32-bit system as suggested by Thomas
>>
>> V3:
>> * Addressed review comments from Thomas Gleixner
>> * Added Tested-By: Shanker Donthineni <sdonthineni@nvidia.com>
>>
>> V2:
>> * Added Fixes tag
>>
>>   drivers/pci/msi/irqdomain.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
>> index c8be056c248d..cfd84a899c82 100644
>> --- a/drivers/pci/msi/irqdomain.c
>> +++ b/drivers/pci/msi/irqdomain.c
>> @@ -61,7 +61,7 @@ static irq_hw_number_t 
>> pci_msi_domain_calc_hwirq(struct msi_desc *desc)
>>       return (irq_hw_number_t)desc->msi_index |
>>           pci_dev_id(dev) << 11 |
>> -        (pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
>> +        ((irq_hw_number_t)(pci_domain_nr(dev->bus) & 0xFFFFFFFF)) << 27;
>>   }
>>   static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,