Received-SPF: pass (google.com: domain of linux-kernel+bounces-45723-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Subject: Re: [PATCH] LoongArch: KVM: Remove unnecessary CSR register saving
 during enter guest
From: maobibo <maobibo@loongson.cn>
To: Tianrui Zhao <zhaotianrui@loongson.cn>,
 Huacai Chen <chenhuacai@kernel.org>
Cc: kvm@vger.kernel.org, loongarch@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240112035039.833974-1-maobibo@loongson.cn>
Message-ID: <b7c08e0d-bd7d-aea9-250e-1649e95599b7@loongson.cn>
Date: Wed, 31 Jan 2024 11:48:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240112035039.833974-1-maobibo@loongson.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

slightly ping :)

On 2024/1/12 上午11:50, Bibo Mao wrote:
> Some CSR registers like CRMD/PRMD are saved during enter VM mode. However
> they are not restored for actual use, saving for these CSR registers
> can be removed.
> 
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>   arch/loongarch/kvm/switch.S | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/arch/loongarch/kvm/switch.S b/arch/loongarch/kvm/switch.S
> index 0ed9040307b7..905b90de50e8 100644
> --- a/arch/loongarch/kvm/switch.S
> +++ b/arch/loongarch/kvm/switch.S
> @@ -213,12 +213,6 @@ SYM_FUNC_START(kvm_enter_guest)
>   	/* Save host GPRs */
>   	kvm_save_host_gpr a2
>   
> -	/* Save host CRMD, PRMD to stack */
> -	csrrd	a3, LOONGARCH_CSR_CRMD
> -	st.d	a3, a2, PT_CRMD
> -	csrrd	a3, LOONGARCH_CSR_PRMD
> -	st.d	a3, a2, PT_PRMD
> -
>   	addi.d	a2, a1, KVM_VCPU_ARCH
>   	st.d	sp, a2, KVM_ARCH_HSP
>   	st.d	tp, a2, KVM_ARCH_HTP
> 
> base-commit: de927f6c0b07d9e698416c5b287c521b07694cac
>