Received-SPF: pass (google.com: domain of linux-kernel+bounces-45761-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 00:12:24 -0500
From: Gregory Price <gregory.price@memverge.com>
To: Gregory Price <gourry.memverge@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-api@vger.kernel.org, corbet@lwn.net,
	akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, mhocko@kernel.org, ying.huang@intel.com,
	vtavarespetr@micron.com, jgroves@micron.com,
	ravis.opensrc@micron.com, sthanneeru@micron.com,
	emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com,
	hannes@cmpxchg.org, dan.j.williams@intel.com,
	Srinivasulu Thanneeru <sthanneeru.opensrc@micron.com>
Subject: Re: [PATCH v4 3/3] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE
 for weighted interleaving
Message-ID: <ZbnWuB4dRCEFRz2m@memverge.com>
References: <20240130182046.74278-1-gregory.price@memverge.com>
 <20240130182046.74278-4-gregory.price@memverge.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130182046.74278-4-gregory.price@memverge.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HPbAhSkvl212xHi2ccUmrZTOnxxlLdtv/4zn576q1csZf0L/4TbX18f92Sk9?=
 =?us-ascii?Q?TVDgpCgWq6RBP/XMqPODOjNHJbyYbssvKxIhWlvlXGt+zUGJkksDIveSY8Qd?=
 =?us-ascii?Q?+sQJFjqd+idFWcNiWve1Z+E416gTFKV/JlaX0xO2AKXV8CYl/R21Lp+3KdMP?=
 =?us-ascii?Q?h8PKGs0E//CSbXI8OiQb/zZV7sbzzUmKkDQIHnpMmOofgIyRfvZo6D2Tn3uZ?=
 =?us-ascii?Q?xft20U9unyYhMeEP+iB5l6zFD/TFjmCdkmnnnWeC6PniGS3WVu3psnE+ptpc?=
 =?us-ascii?Q?zg5NxQ3QfLPqW2gyHihbyK97M4gxTnQCQOZmLjgs/H7z4izejihcYBip7hZF?=
 =?us-ascii?Q?+EAXYw450ix4r/7WlmXakf2ma65n2bHAHva2/IxJmamCAQz4UVbVDatKpuDX?=
 =?us-ascii?Q?z/JsSFLW+u4G1hq3FHUyGhJBkeNuj/ZpYapKkX36GQmGE4m+UNlw/pUyWvBo?=
 =?us-ascii?Q?w9XKZbyerE0ERrO8UjZ266ufvCkJ5CsybbRO+lDWNr/Gfn8sMKvLYbRdhiDc?=
 =?us-ascii?Q?vRsoHIXW5DbJDg36QgUEbLnUNYSOTULvyr8AN1ssmqo95UKUlvW5rM/KdGQe?=
 =?us-ascii?Q?9qDn6OZzTNHOKaEr1RoN6AGQgBy6tTKIK/tcVtxk/T8MwXymyYAEHkKHLz5V?=
 =?us-ascii?Q?VKZ2deQg/aIY+Lve4h2TY5WuiDxxnr7IHiXl1ecLgU3xeqWXFc2ZDYK8nPFD?=
 =?us-ascii?Q?sKWCivg/uRZ3cdbTz9r6U9s3AV/gKL0QZ6wwxccqNOGwc2kvpd/oaCplDdd6?=
 =?us-ascii?Q?NSNMsZmO8kbL7n3hhqYtDpXY+FcEZc6V3+AAedBSNoU4anw4+rdhBM4/uB5n?=
 =?us-ascii?Q?2zClObbFkvO4e53jVU7G2cwFMt+0eH4MPGTgYzaG7HiGeVyd5vcDWje28BGc?=
 =?us-ascii?Q?xztVrxK2WxgxwC/sOC3XhUAWOlfCfJKyUNxfegmDywlkQG5pq0hXHHbDrtgJ?=
 =?us-ascii?Q?Cf44NbsoB0dy5i0JHXrGHA6QNb6J49aMKMIGPKFj1DbHzPIp6tH/R+g/Hs+8?=
 =?us-ascii?Q?VMKSTBCwm3U+zCDvpkZ3VOdspiMiMcfXBd+YYxEZvSxu35d4D7CSb0jrSc5V?=
 =?us-ascii?Q?7MpZ0Xhu32mn77d/JGKiO1neFcb6njxFBSIezpaj/IByX0ScivPGBAUbvzno?=
 =?us-ascii?Q?A3cJquTA3mCUC3NHTT2fHfnEPSY57Puag/8LLmbeNLzzQd4V45QuiPteTG42?=
 =?us-ascii?Q?kiWc5vgc3mZezOHNRVTDGCevUViVGtYV40dnaE6MvrGKCTT2Q2JlwgwoPlsm?=
 =?us-ascii?Q?2CxJghcdyI/UYvaFx62wE9G4ODc253a/8uLpWrRlwurn2b9GgsSjXfdJeIAk?=
 =?us-ascii?Q?vPbW7b1ASE3U/ir92qeImfk5X2bNli17C16+xZiKnpGImIpK2lyecgxZwkLa?=
 =?us-ascii?Q?SAVx8IymJF+pRKaDTpnYt9wvUvbAWJ934rv+vbJLCP5zEzSlY4hs5hYUVc/E?=
 =?us-ascii?Q?xOE74ALsoTtw7UfksZIHWxI+aAGMZx78HF57Xx0tw8oucS7GW+jOUva7B/OV?=
 =?us-ascii?Q?usPK8tQRzRMY6YrLKmQ3nEVjCaLwTDDLJO6Y0IZqfSf5Mv8VPIX/zBVwU2Hq?=
 =?us-ascii?Q?Ublr2hUJw2KNOhm0l3VL4J7zVrjfZ1Nfq6rhBUAdcSlmFOoNcEsIzwSbG5/T?=
 =?us-ascii?Q?EA=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 300ffd92-869a-4cdb-7f9e-08dc221b38c4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 05:12:29.2807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bMKIXlFUq2MdZNrWoPp+n0uRXYOPtozAPyNnm+haqdluevK5a0rEiPsjLZCEg/36T6XvL1mV9730e0uCHk0JCNDKd/K37fD0mnxUrGgzLSQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB6545

On Tue, Jan 30, 2024 at 01:20:46PM -0500, Gregory Price wrote:
> +	/* Continue allocating from most recent node and adjust the nr_pages */
> +	node = me->il_prev;
> +	weight = me->il_weight;
> +	if (weight && node_isset(node, nodes)) {
> +		node_pages = min(rem_pages, weight);
> +		nr_allocated = __alloc_pages_bulk(gfp, node, NULL, node_pages,
> +						  NULL, page_array);
> +		page_array += nr_allocated;
> +		total_allocated += nr_allocated;
> +		/* if that's all the pages, no need to interleave */
> +		if (rem_pages < weight) {
> +			/* stay on current node, adjust il_weight */
> +			me->il_weight -= rem_pages;
> +			return total_allocated;
> +		} else if (rem_pages == weight) {
> +			/* move to next node / weight */
> +			me->il_prev = next_node_in(node, nodes);
> +			me->il_weight = get_il_weight(next_node);

Sigh, I managed to miss a small update that killed next_node in favor of
operating directly on il_prev. Can you squash this fix into the patch?
Otherwise I can submit a separate patch.

~Gregory


diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 7cd92f4ec0d7..2c1aef8eab70 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -2382,7 +2382,7 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp,
        unsigned int weight_total = 0;
        unsigned long rem_pages = nr_pages;
        nodemask_t nodes;
-       int nnodes, node, next_node;
+       int nnodes, node;
        int resume_node = MAX_NUMNODES - 1;
        u8 resume_weight = 0;
        int prev_node;
@@ -2412,7 +2412,7 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp,
                } else if (rem_pages == weight) {
                        /* move to next node / weight */
                        me->il_prev = next_node_in(node, nodes);
-                       me->il_weight = get_il_weight(next_node);
+                       me->il_weight = get_il_weight(me->il_prev);
                        return total_allocated;
                }
                /* Otherwise we adjust remaining pages, continue from there */