Received-SPF: pass (google.com: domain of linux-kernel+bounces-45763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 31 Jan 2024 05:17:14 +0000
From: Daniel Golle <daniel@makrotopia.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Frank Wunderlich <linux@fw-web.de>,
	Markus Schneider-Pargmann <msp@baylibre.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
	Amit Kucheria <amitk@kernel.org>, stable@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement
 on MT7896
Message-ID: <ZbnX2vfcalNL3yRV@makrotopia.org>
References: <20230907112018.52811-1-linux@fw-web.de>
 <20230913083529.3bgjl6rvfmixgjnd@blmsp>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230913083529.3bgjl6rvfmixgjnd@blmsp>

Hi everyone!

On Wed, Sep 13, 2023 at 10:35:29AM +0200, Markus Schneider-Pargmann wrote:
> On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> > 
> > Reading thermal sensor on mt7986 devices returns invalid temperature:
> > 
> > bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> >  -274000
> > 
> > Fix this by adding missing members in mtk_thermal_data struct which were
> > used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
> > 
> > Cc: stable@vger.kernel.org
> > Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> 
> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>

Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Tested-by: Daniel Golle <daniel@makrotopia.org>

Kind ping to thermal and mediatek maintainers, please merge this patch.

https://patchwork.kernel.org/project/linux-pm/patch/20230907112018.52811-1-linux@fw-web.de/

https://patchwork.kernel.org/project/linux-mediatek/patch/20230907112018.52811-1-linux@fw-web.de/

> 
> Thanks for fixing!
> 
> Best,
> Markus
> 
> > ---
> >  drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> > index 843214d30bd8..967b9a1aead4 100644
> > --- a/drivers/thermal/mediatek/auxadc_thermal.c
> > +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> > @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> >  	.adcpnp = mt7986_adcpnp,
> >  	.sensor_mux_values = mt7986_mux_values,
> >  	.version = MTK_THERMAL_V3,
> > +	.apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> > +	.apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> > +	.apmixed_buffer_ctl_set = BIT(0),
> >  };
> >  
> >  static bool mtk_thermal_temp_is_valid(int temp)
> > -- 
> > 2.34.1
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>