Received-SPF: pass (google.com: domain of linux-kernel+bounces-45764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 30 Jan 2024 21:20:03 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<alsa-devel@alsa-project.org>
CC: <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com>, "Vinod
 Koul" <vkoul@kernel.org>, Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Sanyog Kale
	<sanyog.r.kale@intel.com>
Subject: Re: [PATCH 2/6] soundwire: sysfs: move sdw_slave_dev_attr_group into
 the existing list of groups
Message-ID: <65b9d883538fa_5a9dd2946a@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <2024013025-spoiling-exact-ad20@gregkh>
 <2024013029-afternoon-suitably-cb59@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024013029-afternoon-suitably-cb59@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I3T5wLXSBrInnxUyBT3PvOv4Kc+yrvwjCSCiR2Q/jopwPC4N1j1+CUL/gkzr?=
 =?us-ascii?Q?r95xEMCWdwg+8CLxx60BZrXIlFZg1GOUjy/U2SYYR891uK83KUP6DOEPlK7h?=
 =?us-ascii?Q?ikSQD4Dz8LvkB5JfNOtGUOoPxBTATcjiN+/HfffVEjOZ6D+xjCJbpg/OjiNX?=
 =?us-ascii?Q?9Xg1SI9eIDIu5Pslj66SFILfo/i5Jd1XEdd9Af7TGwMT+dpcNQuBuN9Y/OwV?=
 =?us-ascii?Q?NBvcGtz+rYtO/DKmEL0sygsUTeOoMUkNwFlaiODgrTswxO0tB0/Bvs/yoCjm?=
 =?us-ascii?Q?5ShEJNZGOcD5tgUGQrv6quD74cfPn2MIIo0nHXx/Xqjjl2mVIn5D4vIw2Ewg?=
 =?us-ascii?Q?EGP+orlaWPkyDt2wT8cv3ksVncMYiI/2v7e5SKg9cB13JXnfhT58AK4I7AfR?=
 =?us-ascii?Q?NZZovR2b4NxqKZMAdp1oHdaKU1hMmz55SDeHb0UZARn4gjP5rahCZrqT1+1i?=
 =?us-ascii?Q?pLeEzWh/vf9tHAlfnaCckM2gxWcM0VBBXj8f/CNiKCVZ4Qka9v6iGTcDVHGF?=
 =?us-ascii?Q?1uPnNF/5dU3fGZkwNkHh7thxZqpeBv8MCyBqD18mqf8eWa8aOEjcAGwFdbhB?=
 =?us-ascii?Q?wwPj3Mv+YFUNAOiU7nx+RCqvFYh26eYtiawpEej/j80p0LQXt20wotrQMLDs?=
 =?us-ascii?Q?X2vwcR0+8oxnPFKEbg1LauTSyokIUSEZgrJG6JKbkGhJKPsE/98u2nmIbIXb?=
 =?us-ascii?Q?kulRtc7kkwHR+hZKrk1udHQQo0hGOrHV9C0ICGvmQWdxy5Y28r/W/OsFl9FR?=
 =?us-ascii?Q?g1tsRCXkZX/mtNB5vJX2RYDpDQQcrbWB8k9YS0QHJivqFIZRfvA+n5cDBda5?=
 =?us-ascii?Q?KEb7s/6piqrTrLSshI72oGeNsnSVJ1dAAXHJlnz8hr5qRbh6nEd1ysjkzG+K?=
 =?us-ascii?Q?vEDy+PYGqX3FCWwHlX6Z6mNGgyKhqAjI+YmzBP3K7qUBkljJYCXfn5hqyNyu?=
 =?us-ascii?Q?DKo7KFRrQsfY/CCNyL9PkY2kx409c97TflQ29Ovd9Qw+oMb8V5aHK7juarXr?=
 =?us-ascii?Q?bfoy6sf0GP3JRKOTpOaB1pLhhW4hmIKupsb0OAGJvs5t3DUuYsJ93uDqiCO8?=
 =?us-ascii?Q?eBXMsvfZMJv0gjWhAIqTGxUwnIRryGDKfgxuyQB/Ju+vMOoMdCWwd2EQMAnC?=
 =?us-ascii?Q?HozYaOqwhRyAPrJjZoN2YW6leVDUkZRwBAlJO+7QDJtghizH5I8adGsvl6aJ?=
 =?us-ascii?Q?WEoIv+NlgQGX54tNfN/cB2jetYAy22fuv0wqlgFeWopV/usZ+fHVUwui4lxp?=
 =?us-ascii?Q?ZEbKsHX41WBI9Jp6H+OQxuovz7/idditq4XVxNvscwthUhVDf8cPxJgr7Bce?=
 =?us-ascii?Q?PId0VVlHu4/owCGhMAd1eBHHWcVTiXC3asRtlEp5/WvvBxyDSnhGItggIYSf?=
 =?us-ascii?Q?aewvc0KaqKGU+Dg9eF8OVxpvxt3Ybv5lbZJppuur+ZlRDRkhp+TxgWiVPTFO?=
 =?us-ascii?Q?m/GVhKyMV4qaQhqBKn9gH34PaKoSHaZMLpRfkw8CiQInOnW5apSJe/2zYpsy?=
 =?us-ascii?Q?Nzx5MmF/Jkq8YDNfZvkxtL7WRXVWE5frW6ohmWxv/CYVCqHDL417bg6EScCC?=
 =?us-ascii?Q?UrAPELM+eMA8XQLGk1jFNeaUdq3AiyNG/f1gCRqF2BltuU2xytvm2LkmUYq3?=
 =?us-ascii?Q?Pw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f0966d8-8ea1-4699-d71f-08dc221c48db
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 05:20:05.8090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eRHNbn12212QdRTsNMVL585JSZrlbIVZKxeI7JU6qbQZsOd8UbCOCDiprA8NXgUfVvLxuLyre6GT6iFz8lPBUy2MZVnRwgH73X4j2t52rH8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4686
X-OriginatorOrg: intel.com

Greg Kroah-Hartman wrote:
> The sysfs logic already creates a list of groups for the device, so add
> the sdw_slave_dev_attr_group group to that list instead of having to do
> a two-step process of adding a group list and then an individual group.
> 
> This is a step on the way to moving all of the sysfs attribute handling
> into the default driver core attribute group logic so that the soundwire
> core does not have to do any of it manually.
> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/soundwire/sysfs_slave.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c
> index 3210359cd944..83e3f6cc3250 100644
> --- a/drivers/soundwire/sysfs_slave.c
> +++ b/drivers/soundwire/sysfs_slave.c
> @@ -105,7 +105,10 @@ static struct attribute *slave_attrs[] = {
>  	&dev_attr_modalias.attr,
>  	NULL,
>  };
> -ATTRIBUTE_GROUPS(slave);
> +
> +static const struct attribute_group slave_attr_group = {
> +	.attrs = slave_attrs,
> +};
>  
>  static struct attribute *slave_dev_attrs[] = {
>  	&dev_attr_mipi_revision.attr,
> @@ -190,6 +193,12 @@ static const struct attribute_group dp0_group = {
>  	.name = "dp0",
>  };
>  
> +static const struct attribute_group *slave_groups[] = {
> +	&slave_attr_group,
> +	&sdw_slave_dev_attr_group,
> +	NULL,
> +};
> +
>  int sdw_slave_sysfs_init(struct sdw_slave *slave)
>  {
>  	int ret;
> @@ -198,10 +207,6 @@ int sdw_slave_sysfs_init(struct sdw_slave *slave)
>  	if (ret < 0)
>  		return ret;
>  
> -	ret = devm_device_add_group(&slave->dev, &sdw_slave_dev_attr_group);
> -	if (ret < 0)
> -		return ret;
> -

Yeah, open-coding the groups, much better than dynamically adding one.

>  	if (slave->prop.dp0_prop) {
>  		ret = devm_device_add_group(&slave->dev, &dp0_group);
>  		if (ret < 0)

Makes sense. I won't say "looks good" as this file has "slave" all over
the place, but I checked and it entered the kernel just before the
CodingStyle changed.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>