Received-SPF: pass (google.com: domain of linux-kernel+bounces-45773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Jan 2024 21:32:03 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<alsa-devel@alsa-project.org>
CC: <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com>, "Vinod
 Koul" <vkoul@kernel.org>, Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Sanyog Kale
	<sanyog.r.kale@intel.com>
Subject: Re: [PATCH 3/6] soundwire: sysfs: cleanup the logic for creating the
 dp0 sysfs attributes
Message-ID: <65b9db5375de2_5a9dd29443@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <2024013025-spoiling-exact-ad20@gregkh>
 <2024013029-budget-mulled-5b34@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024013029-budget-mulled-5b34@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kifTlPeoXPgoF3s2ENFyo9/+S/Lk1jCmFpPVWUl4ZRHtHjOs6GeA7fYe6Qp2?=
 =?us-ascii?Q?jlKzvDcxIneHahy/SmCHntzs4aYI3aYm7/PbFqyJt7qSVknmnWToM0J9DQxM?=
 =?us-ascii?Q?OQM2RBIe0DW3qfwJjy1cOCDL8fs+rOgoKDmIe2sUlBgmynTosJDNVCGBcS0Q?=
 =?us-ascii?Q?uM5mvGIn7KZlUoHCnqsAUi2hQ77Sg1eW8aNRS2czkPsmMGC8Tt9NmoCR8PgO?=
 =?us-ascii?Q?jDQ8KhITKH2Nqvt+3LmPeJFBmq9HOYfqrBc7m/JyTFdvuL2UjMDd0dORe2ae?=
 =?us-ascii?Q?VOSB15RbKAeTDihxESfboOExXb+v8D0PYihFIlUeIm4+DgCWDb6mohVKWIqN?=
 =?us-ascii?Q?CCVAf588Ry34uao0eQnQWp4OyQu6+1XfDmTC2n/dfdudAU2tVXI8+kZWQbBG?=
 =?us-ascii?Q?9/tLGcVjjlSN+aErLrW11A9Yuy+bccnBSFqd91whPTSGfUwwaFUo2H9H0y/O?=
 =?us-ascii?Q?5LB9s4k9lKHn0v0EwiscVhupJTmXL7f1i19d/jW3ZhogRJj0/wh+kuJaKdyj?=
 =?us-ascii?Q?uH4z5aodA6i9XIVJN/58l6gVHuMbL9Ck79Gtb7eRK9dZXXcEJTjZvwEl6sm0?=
 =?us-ascii?Q?tkXckj4b5eUaxtVKTanP3pnneZENCAUZ+YptLahG1zDBHHB5isp99fG0BFr6?=
 =?us-ascii?Q?VMKANXDR/m+hiQqxo2kjvkve0SNrNOReExkYwO6yxYl025j3VwEfFnleW7KC?=
 =?us-ascii?Q?GPMje9Mq7AU8r4GrE3gTd1a2UVh3BmC/KmYLZXAeIup1dNkBOVM4s58zLI8A?=
 =?us-ascii?Q?cxS2ZQcwKE5sArFfOLccx4AoAT6qQ3q0ZvgeJ4XxQiknJ7g1VRTRY5LXXjKF?=
 =?us-ascii?Q?slmR6rcp1LsbAeN6qYwnprvFhjoOS+2jvjFDg12KEpTmbJTTiXesP1fJ39Hw?=
 =?us-ascii?Q?UE1zzGdDWqbJ9b8i4i3BAQF49EBD3YGGJYXlnqghHpuVTOo2huPatwqjgGnn?=
 =?us-ascii?Q?tfJKiERRHcvyvuzk3W6I+7nceLre9P8ZC8olgV0p9IJPdldPQ3yaT9KGMoC8?=
 =?us-ascii?Q?d1piO0inDb3vIlqmcpfOVE3pk7VpMLLIUYbHgaIedSuz3tyyeNoFvMY9cou8?=
 =?us-ascii?Q?uKhq/uafFq6t1sbNiXAs2UeMDcMIBBbCfdKe2eowMM2UDEInROyZ2Yvv0hN3?=
 =?us-ascii?Q?VeLVIqp1Vpf8xhcfgMIGzNzKCYcnIev+7hBvSq1kbNXP/8uW/1VIm3ij5UKx?=
 =?us-ascii?Q?W/f9v6naT5QG5Hz2rr6jMoMHJlTRV/hpKt+Q9OLZmt1p8zweR9nsDC726/Ox?=
 =?us-ascii?Q?+UghUbRssbxiVIYR8nBPz1nQfZMeu4Dm01xwOXprYyFruf0sdtNmx/W9x8e+?=
 =?us-ascii?Q?jglzFe2tQgto6PHNqRA7kPNiAn6vP2CH/Btk0EriF2twlK7MnSjA3Is+txqI?=
 =?us-ascii?Q?5JzBEA3FlaGsZ9MMTcRtjuWG4VLB+e9XwiysSfjuMmDmD2LH170GuB29ByNm?=
 =?us-ascii?Q?4zE7Xd0iHLTglsvDz8qZZ+pvkH7W52psVlWsnBVq0Z7pdhPdEpOJKKXCXDnY?=
 =?us-ascii?Q?cWWXEx+uFV/G2QQWKVPHl1+q2SVl9fcBdKDozSWMWo5o3umGMJ0EWx47uIdd?=
 =?us-ascii?Q?Ol/OdSi4MdZwAR9Wdakm4T7BcglAAKvfNhd3sQSByd4z74idso/19SrdIxi6?=
 =?us-ascii?Q?pA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 858ba8b2-9116-46e3-2235-08dc221df611
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 05:32:05.8527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UoDGehje/tORBuzeWNtq9gVYYBX4kOJ7VdzJRaF/T9fEFqpsis9TpdTP7KuC11ymOrVrP917Ubug8y/5YzxB7zNOlj2YPubuG3GQCdT5rGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4894
X-OriginatorOrg: intel.com

Greg Kroah-Hartman wrote:
> There's no need to special-case the dp0 sysfs attributes, the
> is_visible() callback in the attribute group can handle that for us, so
> add that and add it to the attribute group list making the logic simpler
> overall.
> 
> This is a step on the way to moving all of the sysfs attribute handling
> into the default driver core attribute group logic so that the soundwire
> core does not have to do any of it manually.
> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/soundwire/sysfs_slave.c | 28 ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c
> index 83e3f6cc3250..8876c7807048 100644
> --- a/drivers/soundwire/sysfs_slave.c
> +++ b/drivers/soundwire/sysfs_slave.c
> @@ -184,18 +184,40 @@ static struct attribute *dp0_attrs[] = {
>  	NULL,
>  };
>  
> +static umode_t dp0_attr_visible(struct kobject *kobj, struct attribute *attr,
> +			      int n)
> +{
> +	struct sdw_slave *slave = dev_to_sdw_dev(kobj_to_dev(kobj));
> +
> +	if (slave->prop.dp0_prop)
> +		return attr->mode;
> +	return 0;
> +}
> +
> +static bool dp0_group_visible(struct kobject *kobj)
> +{
> +	struct sdw_slave *slave = dev_to_sdw_dev(kobj_to_dev(kobj));
> +
> +	if (slave->prop.dp0_prop)
> +		return true;
> +	return false;
> +}
> +DEFINE_SYSFS_GROUP_VISIBLE(dp0);

What do you think of the following for cases like these where
attr_visible is trivially derivable from group_visible?

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index a42642b277dd..203d2e7e9a1e 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -117,6 +117,15 @@ struct attribute_group {
                return name##_attr_visible(kobj, attr, n);           \
        }
 
+#define DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(name)                      \
+       static inline umode_t sysfs_group_visible_##name(            \
+               struct kobject *kobj, struct attribute *a, int n) \
+       {                                                            \
+               if (n == 0 && !name##_group_visible(kobj))           \
+                       return SYSFS_GROUP_INVISIBLE;                \
+               return a->mode;                                      \
+       }
+
 /*
  * Same as DEFINE_SYSFS_GROUP_VISIBLE, but for groups with only binary
  * attributes

..i.e. don't require $prefix_attr_visible() to be defined?

With or without that:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>