Received-SPF: pass (google.com: domain of linux-kernel+bounces-45779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Jan 2024 21:41:49 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<alsa-devel@alsa-project.org>
CC: <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com>, "Vinod
 Koul" <vkoul@kernel.org>, Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Sanyog Kale
	<sanyog.r.kale@intel.com>
Subject: Re: [PATCH 6/6] soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS()
 comments
Message-ID: <65b9dd9d80163_5a9dd2944d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <2024013025-spoiling-exact-ad20@gregkh>
 <2024013031-tranquil-matador-a554@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024013031-tranquil-matador-a554@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2S1I6piryy7UPNOJtZrcTvpn/fFHBlgQzexKbmejUX96+I7nfx12LeqLI0gf?=
 =?us-ascii?Q?NSiFroVDr+ULg7fuVq6uTwiDfcs0nGj9GeFlVvAHuaIAC7tv17J/k6vfozSK?=
 =?us-ascii?Q?qylfxzRIO4yGF59gciCHaPIptMGLxqUv96lacrxI+TzKl5C+2fHJk5J74doU?=
 =?us-ascii?Q?3Qc52KFHgndkBtPmdeiM2yl/vCeqk0asPAj/OL0SkRXjJnq1gXcYQ6gMhBhm?=
 =?us-ascii?Q?DHy/N2lHi62+llgdLY4o8BAFFMD2eON65odlIjgX4aEk0peJorrgDO08+z/K?=
 =?us-ascii?Q?7GLOJVCGMySSvA5FnlKIULO7DZedaUhXtjp1NjbmG3QMBh8LtP5NSHlI7PJN?=
 =?us-ascii?Q?Z7aEfuGsO5nHpk5NMIuGKkJ3bJf+0iMUp5/gdzva5vI+SE0RKO/TcksxkhhQ?=
 =?us-ascii?Q?hB0BkQakg6kKSh6HB70B17ZLABG5/KcQxHvuBG2lhy0RsHf6vpmn0rn3hgVD?=
 =?us-ascii?Q?G9gEnIRI6dJuY+nNfg2WrvevBXigEqlGfq6SyXJMn37F1QywFAkcPrBHAjuM?=
 =?us-ascii?Q?ix0FJtgkodmB0v0+2euzUVAfCX/NJxMHQ0252+6+Sa1YQS3UBP0ZW+DK0ZAs?=
 =?us-ascii?Q?bDLnYLArcaQrCi+fyzERH6Xy2NFK9rp8eZEmXxks8TC3XAOlu8/sZ1wmF8x2?=
 =?us-ascii?Q?FSyUJVmliq0D46EBL9QqKHu3fa00zF+rWu3PcLZv4Lf6y8DVv1e2ZX+PvOwK?=
 =?us-ascii?Q?vySbtnFQs7hgQNzdQhpk8+yB4xC3SbZUODBP2RvcrnSn9YtuBUtqkjoOCGbO?=
 =?us-ascii?Q?PP0dy+NDy/TRxQrpMh98X/i6GkPIL+6U2Hvx3cM3KXaVzjAICmUgSFCi3pSN?=
 =?us-ascii?Q?yHKBQVK2+BZiaMpiGlqFfflSu2WM8fiQld4nk2dZLluzFqnEvWfDJkjw0tvn?=
 =?us-ascii?Q?iiFrGo+adCR0lwUePhkM+8DdrusJlX/uJK9MfIzjuQ+loHlRlGJsCnCz4cnb?=
 =?us-ascii?Q?Sdq91EmFowjRnhtzs7/IKs4B1JIHyJ2mMZMk7IiFrmByGGy+OOIxEzPKJwCG?=
 =?us-ascii?Q?IlWL/MlVI8ECSU6185yPVOWlkqWrvMSL35gUTjU8koreuZyjtRtmXUyPFnyO?=
 =?us-ascii?Q?YAEwakunI/Cw5sDgXwnljW8mxegqmpRs+O5Ii3Rd6x4xF5IqghQ5Me95OzxX?=
 =?us-ascii?Q?3ATJFvDU7mmVMmwH71f3cp14spj5UZtthMNJ3DSthfMPvS7s5ex2BeEhk+Qk?=
 =?us-ascii?Q?mbrdAv+KK92N122paJDnu4TTv2UjYlmm59G1S0B+R8zin052GHi1ysKrjRrW?=
 =?us-ascii?Q?A6ECUO+0C+Azk52NGHqCgAprBmruW+2B0ite5GGYJSYC1EgH9D3Y95aWrwE9?=
 =?us-ascii?Q?ALV5jDI3tHHrnO1D4znGRbxnYOr2sb7WSOK8hn2zCf8ulmDVPgd0bGwC267S?=
 =?us-ascii?Q?8ePq9tZaGmU+ztr4oP7m/F0tzlYccP5ls9axlh0nFC3X51S22nA0P2RbZ8lV?=
 =?us-ascii?Q?3tuLNlCpv+vW+ZWNG4rwuTFI1jwdgzPpCxVT10hmabNb+FHPSuuT5s9efCzS?=
 =?us-ascii?Q?p7+IDcGou5BiUn0yXw7vcXsGtHsMS3Aja6atklQK0x5LJ/vf3eE/hArVIUfL?=
 =?us-ascii?Q?5xE0CkGsZwLlHxFm2pEsIqPIQe1rYmLj/1GfaHbtglj+OsYtZXMoRLk8DMfm?=
 =?us-ascii?Q?5g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a58e77ac-86b0-4f91-11f1-08dc221f5350
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 05:41:51.7731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i5rXqL6EwbZiLwOlfYBjzwlXgFgg72IIhC98usBL4I3zvRzuWcj1c9G1X/sZbfq2f0UwuxTcDpVDN63TpdNimx5IHyyiUjowPUVgtUnBBNE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5358
X-OriginatorOrg: intel.com

Greg Kroah-Hartman wrote:
> Now that we manually created our own attribute group list, the outdated
> ATTRIBUTE_GROUPS() comments can be removed as they are not needed at
> all.
> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/soundwire/sysfs_slave.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/soundwire/sysfs_slave.c b/drivers/soundwire/sysfs_slave.c
> index 0eefc205f697..f4259710dd0f 100644
> --- a/drivers/soundwire/sysfs_slave.c
> +++ b/drivers/soundwire/sysfs_slave.c
> @@ -129,10 +129,6 @@ static struct attribute *slave_dev_attrs[] = {
>  	NULL,
>  };
>  
> -/*
> - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory
> - * for device-level properties
> - */
>  static const struct attribute_group sdw_slave_dev_attr_group = {
>  	.attrs	= slave_dev_attrs,
>  	.name = "dev-properties",
> @@ -204,10 +200,6 @@ static bool dp0_group_visible(struct kobject *kobj)
>  }
>  DEFINE_SYSFS_GROUP_VISIBLE(dp0);
>  
> -/*
> - * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory
> - * for dp0-level properties
> - */
>  static const struct attribute_group dp0_group = {
>  	.attrs = dp0_attrs,
>  	.is_visible = SYSFS_GROUP_VISIBLE(dp0),

Not a great look when there are comments around avoiding common idioms.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>