Received-SPF: pass (google.com: domain of linux-kernel+bounces-45803-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 30 Jan 2024 22:02:33 -0800
From: Kees Cook <keescook@chromium.org>
To: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Marco Elver <elver@google.com>, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: Add UBSAN section
Message-ID: <202401302201.E6D71CF@keescook>
References: <20240130234634.work.003-kees@kernel.org>
 <CA+fCnZeDWQsd8xJdDhZbZBuyUaS6_WkFgZo5B4Pfjtkom_w1QQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+fCnZeDWQsd8xJdDhZbZBuyUaS6_WkFgZo5B4Pfjtkom_w1QQ@mail.gmail.com>

On Wed, Jan 31, 2024 at 02:41:16AM +0100, Andrey Konovalov wrote:
> On Wed, Jan 31, 2024 at 12:46 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > The kernel hardening efforts have continued to depend more and more
> > heavily on UBSAN, so make an actual MAINTAINERS entry for it.
> >
> > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
> > Cc: Marco Elver <elver@google.com>
> > Cc: Andrey Konovalov <andreyknvl@gmail.com>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> > Hi! I figured since I've been carrying UBSAN changes more and more lately,
> > I would just make an actual entry in MAINTAINERS. Are you all interested
> > in being listed as reviewers? Or would you want to be M: instead?
> > ---
> >  MAINTAINERS | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 8d1052fa6a69..19b8802b2f12 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22471,6 +22471,22 @@ F:     Documentation/block/ublk.rst
> >  F:     drivers/block/ublk_drv.c
> >  F:     include/uapi/linux/ublk_cmd.h
> >
> > +UBSAN
> > +M:     Kees Cook <keescook@chromium.org>
> > +R:     Andrey Ryabinin <ryabinin.a.a@gmail.com>
> > +R:     Marco Elver <elver@google.com>
> > +R:     Andrey Konovalov <andreyknvl@gmail.com>
> > +L:     linux-hardening@vger.kernel.org
> > +S:     Supported
> > +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening
> > +F:     Documentation/dev-tools/ubsan.rst
> > +F:     include/linux/ubsan.h
> > +F:     lib/Kconfig.ubsan
> > +F:     lib/test_ubsan.c
> > +F:     lib/ubsan.c
> > +F:     scripts/Makefile.ubsan
> > +K:     \bARCH_HAS_UBSAN\b
> > +
> >  UCLINUX (M68KNOMMU AND COLDFIRE)
> >  M:     Greg Ungerer <gerg@linux-m68k.org>
> >  L:     linux-m68k@lists.linux-m68k.org
> > --
> > 2.34.1
> >
> 
> Hi Kees,
> 
> Perhaps, it also makes sense to add the kasan-dev@googlegroups.com
> list. It's used for all other Sanitizers.

Okay, sure, I can add that. If it gets too noisy, we can always remove
it. :)

> 
> Otherwise, looks good to me:
> 
> Acked-by: Andrey Konovalov <andreyknvl@gmail.com>

Thanks!

-- 
Kees Cook