Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1466498rdb; Tue, 30 Jan 2024 22:04:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEf4ydAqB+mfhIDJFxGSvomntVMryfIHOjr6nfzPItqZFFqgg6jxW1zlAtDeE01LlbChzed X-Received: by 2002:a05:6870:ab13:b0:206:d28:c65f with SMTP id gu19-20020a056870ab1300b002060d28c65fmr717308oab.48.1706681059839; Tue, 30 Jan 2024 22:04:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706681059; cv=pass; d=google.com; s=arc-20160816; b=ThwhtHO6/KS2jz3YFPDYwC1zVXHNi33Ef/Mrf6Tdoi/fnWD+cXHGgeJ0fOmt8LZfX9 G4XPJlyLatmdbXVLW9E/Lu21qVXYBdGYzQxDRfiTvb1VNmdAgSqAdITjGx5qQQFyl5uv DjIvczPvw0966I9ztRImWXGb+fpvPJquZy2Q737oCdochBi3MEzn8NWNy2fRPz6AUHti meM1BaErnN/fW5DYfHRBuObTgdsQN9Rb7elSDdBofz55dLAyMohfWZaYpUgLlgU02UTh ZZTOHqAPuq4rEPwlXy02QBamSupkql5iDIYE+E5armeuMcn57WOu6jsR4vGdeSDxBC4D 1pXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=xdrR+Vdg74mVBKqW0NsH64EGTQpOxZxIT7WHoKcXIB0=; fh=byggX+m94F5yPffVBNWSkgXEvIOM9Le/BD3YMxePpJs=; b=lkJd68zA58o/y/gbL8E2XpynzWKh5zj88IhkeWmHFzP7wSy3n79HTmlu7FGgwYvMPi wyBsVElDHhO6rlXMNW7SeAj1ll95ECj5+qRvofkz//XFOic4mDAqNB9Yuz6/8ktwBul5 h3CkRaWG5wnZ0vjHI6F2Ds5i4lxEPKKS9i/IyUdVJbsBFYVbwrX5tLX19CWRxVejmi5G 9Ot5VrenpukvcmD2meTaycXp9Zgz6KfpUcRuUDXhQ16n3Two3Bd9/VKyttxqlFNdd84N X40T7INzxTfYgaIr2ascJbvTTvKg5TbzCaCj4uK0BIHY/nMZdc2b6Id83cLy8KRaqgdZ IVMQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-45804-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45804-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCW2Lpl7Ka06lbaN8y38RkIMBNHxr+Lp2LRxESYfJ6z39yY0m7xs4qrVrmgwhHtSTIECLBlkIkXDhRXlLO+r9WRo1bUOdibYjCCdjOKOnw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b37-20020a630c25000000b005d3adb65694si8624886pgl.757.2024.01.30.22.04.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 22:04:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45804-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-45804-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45804-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 436F8283DDE for ; Wed, 31 Jan 2024 06:04:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DCD813E49C; Wed, 31 Jan 2024 06:04:01 +0000 (UTC) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90353F8C7; Wed, 31 Jan 2024 06:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706681041; cv=none; b=F+jloUVdOn17sEjfsiL/Kc3Da33waUwmN94qq92SnekwFS6TmRHFN+9i8i4lHxl5Eq0y8iQ4XAchEgdINqFJDp2RGfeapb0oyFVG2b75OqmybBNnXqo/PxXj+rWNfEQeU3A3xDvjrFAyJOjTc1Be4mPrNS7GttKoESmP/85lAzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706681041; c=relaxed/simple; bh=RMyiWHBrBchyj1m/GVv0+cXHWz3xTX5F69i+CDc+6Ko=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lhzalFsnIqKrITnBK7W2ioUR7rZxl7VjvnYb/aXoi/n/rnARAn7kVMFGvJfswCdPiE2ptJAyWweH3EeLacDv6VbzYIEvatubLqPzGOre35g1mxMakNcwy9a2rvqCO1YRVM6IobZqb+GbK4JbfPu9ZYZoyX+4BbUrfd01WHe5hRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-51124c0965aso438033e87.0; Tue, 30 Jan 2024 22:03:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706681038; x=1707285838; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xdrR+Vdg74mVBKqW0NsH64EGTQpOxZxIT7WHoKcXIB0=; b=QUtz/Z0QtV+nKllBoUfFLRz0KorOpp+tZHfKUI15OuY46lU/Q7X/wD5uUqx9xewtNH notMq2IxsM1Rpt25RI8hpoFljwVrBiFVLnKsV/79vVq0JWXtutnHHdqs5XJyaFMg7nRl ksWa1jHNuZRus+9qygMOw5PFou3iOH9D44b8x0T5Q3rRRVHGJZvbBLTnZGEN/3aX7iW1 g8wgK4goEjdg1kSEvjyd0VVQZuq8sF5O56bX89MhO3dnOFg4fmz4qHIHUQz4H8AEP1lQ oSbgUmeZ1oeGsQaZ5D/Bb3/0sCkYZB7gfOmMA7nt3xdSQRMnuqiTFyUCAW88d0WLafDS PuXA== X-Gm-Message-State: AOJu0YxEYW3AxnAEzToquVqiNOFDWTMxlD5vlGtYChhZmDOTOUdG4N3B hRehAmOYwwv8mGwdGLj7icenlH+Sy+J2B0zxKMjou0Eij8xWSwf3 X-Received: by 2002:a19:6757:0:b0:50e:ca86:658a with SMTP id e23-20020a196757000000b0050eca86658amr619332lfj.45.1706681037411; Tue, 30 Jan 2024 22:03:57 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id p18-20020adfcc92000000b0033ae5f0f30dsm9761606wrj.2.2024.01.30.22.03.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 22:03:56 -0800 (PST) Message-ID: Date: Wed, 31 Jan 2024 07:03:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 3/3] eventpoll: Add epoll ioctl for epoll_params Content-Language: en-US To: Joe Damato , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@aculab.com, arnd@arndb.de, Jonathan Corbet , Alexander Viro , Jan Kara , Michael Ellerman , Nathan Lynch , Thomas Zimmermann , Maik Broemme , Steve French , Julien Panis , Thomas Huth , Andrew Waterman , Albert Ou , Palmer Dabbelt , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" References: <20240131014738.469858-1-jdamato@fastly.com> <20240131014738.469858-4-jdamato@fastly.com> <2024013001-prison-strum-899d@gregkh> <20240131022756.GA4837@fastly.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20240131022756.GA4837@fastly.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31. 01. 24, 3:27, Joe Damato wrote: > On Tue, Jan 30, 2024 at 06:08:36PM -0800, Greg Kroah-Hartman wrote: >> On Wed, Jan 31, 2024 at 01:47:33AM +0000, Joe Damato wrote: >>> +struct epoll_params { >>> + __aligned_u64 busy_poll_usecs; >>> + __u16 busy_poll_budget; >>> + >>> + /* pad the struct to a multiple of 64bits for alignment on all arches */ >>> + __u8 __pad[6]; >> >> You HAVE to check this padding to be sure it is all 0, otherwise it can >> never be used in the future for anything. > > Is there some preferred mechanism for this in the kernel that I should be > using or is this as simple as adding a for loop to check each u8 == 0 ? You are likely looking for memchr_inv(). -- js suse labs