Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1468558rdb; Tue, 30 Jan 2024 22:10:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtu4ZmwkIT3hNl+soF1RSXx9xIg1EBChuirU5gY8HMMpMImj7XmWasiD+reCyBuZYrb9o0 X-Received: by 2002:a2e:9d0c:0:b0:2cf:4f79:9b4e with SMTP id t12-20020a2e9d0c000000b002cf4f799b4emr391559lji.41.1706681413177; Tue, 30 Jan 2024 22:10:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706681413; cv=pass; d=google.com; s=arc-20160816; b=bSUb1+SSpZF7WEK7GtIfJtpcYyy4sqhGZxZFyMxvPJX4jnzg9chn+164c1k5zUd7Tw jd6euyVLjVhdWCbSZszsU6GAB1ahsRDzDGahw8z5JDJD5qMK4MH0EhrFx6AkmuozkOwG +Hv3C2NlLREY3EcLU3I1xt7U/z3dxWQNzclrGr6wAAcTAE0BatHwfs4hZaRS6e7lG0Dw 1eUtsnd/ZvV1H4lOZvmI9nZvW5xTKpzq7VnjBiIlHFeGwsn79I7+8PbdAGKBwV6DdNYK Nx7OM3t3hZY8psAzlfmEctKVvQGYFFezU7IaguWmahojtbG3hJnMz2gz6u/Irb7AuZZg rIJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature:dkim-filter; bh=yg+VJO0K+0/jLaTvRKDfXImeE8FTSu6c4RAr38E++AI=; fh=Ncv6wHXbSHM6mBUl4GZYYHlR1JPSdLGTaYeNEbn2+N8=; b=wKqznriz5sqkPR4gNIo96FqifvS8gtyNV/THpsuJK2WN4yTg1oEtGmKmguZFsHX9it BHRcGok9x6kOQMoG1rvjRyzlE9a8TVCwZSSWEd1WYcLZgAnksa6AmmhXVYHMcabHwJ2a 1bj/sAKD1B/Xh0xlkKMbW93BcoGC9+9MqhKLYtBP0n4xav0s5i15TywAMMa1ZPSf0StU r9Nc8VcsPQtTiNya6R6QROFKgydb6gLqk8qRT1ECh4PZbd4i8lms8RCE2kkAhyC0mPJH NHV8BinMHKIhlIP0FVVYwQ7plx1acYiIJz77LKu74d3csIe8d7hIHlTzZa/Aiuffy5bY q+Hg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=K2T7mqJc; arc=pass (i=1 spf=pass spfdomain=linux.microsoft.com dkim=pass dkdomain=linux.microsoft.com dmarc=pass fromdomain=linux.microsoft.com); spf=pass (google.com: domain of linux-kernel+bounces-45806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45806-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com X-Forwarded-Encrypted: i=1; AJvYcCWP3zNVEDcvbp2XdZfu1LPYosK+br5jmG3BVwzcRKz0LNNG1zRT3mULowBWzhqV55slR7rqx790a1eh0xD9dO4zG7+ZNMdvfnBTaPGK2Q== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p23-20020a056402501700b0055483d95442si5477572eda.89.2024.01.30.22.10.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 22:10:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=K2T7mqJc; arc=pass (i=1 spf=pass spfdomain=linux.microsoft.com dkim=pass dkdomain=linux.microsoft.com dmarc=pass fromdomain=linux.microsoft.com); spf=pass (google.com: domain of linux-kernel+bounces-45806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45806-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E3F391F25E83 for ; Wed, 31 Jan 2024 06:10:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C5D23E499; Wed, 31 Jan 2024 06:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="K2T7mqJc" Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4EA123E46B; Wed, 31 Jan 2024 06:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706681399; cv=none; b=jWgNraJ/2Sw9knZTP7jsfHIcN6QgzBsAm6TXHFwpemW8/VzgRBS2wcRHOE6oG3VwlfOJMQmIfd6QhzE6E+D3Ld4IedJTCGIKLjKLZxQU7D5DcpDB3KaXBjil9DilXtUTdooGGDi01Lyc8Oa42lhBc93p/Wk1h/MMoN9EkYy6xcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706681399; c=relaxed/simple; bh=xUlblym0tJsdi+bNCvzWtxF6YMnO9/+z+WSb3s72Nl8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cR4FGq5mWkKetTnO4idGS6LVilGOwJ1Iso6MR6253rxbhyv9g742lmulcTKUwEc5uPS2QvKeF3FoKV7l7ClIGhdseLiVO9CRjmyoN31Ar0p119UnVAE2iZqIQtUI2xCBTAKGFOkIKYdwFrwUfKLCd85qNCaGbZYSsRq7fKGnSFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=K2T7mqJc; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Received: by linux.microsoft.com (Postfix, from userid 1134) id A96E32057C14; Tue, 30 Jan 2024 22:09:57 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A96E32057C14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1706681397; bh=yg+VJO0K+0/jLaTvRKDfXImeE8FTSu6c4RAr38E++AI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K2T7mqJcI3CDBQ69l4jhStujPhYFfTIlKTpyTqQKKQwHNbyoRLjUDvkEEHh9lwcGy p7ogwcmO5gPvaH7vvrGp1+h8grCN77aaKMGQztN3X/jbPw2jugZlbSj6MHX5123aZO spFj/giH4uzoa5A3dIBwetLsr680eMjv7D9dCPeQ= Date: Tue, 30 Jan 2024 22:09:57 -0800 From: Shradha Gupta To: Jakub Kicinski Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Paolo Abeni , Wojciech Drewek , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shradhagupta@microsoft.com, stable@vger.kernel.org Subject: Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed Message-ID: <20240131060957.GA15733@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1706599135-12651-1-git-send-email-shradhagupta@linux.microsoft.com> <20240130182914.25df5128@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130182914.25df5128@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) On Tue, Jan 30, 2024 at 06:29:14PM -0800, Jakub Kicinski wrote: > On Mon, 29 Jan 2024 23:18:55 -0800 Shradha Gupta wrote: > > If hv_netvsc driver is removed and reloaded, the NET_DEVICE_REGISTER > > handler cannot perform VF register successfully as the register call > > is received before netvsc_probe is finished. This is because we > > register register_netdevice_notifier() very early(even before > > vmbus_driver_register()). > > To fix this, we try to register each such matching VF( if it is visible > > as a netdevice) at the end of netvsc_probe. > > > > Cc: stable@vger.kernel.org > > Fixes: 85520856466e ("hv_netvsc: Fix race of register_netdevice_notifier and VF register") > > Suggested-by: Dexuan Cui > > Signed-off-by: Shradha Gupta > > Does not seem to apply to net/main, please respin This patch applies to net, which is missed in the subject. I will fix this in the new version of the patch. Thanks