Received-SPF: pass (google.com: domain of linux-kernel+bounces-45814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Aakarsh Jain" <aakarsh.jain@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>, <linux-media@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
	<mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
	<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-samsung-soc@vger.kernel.org>,
	<andi@etezian.org>, <gost.dev@samsung.com>, <alim.akhtar@samsung.com>,
	<pankaj.dubey@samsung.com>
In-Reply-To: <bb6e3546-a596-4748-92d9-7cfc1f5e2db1@linaro.org>
Subject: RE: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt binding
Date: Wed, 31 Jan 2024 11:36:44 +0530
Message-ID: <010301da540b$accfe490$066fadb0$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Language: en-in
Thread-Index: AQI/PvU03lDO5YGArwDNxcQQAt8ooQHpnmsRAg4hmkMB/4tQ4q/53L+w
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20240130125754epcas5p2edd5cc52dc58add09299d3aa5985a9fd@epcas5p2.samsung.com>
	<20240130125748.54194-1-aakarsh.jain@samsung.com>
	<9a8cb901-8021-42a3-a13b-bae10a645011@linaro.org>
	<bb6e3546-a596-4748-92d9-7cfc1f5e2db1@linaro.org>


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 30 January 2024 19:57
> To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm-
> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com;
> mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> krzysztof.kozlowski+dt@linaro.org; robh+dt@kernel.org;
> conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org;
> andi@etezian.org; gost.dev@samsung.com; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com
> Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt
> binding
> 
> On 30/01/2024 15:25, Krzysztof Kozlowski wrote:
> > On 30/01/2024 13:57, Aakarsh Jain wrote:
> >> Commit "538af6e5856b" which convert s5p-mfc bindings to
> >
> > Please run scripts/checkpatch.pl and fix reported warnings. Some
> > warnings can be ignored, but the code here looks like it needs a fix.
> > Feel free to get in touch if the warning is not clear.
> >
I am getting below warning while running scripts/checkpatch.pl on this patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
deleted file mode 100644

total: 0 errors, 1 warnings, 0 lines checked

I think this can be ignored.
> >> json-schema is already merged. Remove "s5p-mfc.txt" file.
> >>
> >> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> >> ---
> >>  Documentation/devicetree/bindings/media/s5p-mfc.txt | 0
> >
> > Why you did not remove it in the first place? Your diff from
> > 538af6e5856b is so confusing.
> 
I missed it before. Will add Fixes tag.

> Also, add fixes tag.
> 
Sure.

Thanks for review!
> Best regards,
> Krzysztof