Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1473746rdb; Tue, 30 Jan 2024 22:27:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGug8EHmwHl8UIaYpy97O4wLTQBFbRwU+HZxxmZWKd93dndY+taqF1td+hq6NkOQ9YmzrKg X-Received: by 2002:a17:906:351a:b0:a36:1fa0:d3db with SMTP id r26-20020a170906351a00b00a361fa0d3dbmr359596eja.77.1706682431331; Tue, 30 Jan 2024 22:27:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706682431; cv=pass; d=google.com; s=arc-20160816; b=QeqOTSndG4B7yvgquLKWcxyyXwyMVs897sjcZzRtVmbPaWNah2NV8w8Q4y/8YTZoBr OQ7K8Zmk+DDPtXmTJfkHAAggPlA4P36DJHN/Ez1nA9If84z4d6dPPe4gXtztLF1Xp6YM sj7fCrc5+/+2T1VokFJEYNqtc0GAZymzXujdJdOmmswQ78oG6y3KxCnIP8AvNMNnxDbI KxweIeUMdIDjsy4x5iB8+snfwfQ9ZoYNjNgHUX0DRMX8vALRMq024x5BNBzxVxttXroH ThhxywDgAtyHF1Ep2RWw2jLrTddACpU6veev86i8RwzmDuUduXSSktV4K+wFpjTJObr3 sfPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=JQ1K+MNxntxzlJ3HvG048dfjnQn1oAxwWi7aNakinjA=; fh=aAKU0KXmp5Jy+mPTYq4rQCsiLZxBdUqPNjsUX71+b08=; b=edSQ4fV5tcdc0UhT6hBXdnZZMaFMz6+FawsPoY3oLg2lM3NDbqmDkAfjsBzAnutohW 7fFAcSwapLBHKhVgiNHSVtAx0NnFvgQdGYhSQg7oSxsbxAyXYg3ZlHEI41YX2hnDC/u4 +kFK0ls4yZVBf5bG403OIZlHj9hmNt+M2RBQjGo6mRdvUYfWxpsxGSm5dezxZ2GFep3d dvcGAd+1JUwokUBTVnY85kmdI75tLSxx/fGg82l83pXj3RyOX+6hvZiQYD9DoRMlD23q asU0POMLBzqZ43Fl6yzEX6KrFz8e/JP+nMksKjVOHAdDgMTedarNMuF45Tv/tijC1fly k/6g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-45822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45822-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXbKHWonCzLHCcIH0SSOixS5PpakTUF8J6SHTniH0isPSjFn27yBQkG7zt41Xm/F3/R+mZ50bu9Ix3OskvSxCR+CN5LgFuS+evWPuvpuw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id la10-20020a170906ad8a00b00a3672e2e035si329908ejb.332.2024.01.30.22.27.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 22:27:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-45822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45822-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7B7BE1F2896B for ; Wed, 31 Jan 2024 06:26:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 953AD3EA68; Wed, 31 Jan 2024 06:26:05 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2663E47A for ; Wed, 31 Jan 2024 06:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706682365; cv=none; b=IT+LZmAkdgqRNU3LRYn3wUqpzgiMUGFKKHAqYenEjbc+UeA5pKJEqxh/E07nnY8brkXQdK2HpuDSi1B+kt7+Xh/BQzZv2wRXmneX5W+2ERHLRJ0YXbiqZFEhN3eEpfYbWqby0Dff+k1Q2bhjUe3Q5A2akQPy1MhWVfUwT5wyjx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706682365; c=relaxed/simple; bh=JQ1K+MNxntxzlJ3HvG048dfjnQn1oAxwWi7aNakinjA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MO29yGIkBVwi+XIUPonN7jDpU8f5j9sR/zLMECKJIhDHJpnzS1n7GdhLXjeRT+R7BFIu9DqSD8N4c9rpeumiR8sDEEPfkzo0Y2PsCDH/OuTkizJohRJQPSJDHT5Yi8r02AQzodIcdJ9VT7jzyzJGc46JNMlEoinoInD7MTtiwd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 661FE68B05; Wed, 31 Jan 2024 07:26:00 +0100 (CET) Date: Wed, 31 Jan 2024 07:26:00 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: James Smart , Keith Busch , Christoph Hellwig , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 02/12] nvmet-fcloop: swap the list_add_tail arguments Message-ID: <20240131062600.GA16225@lst.de> References: <20240130094938.1575-1-dwagner@suse.de> <20240130094938.1575-3-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130094938.1575-3-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jan 30, 2024 at 10:49:28AM +0100, Daniel Wagner wrote: > The first argument of list_add_tail function is the new element which > should be added to the list which is the second argument. Swap the > arguments to allow processing more than one element at a time. Ooops. Looks good: Reviewed-by: Christoph Hellwig