Received-SPF: pass (google.com: domain of linux-kernel+bounces-45921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <279fc3e5-8470-4c46-ae42-7d345555a209@amd.com>
Date: Wed, 31 Jan 2024 12:53:11 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add
 wol-arp-packet property
Content-Language: en-GB
To: Conor Dooley <conor@kernel.org>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com
References: <20240130104845.3995341-1-vineeth.karumanchi@amd.com>
 <20240130104845.3995341-3-vineeth.karumanchi@amd.com>
 <20240130-smartness-relish-d7f13adcb18d@spud>
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <20240130-smartness-relish-d7f13adcb18d@spud>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXdqekNPSFNYbUlQZlNXM3ZnQzI1U2NxSkRJcHh0MjU1M1E2ZWowUHphWkJa?=
 =?utf-8?B?bHhHU3JWVHF3MG9sZ2o3TjJYdHVvdGI2OXhqY29GQnUzZ1VncU56SjhYOEpP?=
 =?utf-8?B?clIvY0FWSXh1WEJRYnU1cmtRSHM2czI2Q3AzOEZmTkJHbXd5SjFDOG5ja3k3?=
 =?utf-8?B?VnVhMlVDVkZXOEtnNFRxM3MrdTJXb3BvMUFYSkZTSWlZRmRSSUhaL2hWbmph?=
 =?utf-8?B?dnlraEMxRHdrVE1SZGRFQnhMYm9Mb0hySm1ZMjN6WldGWmJ0T2ZkMDM2T2Rv?=
 =?utf-8?B?MzBVLzNpSFZGaWtRbjBqOVE3ZDdxTHBZeTZDMkIzSFpEeHdrdFlhY1F6Um9N?=
 =?utf-8?B?Q0tON2N5a1pBMzByRVpFWEtmMVBreE5FVDgwT2dwZHp3TXhBTFo1b3BORGov?=
 =?utf-8?B?b0MrQ2hWNytBcHBIdnB2SVBEM09mZktIbE1URU0zNVhRVUI5RVZpejkxeits?=
 =?utf-8?B?VTRBRndyNHVNWEJKbUZZS1N1MTNJL0R3QlNNWDJsVWh1QktZM2xoUldlamZO?=
 =?utf-8?B?V1A2YWl5WEs0UjVJSVdOeUJIS0Y4TEtaQ0tWZEQ1WVVEOThFVVhoNGsrckl3?=
 =?utf-8?B?MU1ER2ZUNXZKS250cFdka2N5Qkx5QjNmejQ2K1l1bzVJQzJJL0tVekpVZm9h?=
 =?utf-8?B?MlBOcXNHZW15b1JqWk1IamJWaWplM1Vkb1lybW1GWjBIdFBoNWJaSDdtQnN3?=
 =?utf-8?B?OVJvMTVxYlVkd1ZMVWFHQ3NZR3RhbFprZE9QbldJVTlMSlQyditoTWh0UldX?=
 =?utf-8?B?eElFU3BXZlhQSmtOcDJkY0NnRjVaSUdURmMzcGU4bGpvNG94NFJYanY2c3F5?=
 =?utf-8?B?YUwycTJNMWVrbWhRVWdEaWN2OEY3WXlwN0p3MzQveFErMTREa1N2Z05BR0lh?=
 =?utf-8?B?NTFNMFAzSkFuYXdsNlVhVVN4NmdHNFJMRnhzUTJWQ2pPUS8yUW1MbDZEZXJz?=
 =?utf-8?B?Q3ZoRkM1cFc4bnhiOEZ3dEF4clArWUt3Y1RTaWpUK3RCeVMrdElWaXM4dFZk?=
 =?utf-8?B?TjZ6cHNPbWxFNm1RYVdXWUR5YURQbGxMTVh3ZXR4ZzJXckFFL2l4MHRXMWEv?=
 =?utf-8?B?OFVDSlQ4NERsUXgzdG9lRHJOaWJLTmxVRzBkeWoweFhDd0MzVDV3UVMyWGdh?=
 =?utf-8?B?UGlnaUxPQk5PaUZJRjFwVEQ0SFRwbEF2WHdIa1NjWmVERXpieURtYkIrU2JN?=
 =?utf-8?B?UUZaOW1ZeGd2Yk1sam5mK0k0Sm8xeGpNbkFKcVRQQlF6d09BZ1Q2em1KNjJr?=
 =?utf-8?B?TnIxNGo1cjhNWXpUK0ZOWkJPdHhqQ1M5NXFqMENOVm9VQVVWTmd6Y2ZQbSs1?=
 =?utf-8?B?dHJzeGJCMkxmaE1kdGwwbG9vOTZvNVR2T3RIdWU2Rk9hUUhLY1FadGhYTExq?=
 =?utf-8?B?c0hOTzVlN0RLcUVzbDk1cFVUK3d3SStjak01SFNMT2JDOUJRTUw0RGdVOGdq?=
 =?utf-8?B?ZzhhT1F1QWZrYndzRFhLelJEV0Z0VUI5UXp6M2ZuYmhiWHFRMWZrV1Z6akFD?=
 =?utf-8?B?M0h2TWk3QXhPdDRXTkhVR0IwSFFoa2xUa21aRW9veUQ2MlljemNFRSs3c3c1?=
 =?utf-8?B?TnFMMUxoR05iN1JPUFFLemFKMk1TZ0VLQmxzZm4vS2RuK0tveFYrMklUUzJF?=
 =?utf-8?B?TnkvNkduK0xvaUtWbjJkcUpYYWx5WUF0RksrbUcrdUw2OStueVNFVHJWRVgw?=
 =?utf-8?B?RzJ3TDJxT3gwTTRKUzhpbGVIYUdsRVNRaExpbUp2WGFUOHlIcFdOTE9BU0RH?=
 =?utf-8?B?SkhDdlNWTWF3NlE3bzBValNjVy9BSXAwUTZNNkhkeDBOOGZXc1BoSlhFcVlP?=
 =?utf-8?B?NytwWkpFMUpmcU1XeVo0VUhJbVpiTE4rVkZYRG1KeG5OVmE2UTd2dzQwYnZ0?=
 =?utf-8?B?Z2pub3UzTFVBcmFadHRtR0EybHRNVDlUREJIc1E4TWpEbzVIdXdJOW41M1dp?=
 =?utf-8?B?d1BFcnowdVhKVEtseXAyVXdsK2FMbkc4cXpTclFDN2hKMzN4WVpEOGdYNDhR?=
 =?utf-8?B?Z2FINS9pWDdSbTNsL294UHdPTnc2Z2F5RWVraFArcEdTbTJtOTdtZ3p4NWtQ?=
 =?utf-8?B?TDJzMms0aE5la2U0Mm5qV3JmaG1WRFZUSnhLTXRPVVVqZ2duUDNTNkxnZGZo?=
 =?utf-8?Q?llRkcnx9+ouc3Z/EG4oinOR5l?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b617cdf8-8d16-465e-ba69-08dc222d8089
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 07:23:20.7874
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YOmSF5dRah2ol3x2Pl0ZvyTh8lKQHfLb7hqnXWRHHecpkJviA/kpHbTiWs+viFG/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6097

Hi Conor,

On 30/01/24 11:00 pm, Conor Dooley wrote:
> On Tue, Jan 30, 2024 at 04:18:44PM +0530, Vineeth Karumanchi wrote:
>> "wol-arp-packet" property enables WOL with ARP packet.
>> It is an extension to "magic-packet for WOL.
> 
> If it is an extension to "magic-packet" why does it not depend on
> "magic-packet"? Are there systems that would only support the magic arp
> packet but a regular magic packet?
> 

The IP version on ZU+ and Versal supports the below combinations for WOL 
event:

1. Magic packet (Wake-on magic packet only)
2. ARP (Wake-on ARP packet only)
3. Magic packet or ARP (Wake-on magic or ARP packets)

The existing DT binding already has one entry for
wol via magic packet. We are adding ARP packet support to the existing 
implementation.

I will change the commit message in v2.

>>
>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
>> ---
>> 7c4a1d0cfdc1 net: macb: make magic-packet property generic
>> which added magic-property support and wol-arp-packet addition
>> is similar extension.
>> ---
>>   Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> index bf8894a0257e..4bea177e85bc 100644
>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> @@ -144,6 +144,11 @@ patternProperties:
>>           description:
>>             Indicates that the hardware supports waking up via magic packet.
>>   
>> +      wol-arp-packet:
> 
> Bikeshedding perhaps, but why not call it "magic-arp-packet" if it has
> the same function as the other property here?
> 

Magic packet and ARP packets are two different wol events.
IP supports configuring in the above-mentioned ways.
Hence, I think it would be good to not mix with magic packet.

Please let me know your suggestions/comments.

Thanks,
Vineeth ????

> Thanks,
> Conor.
> 
>> +        type: boolean
>> +        description:
>> +          Indicates that the hardware supports waking up via ARP packet.
>> +
>>       unevaluatedProperties: false
>>   
>>   required:
>> -- 
>> 2.34.1
>>