Received-SPF: pass (google.com: domain of linux-kernel+bounces-45934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <09ce2e81-01cc-431f-8acb-076a54e5a7e6@amd.com>
Date: Wed, 31 Jan 2024 13:09:19 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add
 wol-arp-packet property
Content-Language: en-GB
To: Andrew Lunn <andrew@lunn.ch>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com
References: <20240130104845.3995341-1-vineeth.karumanchi@amd.com>
 <20240130104845.3995341-3-vineeth.karumanchi@amd.com>
 <824aad4d-6b05-4641-b75d-ceaa08b0a4e8@lunn.ch>
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <824aad4d-6b05-4641-b75d-ceaa08b0a4e8@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RStqUVRlTW1kWGFETTNiNldGeC81UWlSVFpPKzdjcnNYK3I5UHlBd1UvSThX?=
 =?utf-8?B?TDd2dzBnUzBXZy9Ga0tZem5LKzRtcE5TU3B5WVZSaE1XZEN1Y1RSaTF0Qmk1?=
 =?utf-8?B?Um9WZno2NEhQMzVjQ1FWbHZRcUVlWDBMUnRiNGs0Vk1kLzdxRWhBMzliRlMw?=
 =?utf-8?B?L002a1pLLzZPR1dJYnpNOTh3d1VPSkk3bmhRT2hQaWpNYWlnWnQ0MzZGUTBH?=
 =?utf-8?B?ZStGcEk5d0d1RHIyeVZhNGZqNlY5ZHh0OE9JVGlNSUZkcmFhdnhYdVJ5cC83?=
 =?utf-8?B?RUk5VVlXRjZQb2JBbktvOEFTZ1FBWUUxYitBV3lRazdZUmxrNXFHNmwvRDhV?=
 =?utf-8?B?WXJSRWFjMWpSbjNmQm1IVXBVS3NRRHF3V1hNT2J4UThKeG9SQ2VpN1hqTkVY?=
 =?utf-8?B?L0FIM2JkRDk3UnZSdUdka3FXZEkyb0tQRVRSdkdtZmNXVkEzcUJHMUdQbWVJ?=
 =?utf-8?B?Y0VXQ2Nhek9IMUNxVEtPVUlidTZaYTcwNGRwd2RsUURhQlRyN2tFUngreXk3?=
 =?utf-8?B?QitTeVh3SmdJc1B1V2FBMFRtRSs4amtQNmdLTGJzUitzMTZNeDBsM005dkxo?=
 =?utf-8?B?WEduRjFzaE55MzZMeXY4Z3JjcFNmb1NZbVBidFA4QlQ5Z3VjUzZPdmYvRlp5?=
 =?utf-8?B?TGF0MmlJajlLbjBtMjhVWlhnL1JKbklvdzUvMEF3OXk4UkpSYW1XNmNYT2V4?=
 =?utf-8?B?bnN4YVY2Z2RVbURlOXlGbEpsMFNVZVAvb1B2VzNBK0JuNmlmMndOOHJEd2FT?=
 =?utf-8?B?cXBWVCtaY0FnNlRsZ1VuKzNwaThJdWJZMk9PT2poZ1IyRm8yckdncDNTOUZh?=
 =?utf-8?B?SUEzODlseWdPUzJ2di9qWEVieEZFSGEvYjZlUjBaWXU3UzdQaytsdEF2T1BS?=
 =?utf-8?B?QzliVGllVjdXZVNrSS9ZbFVGYlBxbUx5blBoR3R5WVV3d0JBZUtFS0w4RnUx?=
 =?utf-8?B?MkhLUW9XQXNDWEFkd1RXYyttRk1FYWRRcklhdmV5T1Q2M1IzeXRnSGtsOGd2?=
 =?utf-8?B?YWRYR25tT08wZzlWVS8raVgwcDQ3U1JpU0hFRFY5Mm5FRTM4ZjdNTnFJVzh3?=
 =?utf-8?B?NXFscjZmK3hnSGpWZUhRTEl1QW5YQWdmKzhlM3lrdG5oOUpUem9RMy9IQTho?=
 =?utf-8?B?OTlyaFhRdG5LajBXVWZweTBkQ2RMM3BKQUlqZXNvakwrdW94Y0V1L05jekVE?=
 =?utf-8?B?SUt5V0FZYTFoNkhFR3pld3Nrd3pLVmFVS0dFd21MNzEzM0c1L09jU2pKTTM1?=
 =?utf-8?B?SDl5QnZ5RThxZTZCNkxoc09CZ0MzcE1kWlRRM3h0UmllYzloNSsvME90YmJL?=
 =?utf-8?B?cWRBK3FuNmU4YVRwS0ZQS3QxdW1TL3lQdjlRV2ZKK0x1ZlpOQ0hLeDZ1THIx?=
 =?utf-8?B?T0RiclZpZFd4aUpLeEYva1ZJK3dNZFF4Znl4aEVZOGVNRFJid3Fwa204L2dI?=
 =?utf-8?B?c1RHUjZFbzhhc2huNkI1cnhpdEJ4WHZYMzJEbURwNmp1ZjIvQUprZmxON2I3?=
 =?utf-8?B?NGFsSE8rY2NBejA4bWtkM3d5eHEycUhTTEZ6SFFtSjhMTVVrU2MrRlVoRnhp?=
 =?utf-8?B?akxjUzBqNlJhZG50bVJzWkM5RzNHRjJMMzZWaDFJR2s5QTh1MGEzb29TMksw?=
 =?utf-8?B?RG9wWEJJYlhEWEtJYjNvTHA2eG5NRzErK25VQ3hCMWFySXdLRTFHeFpGRGFX?=
 =?utf-8?B?QkFBaTVQTW5ybnMxQ1JXWHhUUGdCcVF2K2pWdWkyNXFWVk4zY0FubHhrZTFN?=
 =?utf-8?B?NTJ6djVsbjNFOW5FU09qSnUrWGViaEJJSUhJbkhNaUxya1dYRGY3bExuclpZ?=
 =?utf-8?B?VFBQcmFRT2Z4clJkY0xWdWM1Umo1cDB5T1lKYjhVUGh1MFArc3RQclNmZHN6?=
 =?utf-8?B?ZzR4MDF6QWs4NnU2Yk1HMVpyTWYxZXJmcVcrbTc1d3RNZVlkNDFZR1EzNFZP?=
 =?utf-8?B?Q1RvQ0lmQlNMSE1pM3RyQjdvKytVMjZOSTlUanJlZnJNLzE5eGovRStibTd5?=
 =?utf-8?B?KzNaNllIUXlUKzNncXNHZlFhZ0dDaFg0T2hXN3UvbzZOVXdPekliTGRxODlK?=
 =?utf-8?B?YUdYY3BKZVpTQkNkQi84dkZEL0N1bzNSZGh3dDNDL29LM0xTWUdpY2NIYm94?=
 =?utf-8?Q?iS4sFJGTHy2F3pdReKW4+yokZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d09582a-e994-4054-d217-08dc222fc17f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 07:39:28.7551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TBkY7tn6ZpQiZssWoAn+H46jOKW4YJn9FxCbUDx032SX+tfiKm2e3Dd7thy9e89p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8451

Hi Andrew,


On 31/01/24 6:56 am, Andrew Lunn wrote:
> On Tue, Jan 30, 2024 at 04:18:44PM +0530, Vineeth Karumanchi wrote:
>> "wol-arp-packet" property enables WOL with ARP packet.
>> It is an extension to "magic-packet for WOL.
> 
> It not clear why this is needed. Is this not a standard feature of the
> IP? Is there no hardware bit indicating the capability?
>

WOL via both ARP and Magic packet is supported by the IP version on ZU+ 
and Versal. However, user can choose which type of packet to recognize 
as a WOL event - magic packet or ARP. The existing DT binding already 
describes one entry for wol via magic packet. Hence, adding a new packet 
type using the same methodology.


vineeth


>      Andrew