Received-SPF: pass (google.com: domain of linux-kernel+bounces-45938-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 08:42:41 +0100
From: Johan Hovold <johan@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Johan Hovold <johan+linaro@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the pci-current tree
Message-ID: <Zbn58XcoOXauLUjN@hovoldconsulting.com>
References: <20240131125843.29e54460@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GjSVFlK1+j0Pd+dz"
Content-Disposition: inline
In-Reply-To: <20240131125843.29e54460@canb.auug.org.au>


--GjSVFlK1+j0Pd+dz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024 at 12:58:43PM +1100, Stephen Rothwell wrote:
> Hi all,
>=20
> After merging the pci-current tree, today's linux-next build (htmldocs)
> produced this warning:
>=20
> drivers/pci/bus.c:440: warning: Function parameter or struct member 'top'=
 not described in 'pci_walk_bus'
> drivers/pci/bus.c:440: warning: Function parameter or struct member 'cb' =
not described in 'pci_walk_bus'
> drivers/pci/bus.c:440: warning: Function parameter or struct member 'user=
data' not described in 'pci_walk_bus'
>=20
> Introduced by commit
>=20
>   69fb843fdbd9 ("PCI/ASPM: Fix deadlock when enabling ASPM")

Bah, I added a newline after the opening /** when moving a comment
without noticing that the kernel doc comment was malformed.

Bjorn, you could either remove that newline or squash the below patch
address this.

Johan


diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 116415f91195..826b5016a101 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -425,9 +425,9 @@ static void __pci_walk_bus(struct pci_bus *top, int (*c=
b)(struct pci_dev *, void
=20
 /**
  *  pci_walk_bus - walk devices on/under bus, calling callback.
- *  @top      bus whose devices should be walked
- *  @cb       callback to be called for each device found
- *  @userdata arbitrary pointer to be passed to callback.
+ *  @top: bus whose devices should be walked
+ *  @cb: callback to be called for each device found
+ *  @userdata: arbitrary pointer to be passed to callback
  *
  *  Walk the given bus, including any bridged devices
  *  on buses under this bus.  Call the provided callback

--GjSVFlK1+j0Pd+dz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQHbPq+cpGvN/peuzMLxc3C7H1lCAUCZbn57AAKCRALxc3C7H1l
CPpAAQC4RNRa7mhHKoWOZh7t9zxoRLj/MyUUw9Ekqb21tHB4UwEA1DpbLPPMAXVC
xiWFBkDiW7pBKBbBrlltq1Ca8/5OwAw=
=6Txi
-----END PGP SIGNATURE-----

--GjSVFlK1+j0Pd+dz--