Received-SPF: pass (google.com: domain of linux-kernel+bounces-45969-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 31 Jan 2024 09:07:31 +0100
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: carlos.song@nxp.com
Cc: broonie@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, 
	kernel@pengutronix.de, linux-imx@nxp.com, benjamin@bigler.one, stefanmoring@gmail.com, 
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: imx: fix the burst length at DMA mode and CPU mode
Message-ID: <20240131-chant-reoccur-7d63ba3f02cf-mkl@pengutronix.de>
References: <20240131024623.329240-1-carlos.song@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jtfsgbyo4qbif4eb"
Content-Disposition: inline
In-Reply-To: <20240131024623.329240-1-carlos.song@nxp.com>


--jtfsgbyo4qbif4eb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 31.01.2024 10:46:23, carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
>=20
> For DMA mode, the bus width of the DMA is equal to the size of data
> word, so burst length should be configured as bits per word.
>=20
> For CPU mode, because of the spi transfer len is in byte, so burst
> length should be configured as bits per byte * spi_imx->count.
>=20
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> Reviewed-by: Clark Wang <xiaoning.wang@nxp.com>
> Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length when=
 using dma")
> Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead of =
assuming 8-bits")
> ---
>  drivers/spi/spi-imx.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 546cdce525fc..b4ade2d53fef 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -54,7 +54,7 @@ MODULE_PARM_DESC(polling_limit_us,
>  #define MX51_ECSPI_CTRL_MAX_BURST	512
>  /* The maximum bytes that IMX53_ECSPI can transfer in target mode.*/
>  #define MX53_MAX_TRANSFER_BYTES		512
> -
> +#define BITS_PER_BYTE	8

That's already defined in linux/bits.h

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--jtfsgbyo4qbif4eb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmW5/8AACgkQvlAcSiqK
BOg1OAf/bUwQbbRLPxGg97y5z77Tf6W/qHPq+joFq6yuMrDO9mU5tJ9EJN76U3as
WkhlAJYUFNUJacnFrq5AykxMzJwolQvob2QX/68Mlkw0ufIfEbKzjHG1pnVCB7sw
LzjuYM58Rg+WItRZmvUtGXrH/harMcIPIJb3wVdGfZjjYlWYcgo/JmUFiULB0ZkG
9XfopZNHEn+vagex8ezqhoBnbAQkw4BnNSgw3vEs4iBlNzGXUqq4Gf5hW3gtTVpW
4f+tzeM1AwgLAclVSMEn1wxt3BApukBHPtOqDxIztAOZKb1Se4dx2BSXZ3JTlNP1
W5MJe6yLwaxgYsYpChX+SgdqVZ+eBA==
=R5St
-----END PGP SIGNATURE-----

--jtfsgbyo4qbif4eb--