Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1514852rdb; Wed, 31 Jan 2024 00:25:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfd29miGhW8tlfHnu8dWN6IuR6f73eCbgdZugpvSfl3Ba82+R4FI8hK6360vagqjE5ATCj X-Received: by 2002:a05:6808:1b27:b0:3be:c0c3:a1bf with SMTP id bx39-20020a0568081b2700b003bec0c3a1bfmr732626oib.30.1706689508998; Wed, 31 Jan 2024 00:25:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706689508; cv=pass; d=google.com; s=arc-20160816; b=ktBA1uljjMgiqbNbjT1EIItxYJ9cl9kSm1uere8RDL5+IFGbIMfrI4qUtmNdnuWOts tLF4FcUoEjudhBuV+kQc7WUBoBqoXmcxXmxe/1BrCKm6UkAjMjzb1IrhulMtxOZyh3Ub dhLNe2YHbWXs5bHsJ/9y56muPe93pcfkA66M3farvyAPjQ9jJTiBTyefwfERdiVPZOCL RlwmOk8rsqRep/aF9PYffByVDTwsZepmnO8MPA/h4WEiZAtzhqpTDehx2BdCjMvO5dhY 4tAcKfDDy0fhKRt9VnnhWm68YvX06CE+kaRQveSxIIHesKqkdXpheGCRrfM44FJeJPge rHGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:date:message-id:dkim-signature; bh=BATHeXE6YLReFxJgjH618xTQA2Y0kqWat5nvxqw9FgA=; fh=LdBV2z5zJr6ujZb1/IAnZuXnScX2V7tZMMBhGmAfF6U=; b=U8l3WLPuxcHuB3WytTK4vgMkFVhLTQpmFS8xVHBvAXWXG3245WUyUrNucBYg9vmDpA KN70UEV/ioKJv5tvIKgyzzCm/BVxkrqiHfWC3U7F8b/svCOBgNPTTAu95VFpLKMqmHpP b6u/xbFtXbpaoiaFuuB0uWdT+7+rIakF5fuY4cnFQYZR8IO369pW6/vHR6XupAefUrE6 KcC6EhOXDdPAU6QTuzbQA2orCayUVbuXRQH+qon+dKhWuK9BKXKa1PKjHDZXirl8e1wb izV5FZvE/8jkJuifqmBsb/ln/np0LSMn7G6rLyC9wLrnF5kyxv3ivcOUXar/S2tC5rmg 3VuQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CYRTZhpc; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-45991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45991-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=1; AJvYcCWZ5zMNTm3SqZPunq2TFCqZjDu4wIfayIfdcWuCZ70jHHNPR7ZsDYAK/U8GKUiVeHsHNVyxczQ6Ot9aBLvv61KBSA8mhV4V5IrWsOvkvA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b22-20020a656696000000b005d8c55d30e8si5637539pgw.363.2024.01.31.00.25.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 00:25:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CYRTZhpc; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-45991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45991-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A399F28BD63 for ; Wed, 31 Jan 2024 08:25:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2690D5DF21; Wed, 31 Jan 2024 08:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="CYRTZhpc" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539875813B; Wed, 31 Jan 2024 08:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706689490; cv=none; b=Qmq2wezFzTStoezZXShNuu8chX0wGE8ARNMOHIIZ2dVaaAPXZsGIX6pT8z6vD4rZWrJ307V9lRTFJt78oqCLdfGWHdjJNl1pIadeg8HeWIh0YyoOm5qKnMW6+bk0UbHZas5Uu8Jh6eB99OnbhuqIh6f4RUPk9M6mswse2FD+KHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706689490; c=relaxed/simple; bh=tn25MHQt9e+XeY213gUVx2kBtMJGCp5894PFZEy46Zk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=YQy0wF9dond39E2lPKO6jqvM6NyKZDvxijfQLeISSCLRuE5NBTDOFF8T1Jo7A4dyB1ydSLTi/cYaqha0V+TAtKtItlXKriUfxOwPL4mC7kRaGziMal8fvsfnf3KtquOGOCEz97NtU9qIWRLPAUPp0CZXFEeO2iRR9ozTV/oxd8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=CYRTZhpc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40V77XL5004425; Wed, 31 Jan 2024 08:24:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=BATHeXE6YLReFxJgjH618xTQA2Y0kqWat5nvxqw9FgA=; b=CY RTZhpcGPPVEHMa4KiFL0cQRIoqGNwkK5rpYeaMMocwVZSK63u/tTORc/FGQPIr8u AyzSNlO+e+b0jF/30tI/2CGBplRlNHjJFaDwL3fw69vSlQRraBOp+xNxauuNVN6I 0cZVDtoVIiTolW+b5s8XHGpSttV2VL0E9ETZmwz+V01FYvOpxK+VrEPK4Udb55m9 39xMyjwHdmt3lTVTG04e7RQv7XKeO88BvI+jxfzqcpNbGJtOlyp+Ju8pJhadxc1f tfKPcwZnCirEbx962PvLYDxAiN1Y4lO/0tmxObOKXfZl3MKv5v+JdyWYidkt8vYm CNXwvCk8tRRjmgPgVugQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vyfc8rm08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jan 2024 08:24:43 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40V8OgHU009321 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jan 2024 08:24:42 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 31 Jan 2024 00:24:37 -0800 Message-ID: <8a3866ee-d70b-419c-bde4-7bf55415402e@quicinc.com> Date: Wed, 31 Jan 2024 16:24:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] dt-bindings: pinctrl: qcom: consolidate functions to match with driver To: Krzysztof Kozlowski , , , , , , CC: , , , , References: <20240129092512.23602-1-quic_tengfan@quicinc.com> <20240129092512.23602-3-quic_tengfan@quicinc.com> From: Tengfei Fan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: p3oktYrZbuH3L2HKXmszgsrM7auN08H- X-Proofpoint-ORIG-GUID: p3oktYrZbuH3L2HKXmszgsrM7auN08H- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-31_03,2024-01-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 mlxscore=0 spamscore=0 mlxlogscore=728 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401310063 On 1/29/2024 7:24 PM, Krzysztof Kozlowski wrote: > On 29/01/2024 10:25, Tengfei Fan wrote: >> Consolidate functions to match with SM4450 pinctrl driver, because >> consolidate functions are being used in SM4450 pinctrl driver. > > It's very difficult to see what changed from the diff, so please explain > brieflyl changes here. > > What is that "consolidate functions" that you use in the driver? > > Best regards, > Krzysztof > please help to comfirm that the following description as commit message whether it covers your concerns: Pin alternative functions are consolidated(like: atest_char, phase_flag, qdss_gpio etc.) in SM4450 pinctrl driver while they are still split in DeviceTree binding file. SM4450 pinctrl function is broken if current binding doc is followed. Update SM4450 pinctrl DeviceTree binding doc to align with driver. -- Thx and BRs, Tengfei Fan