Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1543926rdb; Wed, 31 Jan 2024 01:39:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8b23Qo0ZhTpDNVgTehKhDWmqz3n2pOchSUMA9aiUrqY+2Icu93QXwsn3XP/CCbHbQRCQU X-Received: by 2002:a05:6214:ccc:b0:681:55a5:ec25 with SMTP id 12-20020a0562140ccc00b0068155a5ec25mr1534104qvx.56.1706693965192; Wed, 31 Jan 2024 01:39:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706693965; cv=pass; d=google.com; s=arc-20160816; b=1GrSaR7ISJRVzO1zkderDfa+IBXdbpAsIVOTjGZYkbjr0+ZlAcRSYAYm+F+lYl6V0D Sgtbhr1770ExMaT4i5PjZQXdBOebX52tzr7BJFSzt+4T+kABPO9JgEOgWte4CAH8gBz0 43xJFrEGxye3HryASiEhcxYsZePQMpGDOzpBw74sa85RLGVE9ZYyp3K8kw9Ixz/XwnWZ 5XnP6jxUctPohH4Bte/bVpwZ+coKnKv0B/slSD7/8+u0ZBDpCvwdFkX/qGw2bFiEnCRO xkjVtaoL/+dXe+ofVnVMACkBQuEVVPDHqBnJUeOgOUOdxvHUBKqlZgb/TGjRUvifGBGW D0vQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:from:references:cc:to:subject; bh=RAxYzvuilxa4J26VDXObFnTwptsAoMlgZQdnTAdyDLo=; fh=5sJVkDtMjQAB1JTs+PX8iEbGirS/6GdJgu594d4oeQY=; b=oN59seAac2Lmnojt732dnYsoNgeY5wuDP6EvH9jRmIrhxnZ/ae6FpgLYhkUKThoOW3 ocXQu58sikjoxf4p5MKduh7MiwOTFMPl/0QAQ4fpAU0eUl+QhuZfs86D+9S3drzl1s9S lehMloUAZbepr5RqVFbkFTs353X/B5+G2mQk1l05iPvoxRIQaMaWo2slmAWR6vXanG9m JDeVGHZjmsdj2vUD5b15or1GUwTD4Shs5QETQrI2cnOKGwpMmkf6gjjF0fuT20LVVyt6 JSdgrMPOG43fltoaptDWFjucOOfBzWYaRSjGun0fXQcCAdUcv5sBzt2Ij+yyP9kV89D/ 96KA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-46151-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46151-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com X-Forwarded-Encrypted: i=1; AJvYcCWZURiddgzXDAySsmnl6W9xrObVLCylB6Y3044PuIjYNLg+6xXmexetvJY+ZpfD2AivL7NXVeyAxKtw5rnQRRW3WBo0oRlOwXvMnR4WzQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id q6-20020ad45ca6000000b0068c5bc88d2fsi4246336qvh.457.2024.01.31.01.39.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 01:39:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46151-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-46151-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46151-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E96E11C23BD5 for ; Wed, 31 Jan 2024 09:39:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A2EF67A1A; Wed, 31 Jan 2024 09:39:19 +0000 (UTC) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB3E67A1F; Wed, 31 Jan 2024 09:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706693958; cv=none; b=SnSw2oXmHG7wvkKbU2jwYD3QXUyydoM3P1h92WbFFEJtdSTXwZOfg9cccYFKzqZH5AeNEeGMjJDw+itW83vPr4Kgfhaga33HIxSHUxm3h/XCaQIspQLRrlNlcZNfdIVw9fhy/zEi7naIpZMSBLdFslUNK6pISyB8hYRlS+DW1+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706693958; c=relaxed/simple; bh=pposIYrbfP1FjTASnuUOZTLdStEf4fYnOwJN6SZpVBE=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=NM0EwHcMa1CncQEzNJOyr5JvACtMy57Kg91qxwJRcGO+P8rAHYlzBoIuVIHT69gtDOX4X9Joro2KAmRndpEmi1EEGfG39ILDb6rbZBxUJknTq0INQANstbqC8ZURzaC8OPWudnUGyr+z8T2h1fBDlCEgpfetWSZsRwljyhz7+9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4TPxlQ4w8jz1Q8FR; Wed, 31 Jan 2024 17:37:22 +0800 (CST) Received: from kwepemm600007.china.huawei.com (unknown [7.193.23.208]) by mail.maildlp.com (Postfix) with ESMTPS id 65A681A016C; Wed, 31 Jan 2024 17:39:13 +0800 (CST) Received: from [10.174.185.179] (10.174.185.179) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 31 Jan 2024 17:39:12 +0800 Subject: Re: [PATCH] irqchip/gic-v3-its: Restore quirk probing for ACPI-based systems To: Marc Zyngier CC: , , Thomas Gleixner , Lorenzo Pieralisi , References: <20240127110702.4068488-1-maz@kernel.org> From: Zenghui Yu Message-ID: <08b67af4-22d6-84f3-62ea-90a5e5e1eb25@huawei.com> Date: Wed, 31 Jan 2024 17:39:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240127110702.4068488-1-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600007.china.huawei.com (7.193.23.208) On 2024/1/27 19:07, Marc Zyngier wrote: > While refactoring the way the ITSs are probed, the handling of > quirks applicable to ACPI-based platforms was lost. As a result, > systems such as HIP07 lose their GICv4 functionnality, and some > other may even fail to boot, unless they are configured to boot > with DT. > > Move the enabling of quirks into its_probe_one(), making it > common to all firmware implementations. > > Fixes: 9585a495ac93 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node") > Signed-off-by: Marc Zyngier > Cc: stable@vger.kernel.org Looks good, Reviewed-by: Zenghui Yu