Received-SPF: pass (google.com: domain of linux-kernel+bounces-46239-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Claudiu.Beznea <claudiu.beznea@tuxon.dev>, "wim@linux-watchdog.org"
	<wim@linux-watchdog.org>, "linux@roeck-us.net" <linux@roeck-us.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "geert+renesas@glider.be"
	<geert+renesas@glider.be>, "magnus.damm@gmail.com" <magnus.damm@gmail.com>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>, "sboyd@kernel.org"
	<sboyd@kernel.org>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
CC: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, Claudiu.Beznea
	<claudiu.beznea@tuxon.dev>, Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: RE: [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of
 pm_runtime_put()
Thread-Topic: [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of
 pm_runtime_put()
Thread-Index: AQHaVC8iXcXSbumPXUOI0ciCmgv5kLDzuJVQ
Date: Wed, 31 Jan 2024 10:32:37 +0000
Message-ID:
 <TYCPR01MB11269AD7463C9C7C0A09A43A9867C2@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <20240131102017.1841495-1-claudiu.beznea.uj@bp.renesas.com>
 <20240131102017.1841495-5-claudiu.beznea.uj@bp.renesas.com>
In-Reply-To: <20240131102017.1841495-5-claudiu.beznea.uj@bp.renesas.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?HaUhnPIPrvWifMn2W8IplW5mCkhT1d04VxhCzHVMfc8I6TDeFcDq5eCGkAT2?=
 =?us-ascii?Q?V9PQLHNlD18gGs10SWqdh1eBiRviJyfucItQEUxwlo+h7ZPYKZ0c00ORbk5E?=
 =?us-ascii?Q?dmJUHgaVN6FXBHAlFnhCW+G0jtavmTpol3M1wS/UYuoRdN8zaRko3holo1pR?=
 =?us-ascii?Q?C0SRnfgd583nTQcUtyUhTzUEsRTzmeEsCn52AXYHQM5axix/glRTo0+3Yov/?=
 =?us-ascii?Q?omlF7dRjQsATZL5J27sI4GI+65qAFj1FiO1OtthfzAgFuufVjIpWl+9RjzGE?=
 =?us-ascii?Q?0ctUkyuIDi3OFCUnwvFoyx0cX2mp6gV+zGsnOmlwW05+meVelwwtCbcgt7EY?=
 =?us-ascii?Q?A2aI66eOGDUYV4HhupJKcEEcUW6VLEJlFyC9ayLYkq3bYGxSF5g6VKpZheYe?=
 =?us-ascii?Q?iqqugJEhw2c8UC9Cv8B/pj02FArMYPuVKvTXgRKTqsASxl5wx1TJmBLqIQvI?=
 =?us-ascii?Q?liBYvagF7VMSWAC3nVRKxLhh4j2TR10y3w7kQ/faXs7G/uGNIqdPoNcgCesn?=
 =?us-ascii?Q?WGUN7J8lL9Xdqz3bpydoGhflYW4hmh7eEtFzwJFVua6LV5b+A7ipNTNiqhFl?=
 =?us-ascii?Q?6ZBuro51W06l2nFnC1Y8edvA0klxU4TK3bcdNjZZmk4VrmMsik/E3Xpkbui1?=
 =?us-ascii?Q?Go/ZKBr851y0HE/2bqLJC2iAiS1rO40wXeVOxB+GeWUaOq6AYTE/AgXGS+MI?=
 =?us-ascii?Q?SX/t8XRw5t2Mgcshyv2irFkhFN9SwWdcQesyca1vLUEaIbUd4HtNJpF4ZdOF?=
 =?us-ascii?Q?AElPfHpD1pgleXrCsuiR2PpyiZYUiQCxDwo6fwzTmKWiwjqXLt1P7dVqcb3W?=
 =?us-ascii?Q?5onlIAvL00eC4oyj0lXCvXZREoR47kxtdNHgU4FUHobw1IEp1InZNS8Um5et?=
 =?us-ascii?Q?qyYmXlQ54RmxAXSwmKFHiNuy6mNwDguf1wk+N1cSCBYu5D422IB04o5nnZ67?=
 =?us-ascii?Q?Srqam2v0yZM8xDk9Q9WxpfQDz1fh2mIuB3QO/MPBXfOM8o8aCYf8rCa7wzi1?=
 =?us-ascii?Q?I0Aj8JlhTCF2lLFh+s+2xxy0/3CFnjrosKMMkeCqhYWGBGYBBMRyMjzbaKOn?=
 =?us-ascii?Q?6hdY29o/dfJqz3+RijsPOl6BgxQP2iTsydouPmoRCtW/Eq8bAgTI3PxRyeq8?=
 =?us-ascii?Q?eh8A9+rI9Q6E+ms5YsySQo2bwcUT40roij2s0YlEzSSCaZ9gKhir1bC2aemU?=
 =?us-ascii?Q?gFDMn133L/H7zu+gkYbqUQk1AqKpyGeQEuyT1HopHfDgAbdvr+HF7F8bRG5U?=
 =?us-ascii?Q?Ng45ADliSfM9TXl8h97jRBFQaqb9HqUTtkwYCBCTZg2dtU6L3IN6HqBbP99N?=
 =?us-ascii?Q?zzgTyBeUphB7/45Ciw6Mmf7Cc8/lQ8zHcffQ1DonpQyRT4h6fgSxqPHDwd4J?=
 =?us-ascii?Q?DQBwJTWUlLxRaxfYcUunvHXWlSlpAwjTUklHrONCJNiV4nV6kF1FOZUkR1e6?=
 =?us-ascii?Q?HQaKqtuQlFr0IXGgbkE4u2G4a3M/ZZ94/5uY5iSG10GbtAFp4mKVZaN9oHRi?=
 =?us-ascii?Q?IJNKPnScG3b0vL84gc/XAjBg+vCpfvzPxG+XQvzmTSlUstaQh6CNR7Nq/2ls?=
 =?us-ascii?Q?dUHl01mWRPUgf2qv0PSy8/SYm/ZRWkiQDKYhANekctQ/C8q7tjOpIMH3oTN9?=
 =?us-ascii?Q?VA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee248fe1-459c-4081-0e76-08dc2247f19f
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2024 10:32:37.1240
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 84JPnMe2MCSMQP6dhlEt5CCkhLJRTmBErtkJXSO39MmJ9C5KKnr73CoRW1/cYNPfUaDxV2I5IMevIiwD7KvhpfNe3M/2Jg2UG1AXEuO/RJ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYPR01MB10595

Hi Claudiu,

Thanks for the feedback.

> -----Original Message-----
> From: Claudiu <claudiu.beznea@tuxon.dev>
> Sent: Wednesday, January 31, 2024 10:20 AM
> Subject: [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of
> pm_runtime_put()
>=20
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>=20
> pm_runtime_put() may return an error code. Check its return status.
>=20
> Along with it the rzg2l_wdt_set_timeout() function was updated to
> propagate the result of rzg2l_wdt_stop() to its caller.
>=20
> Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>=20
> Changes in v2:
> - propagate the return code of rzg2l_wdt_stop() to it's callers
>=20
>  drivers/watchdog/rzg2l_wdt.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
> index d87d4f50180c..7bce093316c4 100644
> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -144,9 +144,13 @@ static int rzg2l_wdt_start(struct watchdog_device
> *wdev)  static int rzg2l_wdt_stop(struct watchdog_device *wdev)  {
>  	struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev);
> +	int ret;
>=20
>  	rzg2l_wdt_reset(priv);
> -	pm_runtime_put(wdev->parent);
> +
> +	ret =3D pm_runtime_put(wdev->parent);
> +	if (ret < 0)
> +		return ret;

Do we need to check the return code? So far we didn't hit this condition.
If you are planning to do it, then just=20

return pm_runtime_put(wdev->parent);

Cheers,
Biju

>=20
>  	return 0;


>  }
> @@ -163,7 +167,10 @@ static int rzg2l_wdt_set_timeout(struct
> watchdog_device *wdev, unsigned int time
>  	 * to reset the module) so that it is updated with new timeout
> values.
>  	 */
>  	if (watchdog_active(wdev)) {
> -		rzg2l_wdt_stop(wdev);
> +		ret =3D rzg2l_wdt_stop(wdev);
> +		if (ret)
> +			return ret;
> +
>  		ret =3D rzg2l_wdt_start(wdev);
>  	}
>=20
> --
> 2.39.2