Received-SPF: pass (google.com: domain of linux-kernel+bounces-46373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Sunil Kovvuri Goutham
	<sgoutham@marvell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Add support to read eeprom
 information
Thread-Topic: [net-next PATCH] octeontx2-pf: Add support to read eeprom
 information
Thread-Index: AQHaVDns8ZakWR231k2j6PaULzWF5A==
Date: Wed, 31 Jan 2024 11:37:52 +0000
Message-ID: 
 <PH0PR18MB44749B4066E3389F27B440D4DE7C2@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240125112133.8483-1-hkelam@marvell.com>
 <1c39b3eb-0616-4214-bcfa-aaba1bd4e4a4@lunn.ch>
In-Reply-To: <1c39b3eb-0616-4214-bcfa-aaba1bd4e4a4@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?wcXvHRJaq1RPAwd66GOo6lYArH59bVfQMUzgY1uTMBSJnPmpsoPibUe2owhI?=
 =?us-ascii?Q?aaqFwlbsYYOLj0pA8qdrxB0ovY/rXNiAZUgTE54tS0FYZfw9PGnaJf8a14Yz?=
 =?us-ascii?Q?4yvTMBW2ApdPaz0o043i7yznNS+KsoxKg28TFWLV+WGXtG8zpygxx8afAJ7e?=
 =?us-ascii?Q?5dD6B4egvqMEs0nKbGWxjUXDMP2hGc2MmzQL0fOW/QbMCCGRZ0xIP1xQrdt+?=
 =?us-ascii?Q?LG8h9dpQgDBiPUHoEAd0yrBU/ZcPyFQDkv9gEyW1eutowPerptEnSLohDkmq?=
 =?us-ascii?Q?0SQCmDauGGOjyODcjm76focSXT49ub0MT3XGLTi2p6qeKh2JPfeilrzvx+b5?=
 =?us-ascii?Q?9GdWF9ieJ5Ny6lvTSjuIEORCnXrGlFNvWSie9A3vJX4eWJo67xZjMXMmjnXz?=
 =?us-ascii?Q?BxLaOhXZw1C/zOztwx+QYmjxBTPcFFHB2+c+HkqkyWC6njZO3i6nj7vM4xVQ?=
 =?us-ascii?Q?bsiymrWnI307i9EA2ElBpz1klDHq8dPRr7y4jjLg0eIhFU8oWU9iAoTkeJsb?=
 =?us-ascii?Q?3ErpkCDP+vTp7jIp4iqE3jj1BlMclub1upWT8R4fu6Xa4wvJkHIHZycsSifo?=
 =?us-ascii?Q?rYmIk7U+AUpjFsHLJhsdEV0RSSjvRgVVDRgWS4u8umcqQZvxZax/vc0oq23v?=
 =?us-ascii?Q?20CLZek1mKNnZ9QPJ41iJfwUYzVi6rAeawtS1P4Bc/UjXsJ63k+/nOIX+6sm?=
 =?us-ascii?Q?HVFLYXngt/Hrqf6G9YwIzyXpU+OcASf1hhLxXeq61oQRFyfhKrOgfahRm2pj?=
 =?us-ascii?Q?L7VI+TDR7MpVIU1H9YNiOM5zDCPuxy5L2vkAEdn46uLcNeGVyriCpYn3xkn6?=
 =?us-ascii?Q?tWvhL1Oq0oN0DhDlS3rLNpnOnxMCdiRsJZ5GlxRLPedgFgM3uXP7BqWTizlB?=
 =?us-ascii?Q?U58waKDN5i4sJS2cvRtcdJi99JlW9/Wcq+1Vyy/1XvcY8VZSgsMjbN0QBlpm?=
 =?us-ascii?Q?Kp7HTM4F93jXVvWmwa8Owv24LDBY1FuTu5bZ8kdMLmNrTJWB3QyJmdDigJ3G?=
 =?us-ascii?Q?VZt4rg/K1pq66PIUi18gzdbJ60Xr4BeP7N4UhwhpmSgoBMLp+zGfcVWxoXIg?=
 =?us-ascii?Q?KiC9pq/whmxeYQ3UBQSOnXFwyTzUoC+fWJwLSCzdb/me0A17OHyGHdP8Tx3o?=
 =?us-ascii?Q?4amx5ydBYMYZVASAKOlSYRnnVqmCKDCN0Ug4a8qQReZqFaG7v0GQTTnosL0t?=
 =?us-ascii?Q?UPtRtOMMICIqEx8x0tZzyL3Bqb2cpYhF1dhNj0kebT8xx7ejPTSobQaPuKAO?=
 =?us-ascii?Q?bLgfmvwBxHB1G3oZT/zOMPZEmaDJ65uZ5J82k4uOf47AjwicCSsz2GjbYbcH?=
 =?us-ascii?Q?oOvv4YofoISz+uyyOdx+TzzupdfNWwAQxkOGLVG0CNwFP2h+iqvEhrjNjK1H?=
 =?us-ascii?Q?HqMuMtIHRSom4GnFOrvtKKUoTXdNqEhND5/uoGj5skSa2CVIm5/RIvJbAEPt?=
 =?us-ascii?Q?nVd4ieQoN/qpXVO13UzlNrrxV6X+kzHGER9JwhCKMOdEWgD0oQqP42YjRNzg?=
 =?us-ascii?Q?R2u8mOpVGteNg0eBKV8AWt9sS4Yu6skDl5/UnFOpEP8+tRfYns5ztL/Mtmy0?=
 =?us-ascii?Q?7z4zyhQZ2y198xTrVIc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e173599-a67f-43d6-4f42-08dc22510f55
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2024 11:37:52.4275
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DaPuUfZ5PNG9Sacrsevzd6zTdc2t/hC6vwJag4uWIPM94w/CCVoeUAqQBGVhGGtGJRirvB5Uum0VVOox99hTxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4180
X-Proofpoint-GUID: BEl4j78pyLd82B1xYbnAo5bVh7W-NvJk
X-Proofpoint-ORIG-GUID: BEl4j78pyLd82B1xYbnAo5bVh7W-NvJk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-31_06,2024-01-30_01,2023-05-22_02


> On Thu, Jan 25, 2024 at 04:51:33PM +0530, Hariprasad Kelam wrote:
> > Add support to read/decode EEPROM module information using ethtool.
>=20
> It looks like you have a very primitive firmware here, which can only ret=
urn the
> first page of the SFPs EEPROM. What are your plans to make this fully
> featured? Ideally you should not be using this API, but the newer API whi=
ch
> indicates what page you would like to read.
>=20
 Our firmware currently supports reading only first page. =20
Will submit V2 which uses new API considering the len/offset fields.

> > Signed-off-by: Christina Jacob <cjacob@marvell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
>=20
> These seem to be in the wrong order.
>=20
     I will fix in next version.
Thanks,
Hariprasad k
>       Andrew