Received-SPF: pass (google.com: domain of linux-kernel+bounces-46336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 31 Jan 2024 12:18:47 +0100
From: Jan Kara <jack@suse.cz>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: miklos@szeredi.hu, amir73il@gmail.com, viro@zeniv.linux.org.uk,
	brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
	linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: Use KMEM_CACHE instead of kmem_cache_create
Message-ID: <20240131111847.ujdhhab6wdebo6fn@quack3>
References: <20240131070941.135178-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240131070941.135178-1-chentao@kylinos.cn>

On Wed 31-01-24 15:09:41, Kunwu Chan wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/backing-file.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/backing-file.c b/fs/backing-file.c
> index a681f38d84d8..740185198db3 100644
> --- a/fs/backing-file.c
> +++ b/fs/backing-file.c
> @@ -325,9 +325,7 @@ EXPORT_SYMBOL_GPL(backing_file_mmap);
>  
>  static int __init backing_aio_init(void)
>  {
> -	backing_aio_cachep = kmem_cache_create("backing_aio",
> -					       sizeof(struct backing_aio),
> -					       0, SLAB_HWCACHE_ALIGN, NULL);
> +	backing_aio_cachep = KMEM_CACHE(backing_aio, SLAB_HWCACHE_ALIGN);
>  	if (!backing_aio_cachep)
>  		return -ENOMEM;
>  
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR