Received-SPF: pass (google.com: domain of linux-kernel+bounces-46507-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 31 Jan 2024 14:36:40 +0100
From: Blazej Kucman <blazej.kucman@linux.intel.com>
To: Song Liu <song@kernel.org>
Cc: Yu Kuai <yukuai1@huaweicloud.com>, Dan Moulding <dan@danm.net>,
 carlos@fisica.ufpr.br, gregkh@linuxfoundation.org, junxiao.bi@oracle.com,
 linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
 regressions@lists.linux.dev, stable@vger.kernel.org, "yukuai (C)"
 <yukuai3@huawei.com>
Subject: Re: [REGRESSION] 6.7.1: md: raid5 hang and unresponsive system;
 successfully bisected
Message-ID: <20240131143640.00003296@linux.intel.com>
In-Reply-To: <CAPhsuW7QHq4e+cHvZcw8c=ePpeSM69UKTEi8P40=-jOZn+YyyA@mail.gmail.com>
References: <ZbMnZnvyIyoWeIro@fisica.ufpr.br>
	<20240126154610.24755-1-dan@danm.net>
	<20240130172524.0000417b@linux.intel.com>
	<95f2e08e-2daf-e298-e696-42ebfa7b9bbf@huaweicloud.com>
	<CAPhsuW7QHq4e+cHvZcw8c=ePpeSM69UKTEi8P40=-jOZn+YyyA@mail.gmail.com>
Organization: intel
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 30 Jan 2024 20:55:39 -0800
Song Liu <song@kernel.org> wrote:

> On Tue, Jan 30, 2024 at 6:41=E2=80=AFPM Yu Kuai <yukuai1@huaweicloud.com>
> >
> > Can you test the following patch?
> >
> > diff --git a/drivers/md/md.c b/drivers/md/md.c
> > index e3a56a958b47..a8db84c200fe 100644
> > --- a/drivers/md/md.c
> > +++ b/drivers/md/md.c
> > @@ -578,8 +578,12 @@ static void submit_flushes(struct work_struct
> > *ws) rcu_read_lock();
> >                  }
> >          rcu_read_unlock();
> > -       if (atomic_dec_and_test(&mddev->flush_pending))
> > +       if (atomic_dec_and_test(&mddev->flush_pending)) {
> > +               /* The pair is percpu_ref_get() from
> > md_flush_request() */
> > +               percpu_ref_put(&mddev->active_io);
> > +
> >                  queue_work(md_wq, &mddev->flush_work);
> > +       }
> >   }
> >
> >   static void md_submit_flush_data(struct work_struct *ws) =20
>=20
> This fixes the issue in my tests. Please submit the official patch.
> Also, we should add a test in mdadm/tests to cover this case.
>=20
> Thanks,
> Song
>=20

Hi Kuai,

On my hardware issue also stopped reproducing with this fix.=20

I applied the fix on current HEAD of master
branch in kernel/git/torvalds/linux.git repo.

Thansk,
Blazej