Received-SPF: pass (google.com: domain of linux-kernel+bounces-46542-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240117190545.596057-1-vincent.guittot@linaro.org>
In-Reply-To: <20240117190545.596057-1-vincent.guittot@linaro.org>
From: Erico Nunes <nunes.erico@gmail.com>
Date: Wed, 31 Jan 2024 14:56:35 +0100
Message-ID: <CAK4VdL3Bg70ycz5vd4RfwNYa3KcYU8rdPX==i7znzQFw_EgTjA@mail.gmail.com>
Subject: Re: [Resend PATCH] topology: Set capacity_freq_ref in all cases
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, 
	dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, 
	mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, 
	sudeep.holla@arm.com, gregkh@linuxfoundation.org, rafael@kernel.org, 
	linux-kernel@vger.kernel.org, lukasz.luba@arm.com, ionela.voinescu@arm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 17, 2024 at 8:06=E2=80=AFPM Vincent Guittot
<vincent.guittot@linaro.org> wrote:
>
> If "capacity-dmips-mhz" is not set, raw_capacity is null and we skip the
> normalization step which includes setting per_cpu capacity_freq_ref.
> Always register the notifier but skip the capacity normalization if
> raw_capacity is null.

I bisected an issue of cpufreq no longer working on v6.8-rc on a TI
SK-AM62 board and it pointed me to b3edde44e5d4 ("cpufreq/schedutil:
Use a fixed reference frequency").
This commit does fix the issue but doesn't appear to be merged
anywhere yet. It would be good to have this fixed before 6.8 release.

Tested-by: Erico Nunes <nunes.erico@gmail.com>