Received-SPF: pass (google.com: domain of linux-kernel+bounces-46549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 31 Jan 2024 07:59:55 -0600
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
	mripard@kernel.org, markyao0591@gmail.com,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add
 power-domains property
Message-ID: <20240131135955.GA966672-robh@kernel.org>
References: <6626d288-ecf1-436b-b0a3-3417308a8633@gmail.com>
 <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ba8b40d-005a-4665-afd9-a4eacf3e3031@gmail.com>

On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property. Fix example.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>        - const: default
>        - const: unwedge
> 
> +  power-domains:
> +    maxItems: 1
> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> 
> @@ -141,16 +144,18 @@ examples:
>      #include <dt-bindings/clock/rk3288-cru.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/rk3288-power.h>
> 
>      hdmi: hdmi@ff980000 {
>          compatible = "rockchip,rk3288-dw-hdmi";
>          reg = <0xff980000 0x20000>;
> -        reg-io-width = <4>;

It makes more sense to keep reg-io-width together with reg.

> -        ddc-i2c-bus = <&i2c5>;
> -        rockchip,grf = <&grf>;
>          interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>          clocks = <&cru  PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
>          clock-names = "iahb", "isfr";
> +        ddc-i2c-bus = <&i2c5>;
> +        power-domains = <&power RK3288_PD_VIO>;
> +        reg-io-width = <4>;
> +        rockchip,grf = <&grf>;
> 
>          ports {
>              #address-cells = <1>;
> --
> 2.39.2
>