DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=muNTs5KewwtPye9I5e0u86/EJOYhuUv87ssr/WWZ+3JVcvH9IXFct6KiLhOvlBdW5kBLF7ZoKaJWGthIl/BHy/Qq4j6KG3Xjp/f5EQazJ96CJH0lWaRouarG2smCaHTkE1Jj4sm5l8Oucd84hRGcL60L7tMPBlJ/n5lnfP60F0k=
Message-ID: <b6fcc0a0712190215g58de1ad9m53aee165fecaa278@mail.gmail.com>
Date: Wed, 19 Dec 2007 13:15:39 +0300
From: "Alexey Dobriyan" <adobriyan@gmail.com>
To: "David Chinner" <dgc@sgi.com>
Subject: Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning
Cc: lkml <linux-kernel@vger.kernel.org>
In-Reply-To: <20071219093834.GW4396912@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20071219093834.GW4396912@sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1118
Lines: 27

On 12/19/07, David Chinner <dgc@sgi.com> wrote:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7cd94146cd504016315608e297219f9fb7b1413b
>
> included security.h in mm.h and that is how I'm seeing the namespace
> poisoning coming from key.h when !CONFIG_KEY.
>
> Including security.h in mm.h means much wider includes for pretty
> much the entire kernel, and it opens up namespace issues like this
> that never previously existed.

ACK, removing sched.h from mm.h was quite painful and security.h
added it back unconditionally. As result, standalone mm.h inclusion goes
from ~9K to ~16K of code after preprocessing which is quite unpleasant.

> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -12,7 +12,6 @@
>  #include <linux/prio_tree.h>
>  #include <linux/debug_locks.h>
>  #include <linux/mm_types.h>
> -#include <linux/security.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/