Received-SPF: pass (google.com: domain of linux-kernel+bounces-46597-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Dragan Simic <dsimic@manjaro.org>, Andy Yan <andyshrk@163.com>
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject:
 Re: [PATCH 3/4] arm64: dts: rockchip: rename vcc5v0_usb30_host regulator for
 Cool Pi CM5 EVB
Date: Wed, 31 Jan 2024 15:24:16 +0100
Message-ID: <2179538.KUTt5R2Mg1@diego>
In-Reply-To: <1e98352e.2dd2.18d5f780043.Coremail.andyshrk@163.com>
References:
 <20240127092034.887085-1-andyshrk@163.com>
 <00ed78ea06aecde202a11a23c80f80af@manjaro.org>
 <1e98352e.2dd2.18d5f780043.Coremail.andyshrk@163.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Am Mittwoch, 31. Januar 2024, 13:21:56 CET schrieb Andy Yan:
>=20
> Hi Heiko=EF=BC=9A
>=20
> =E5=9C=A8 2024-01-27 21:09:46=EF=BC=8C"Dragan Simic" <dsimic@manjaro.org>=
 =E5=86=99=E9=81=93=EF=BC=9A
> >On 2024-01-27 13:15, Andy Yan wrote:
> >> At 2024-01-27 18:36:40, "Heiko St=C3=BCbner" <heiko@sntech.de> wrote:
> >>> Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan:
> >>>> According to the schematic, this regulator is used both for USB30 and
> >>>> USB20, so give it a more appropriate name.
> >>>=20
> >>> I don't have the schematics, so I'll need you to answer this, but what
> >>> is the regulator called _in_ the schematics?
> >>=20
> >> There are two regulators called VCC50_USB_HOST1 and VCC50_USB_HOST2,
> >> and they are both controlled by GPIO1_D5
> >> They both for two usb 2.0 hosts,  not usb 30, the schematics make
> >> me a bit confused.
> >
> >In that case, I'd say that renaming the regulator to vcc5v0_usb_host is
> >fine, but there should also be a comment in the board dts file that it's
> >actually two separate regulators.
>=20
> How do you feel about this =EF=BC=9F Or some other style like=EF=BC=9A
> vcc5v0_usb_host1: vcc5v0_usb_host2=EF=BC=9Avcc5v0-usb-host-regulator {

I think we're using such a scheme in some places already, and
yes I really like going this way. So that the phandles follow the
schematic names and we can still grep for things.


Heiko