Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1700358rdb; Wed, 31 Jan 2024 06:43:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5iA687yIYQDHlE3fHIY1SKZyM8k502+LfxZyFalqDFOaotPMNCCPLaah9RUBjmDjkHsA6 X-Received: by 2002:a05:6358:5bc6:b0:176:805d:4f1e with SMTP id i6-20020a0563585bc600b00176805d4f1emr1685415rwf.12.1706712217511; Wed, 31 Jan 2024 06:43:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706712217; cv=pass; d=google.com; s=arc-20160816; b=O+VPznNSn86FqAeQd4veVSYyFOjv48mr2qO1FRzd15PN/48BepjynR9NHLCZCF+HAS ZGpGOvzoOz9xXipBOOm2TiZjURH/x7Qh81LqEv1YQoUmlvgS2EVva+UokH8hyl1fYZIG yzPHUoyUJiZZiEeRFzae1HoTMjDj0pOrEgmax/pdtn3OvYSm6UKZU9K7TUH8TcKLFO2o s5Poe0UU2NR4GEJD6Xtk26SFwvBSOj97YHpkSfUZcfzhhImcKn5x5XVlMrCBOr+c5lrw fOqBfmue1Rj/uTSyunjiD9VeSd4EietYo3lGmMqbS9mq/leTAeZ/iRxWaCZKrID3iw3F 4ZOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ip6wAMfjAKlMvPvInahITjgX4kZb+/U3Es1e48tJ+Iw=; fh=vXSeSPc9AZCEY+9kD1HFfnsP+eG6ZQ0o9uY/dnlJX+8=; b=AkPuwoJWtkJKsXTw4kQ5lslFy8PVIGvexquiyMq/42GptnRN7m5hVPazbU/P30L3U0 GE0BxIn5OkuI3ndXhbcb9RvSAmUvLkPcQMVsYs4LuXWHXEjECxbYZ4/u+xBpII3WOk+A ov0hDxQ27JWPhinIWhOPVNZhBFBpMMGB/iO5ZEitQAvKAH/sC1v8eKx0o2hbv+umCZ3w GGEf7yht/yrHD4BWXrnt6r/DbvaglXqTbG0THbNPrDIe3cXU8ewu40kYieY0QnOdk643 3nus5INtDOft3YlMO0W8/NCc16XaAEvd17tjNYjPOWPE6zWRWsUEN7cOnibYP3m8n+co 5dMQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LN4XxyPn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-46581-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46581-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWFYP6HNt5G/smS/GKoPHGaB7PpMpRJKoUb8KtK56CYCoApk6s4fe7OjJpVKXB6OQ2pvCQMVh0S3xRX6/CKhy42ItpUJKjntI44VTRVOQ== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u72-20020a63794b000000b005db652f1ef0si3015860pgc.545.2024.01.31.06.43.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 06:43:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46581-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LN4XxyPn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-46581-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46581-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9DE99B26882 for ; Wed, 31 Jan 2024 14:15:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 84FEF8286C; Wed, 31 Jan 2024 14:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LN4XxyPn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A753D762DD; Wed, 31 Jan 2024 14:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706710505; cv=none; b=umIcJ8VGCWyCuO5bP68qjIGoUm67CHy30lGHcxnfc56CppI1DGJjvAy2ictxlREFW1YX7hupgDPg/ZWFbnF6DlUKG/RUox8W+riIq8QtjTOqhVPDD9+peF6vS2r06OXyiFe0c2mcc5VDBIvoGsdKefL9kptjOJFOOhZQuywFQCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706710505; c=relaxed/simple; bh=ab7imJk06Aq8BClWfw1+COONXRv86lAFnRitwwNKZ20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UoF+RFR1CdjEJ5X7UKf2N8FgrrXLCsNBavsG6BOqhIM39Ze33XrDDUTyOjnUii5fg1p04vIBrzU2K38V1BQSQzdl2LL9obtcCVrsC31kBnwy90acyrfrz7/BYsqdBFCujQbV2P41bywDNJnnrgr0P3jdTzBux1NB60XL8X1+Ckw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LN4XxyPn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0D88C433F1; Wed, 31 Jan 2024 14:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706710505; bh=ab7imJk06Aq8BClWfw1+COONXRv86lAFnRitwwNKZ20=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LN4XxyPnvDNtHC5lLts6xq3PdjkeOuf8MF48OfdOSQY/zB/xqrre8HfU2YaMN14v+ 70AGSIrkyCGfsl9ux3ydXKr9qvlLKvCUdO4/HcOSGwAxl2HMilm6TiIMEh1g07TDev fkvpNwJWUZjoRlPhVDX2MeX6pwdcCL6+LUtR+hHNfrgD0tVgtYGH2Gx7ERn38OPI/d o/G9Uuky2iBd8LgQe08BH2b1xxC/l16Zclk17U3uqbXiFAxWXyq9mqhg9gtMqu/Xex t8Wzi7FdxwNfrudlpUKCV9Z9Ghk0tVSNOUonihMmMYIpoP7lav9vo05XeUdTCm2S+O lyk5CAaD5Q+zw== Date: Wed, 31 Jan 2024 08:15:02 -0600 From: Rob Herring To: Conor Dooley Cc: Johan Jonker , hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, mripard@kernel.org, markyao0591@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property Message-ID: <20240131141502.GB966672-robh@kernel.org> References: <6626d288-ecf1-436b-b0a3-3417308a8633@gmail.com> <20240130-denim-capacity-e1617595ac9f@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130-denim-capacity-e1617595ac9f@spud> On Tue, Jan 30, 2024 at 06:18:49PM +0000, Conor Dooley wrote: > On Tue, Jan 30, 2024 at 03:55:43PM +0100, Johan Jonker wrote: > > The hdmi-connector nodes are now functional and the new way to model > > hdmi nodes with, so deprecate the port property and > > This doesn't really explain what makes having hdmi-connector nodes > replace the usecase for "port". > > > make port@0 and > > port@1 a requirement. > > Why? That means the deprecated way will always have warnings which makes documenting the deprecated stuff a bit pointless. Technically, new required properties are ABI break and something I'm working on making the tools check (by comparing 2 versions of schemas). That said, if all the upstream dts files are fixed already, then I don't care too much. > > Also update example. > > "Also do x" is a red flag when it comes to commit messages, as it > immediately makes me think that this should be more than one commit. > I'd probably write this as "Update the example to avoid use of the > deprecated property" or something to avoid bad gut reactions. > That's not worth resending for though obviously... > > > > > Signed-off-by: Johan Jonker > > --- > > .../display/rockchip/rockchip,dw-hdmi.yaml | 27 ++++++++++++++++--- > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > index 7e59dee15a5f..cd0a42f35f24 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > > @@ -97,8 +97,11 @@ properties: > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > - patternProperties: > > - "^port(@0)?$": > > + properties: > > + port: > > + $ref: /schemas/graph.yaml#/properties/port > > + deprecated: true > > This change makes the deprecated property's description incomplete, > since it doesn't cover the endpoints any more. It also doesn't make > port@0 and port mutually exclusive. graph.yaml has a check that effectively does that. Rob