Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1713755rdb; Wed, 31 Jan 2024 07:05:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2yy+QBqSi7x3hJcgyx0D0O4dxun2AUjhSzCX1DtNfZCGEA04dxRzovh2tRDiA2jrkpPWt X-Received: by 2002:a05:6a20:36a5:b0:19b:fdbd:66e4 with SMTP id s37-20020a056a2036a500b0019bfdbd66e4mr1610282pze.38.1706713539700; Wed, 31 Jan 2024 07:05:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706713539; cv=pass; d=google.com; s=arc-20160816; b=jDGADNggngHLHGK9EKnv1Pk3H1gao0fPu8Juiz1tTYiUs/Ovxa2tVhqLGDZQ+o77VK kiOZzLOAnn+eG33uIyROEnfxurfdsCOP4yLwDOgYbFXFo/9vFIOAFuCq4417ZktHce7S m1ztM5/NGf2fHbE+6fnLZNr2nv926iOYFe6EC62ilkNkj9dSGRWqvdjEBoMpHwPHdN15 j7qOBogBkFzDnXKrkhaMwBa+lGqC077x5fJgAL9yNIDwuXTRjC8TDxfNP3KRj2RMYFS+ EMq1VCVB6Wc/GSH2Ny1YJwiZRKlndnHHutTmrccSmTQMqN8RrXZK+TOgEcG4rZ76bZE9 WHcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pw+U8iahJ0CmhuCN4ZbIgl2mTW7ZjtW2xezbf/dgrRE=; fh=GexVqcMHiU06El0+aIH24WMYd2NrNod4qoF8HWSy5EM=; b=uFW1WJ5K8G7G0r7QXX/1pRI02cXiIDISDoikRkUW5JhMdYqePhP0ON/YBnLkG4n9dn /9RWkAQpb7OfMuv9YiZZeUwXg1g9qTPaZqU3h60cLiCMczVlXvBiSS0p6c03E9igwBT6 7VB4MT6LWdlPzTgklg5BoQMWmiQoAW8rrh+z2wzcZk1DfMGpRLn58BTU7cqxy9TdJ+/7 WrAzekdbVrg/JhaVYFJB4riVl2xq5HMkocEyBhYM9Z9oyOpLKUnGsaEnUrl1itFrdKpZ 8S8XB9Z8kyFk7RpOHoVOw9XnYJGgawDRD4Hd2mScSPGRzvuJheIP5FwdKkFD7fpsB++g rjbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ynnVoJSp; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-46608-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46608-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCWVwLvLhe/Mp+sur53KFL2QGSA7EJXL1qC1x87aflz35ixm0iaQLHQdYwXaslQRSU7+lL/2rpz4lqEXc+DLTOJlDZeQOqMVqw2Avpbg+g== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id g13-20020a63e60d000000b005d8e28279bcsi3648100pgh.540.2024.01.31.07.05.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 07:05:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46608-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ynnVoJSp; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-46608-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46608-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 62883B22F0F for ; Wed, 31 Jan 2024 14:34:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6019F8288D; Wed, 31 Jan 2024 14:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ynnVoJSp" Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D221DDCE for ; Wed, 31 Jan 2024 14:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706711648; cv=none; b=fjXYtfCQsLrgSPewnRpv6VhWGNCSoY4Uet9oHmxDd1OWJMNzpDyTmMBgtF1QJdIOdPueLOMxn5BAzq/dvBhDgv1uFZNjmwLfrLO7Hy0h+icQMvDA3r1xcYrXcXm4yMpy3xbwX9U5+RqIoxr2UdRA9rFqHtoxMq9D+WHiiaRe7CI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706711648; c=relaxed/simple; bh=pw+U8iahJ0CmhuCN4ZbIgl2mTW7ZjtW2xezbf/dgrRE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XPvJ5lGzu6SqFLYYP9YB3Kfkfbf2PMKJm6h0/ghUutnLAXQm85YSneQWLOB+WwtovwlLjoyGtJElHgdiEvOgsmO7RDf7SRiyWo3SjUKo/+QpJzMz6ypsKZ7bfdHDj3Bfw/9rvhvXXcTQvrBQU4ER0gE3+kvVLwBh8pGGSdGKDQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ynnVoJSp; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40fb0c4bb9fso9896035e9.0 for ; Wed, 31 Jan 2024 06:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706711645; x=1707316445; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pw+U8iahJ0CmhuCN4ZbIgl2mTW7ZjtW2xezbf/dgrRE=; b=ynnVoJSpmN6+EBPst/BcvEzVF9bVaW8nhpB9VqWK4HMFL89VCmAYiUZH4ZxYu80/Bk Lop+DxvXDRvzZNwxTcdtDgnI96ikIz1N94fI+SEGzHVOmjBjjZyxjC7VhOVUt3LMavP8 M45WS++SrDwrDYUL3Vm0ofiYyNg1gAE9q8uvvQ5z7B1OgHt/AtxwmfdjORFUJ2aKyXqj T4uq+LUe6Ggl1dC46p7BQuroH9v5K/w3bfYumzR+q6CoRN9eD8z43DrmriKp4L9JvDZA c1yq7m0Bioz6f55+1AdxBfYRtr9tw1O1zu/sk20zynYHvDC/O8BetVJk+5GPrAilc8Ii 1sYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706711645; x=1707316445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pw+U8iahJ0CmhuCN4ZbIgl2mTW7ZjtW2xezbf/dgrRE=; b=XAd9cQFTYap2YNpqN1TEeGIvRr8IPiUmHG/pLwgEwSXFItO7ueCJ2F38ty6D+R04vg WvHaWRHuqfVWTafAjPUg0nzSn4TXvtff4DITh9LFFehzZWwgoyCr/gOjhQRBe1iFMruZ ym5KeILTHryAy+TmmM2jmr26Z2NPbTWzEiLk1ymcQgWJ//uhTykLX5bAOVcaOJEeZ+fB SHaiMx9cip2l3qB3Ul5C/j/tetysRHPcWFdZ6NgSaBJvb3yJ5K0jGR+oClvDNP7aYzRq 3Ec//uFWkeQKK2HyoH0ip0zFtNlPVE8U5t2eYj9wjzoM31eJHqQb9LzusQ61Y8uMj9DD KvGQ== X-Gm-Message-State: AOJu0YxX8XdG4kVg3qjWVUFjxcsbb53SRGdKvzW/Zy+by+YfKwFV1uxg R8BH/GVbG/Dg/KfDHygqgJn5MthnEfB5c222pOTeBiaDtuP43ZHfzZvTwO9AhcU= X-Received: by 2002:a05:6000:1379:b0:33a:ee08:7541 with SMTP id q25-20020a056000137900b0033aee087541mr1386289wrz.35.1706711644956; Wed, 31 Jan 2024 06:34:04 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id n16-20020adfe790000000b0033afed6e9desm2888638wrm.98.2024.01.31.06.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 06:34:04 -0800 (PST) Date: Wed, 31 Jan 2024 14:34:02 +0000 From: Daniel Thompson To: Jianhua Lu Cc: Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: ktz8866: Correct the check for of_property_read_u32 Message-ID: <20240131143402.GA5929@aspen.lan> References: <20240129122829.16248-1-lujianhua000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129122829.16248-1-lujianhua000@gmail.com> On Mon, Jan 29, 2024 at 08:28:29PM +0800, Jianhua Lu wrote: > of_property_read_u32 returns 0 when success, so reverse the > return value to get the true value. > > Fixes: f8449c8f7355 ("backlight: ktz8866: Add support for Kinetic KTZ8866 backlight") > Signed-off-by: Jianhua Lu Reviewed-by: Daniel Thompson Daniel.