Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbXLSLbl (ORCPT ); Wed, 19 Dec 2007 06:31:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752528AbXLSLbc (ORCPT ); Wed, 19 Dec 2007 06:31:32 -0500 Received: from relay1.sgi.com ([192.48.171.29]:34512 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752505AbXLSLbc (ORCPT ); Wed, 19 Dec 2007 06:31:32 -0500 Date: Wed, 19 Dec 2007 22:31:12 +1100 From: David Chinner To: Damien Wyart Cc: David Chinner , Christoph Hellwig , Lachlan McIlroy , Peter Leckie , Linus Torvalds , linux-xfs@oss.sgi.com, LKML Subject: Re: Important regression with XFS update for 2.6.24-rc6 Message-ID: <20071219113112.GD4612@sgi.com> References: <20071218112804.GA3069@localhost.localdomain> <20071218122445.GJ4396912@sgi.com> <877ijckrco.fsf@free.fr> <20071218151946.GQ4396912@sgi.com> <20071219104544.GC4612@sgi.com> <87r6hjaq7p.fsf@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r6hjaq7p.fsf@free.fr> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 37 On Wed, Dec 19, 2007 at 12:17:30PM +0100, Damien Wyart wrote: > * David Chinner [071219 11:45]: > > Can someone pass me a brown paper bag, please? > > My first impression on this bug was not so wrong, after all ;-) > > > That also explains why we haven't seen it - it requires the user buffer to > > fill on the first entry of a backing buffer and so it is largely dependent > > on the pattern of name lengths, page size and filesystem block size > > aligning just right to trigger the problem. > > I guess I was lucky to trigger it quite easily... > > > Can you test this patch, Damien? > > Works fine, all the bad symptoms have disappeared and strace output is > normal. > > So you can add: > > Tested-by: Damien Wyart Thanks for reporting the bug and testing the fix so quickly, Damien. I'll give it some more QA before I push it, though. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/